r16377: Klocwork #1077.

Jeremy.
(This used to be commit 72709a8465caf5b7d95911250234f203b0ff4675)

diff --git a/source3/rpc_parse/parse_spoolss.c b/source3/rpc_parse/parse_spoolss.c
index ec2d6b84300fe4c73150969340aad5eea6d74a66..692a8c6ddf9acea2683a54c4d1da3fa008917dba 100644 (file)
--- a/source3/rpc_parse/parse_spoolss.c
+++ b/source3/rpc_parse/parse_spoolss.c
@@ -5005,11 +5005,16 @@ static BOOL uniarray_2_dosarray(BUFFER5 *buf5, fstring **ar)
                rpcstr_pull(f, src, sizeof(f)-1, -1, STR_TERMINATE);
                src = skip_unibuf(src, 2*buf5->buf_len - PTR_DIFF(src,buf5->buffer));
                *ar = SMB_REALLOC_ARRAY(*ar, fstring, n+2);
-               if (!*ar)
+               if (!*ar) {
                        return False;
+               }
                fstrcpy((*ar)[n], f);
                n++;
        }
+       if (!*ar) {
+               return False;
+       }
+
        fstrcpy((*ar)[n], "");
  
        return True;