Simo Sorce [Wed, 2 May 2012 18:53:45 +0000 (14:53 -0400)]
Fix krb5_samba.c build
Volker Lendecke [Wed, 2 May 2012 09:31:30 +0000 (11:31 +0200)]
s4:torture: add a check for talloc success in test_session_reauth
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri May 4 16:50:59 CEST 2012 on sn-devel-104
Volker Lendecke [Fri, 4 May 2012 11:01:32 +0000 (13:01 +0200)]
s3: remove some unused code
Volker Lendecke [Fri, 4 May 2012 09:49:24 +0000 (11:49 +0200)]
s3: Fix a typo
Andrew Bartlett [Thu, 3 May 2012 22:47:29 +0000 (08:47 +1000)]
s4-dsdb: Use data_blob_string_const and add explaination for open-coded function in samldb
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri May 4 02:34:41 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 3 May 2012 22:46:57 +0000 (08:46 +1000)]
s4-dsdb: Use strcasecmp_m() to compare possibly multibyte strings in samldb
Matthias Dieter Wallnöfer [Thu, 3 May 2012 20:55:06 +0000 (22:55 +0200)]
s4:samldb LDB module - make sure to not add identical "servicePrincipalName"s more than once
The service principal names need to be case-insensitively unique, otherwise we
end up in a LDB ERR_ATTRIBUTE_OR_VALUE_EXISTS error.
This issue has been discovered on the technical mailing list (thread:
cannot rename windows xp machine in samba4) when trying to rename a AD
client workstation.
Christian Ambach [Thu, 3 May 2012 16:34:32 +0000 (18:34 +0200)]
s3:passdb fix a compiler warning
this one could have caused crashes
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Thu May 3 23:22:05 CEST 2012 on sn-devel-104
Christian Ambach [Thu, 3 May 2012 16:32:06 +0000 (18:32 +0200)]
s3:vfs fix compiler warning
vfs_default.c:1875:10: warning: no previous prototype for 'vfswrap_audit_file'
Christian Ambach [Thu, 3 May 2012 16:30:38 +0000 (18:30 +0200)]
s3:lib fix compiler warnings
g_lock.c:182:20: warning: no previous prototype for ‘g_lock_lock_send’
g_lock.c:270:10: warning: no previous prototype for ‘g_lock_lock_recv’
Jelmer Vernooij [Thu, 3 May 2012 16:26:35 +0000 (18:26 +0200)]
UTIL_TDB: lowercase name.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu May 3 20:18:22 CEST 2012 on sn-devel-104
Jelmer Vernooij [Thu, 3 May 2012 14:38:31 +0000 (16:38 +0200)]
libtorture: Improve suggestion to mention torture_assert_*() rather than
torture_result().
Michael Adam [Thu, 3 May 2012 13:35:52 +0000 (15:35 +0200)]
s4:torture: add a new smb2.session.reauth3 test - getting security descriptor
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Thu May 3 17:38:14 CEST 2012 on sn-devel-104
Jelmer Vernooij [Thu, 3 May 2012 11:42:57 +0000 (13:42 +0200)]
torture: Suggest torture_fail() / torture_result().
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Thu May 3 15:31:06 CEST 2012 on sn-devel-104
Jelmer Vernooij [Thu, 26 Apr 2012 18:08:04 +0000 (20:08 +0200)]
provision: remove reference to no longer existing template files.
Andrew Bartlett [Wed, 2 May 2012 06:44:27 +0000 (16:44 +1000)]
s4-samba-tool: make new samba-tool group listmembers use samAccountName
This is the unique username value.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu May 3 01:57:41 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 2 May 2012 06:05:25 +0000 (16:05 +1000)]
s4-s3upgrade: Force ldapsam:trusted = yes
While this setting is not the default in Samba3, any domain that is
in a suitable condition to upgrade to Samba4 should already be in the
layout that ldapsam:trusted uses. It can be turned off by setting
ldapsam:trusted=false in the smb.conf.
Many upgrades to Samba4 happen on a different host to the old Samba3 domain
and this avoids the need to configure nss_ldap only for the duration of
the upgrade.
Andrew Bartlett
Lukasz Zalewski [Tue, 1 May 2012 20:17:33 +0000 (21:17 +0100)]
Extension to the samba-tool group subcommand functionality to allow listing of the members of an AD group
Andrew Bartlett [Wed, 2 May 2012 03:01:29 +0000 (13:01 +1000)]
s4-s3upgrade: Try harder to get group memberships on upgrade
This fixes an issue where some group types were not upgraded, as we
did not upgrade alias memberships.
It also uses enum_group_memberships() to try and find the memberships
from the other direction, by asking which groups a user is a member
of. As Samba3 (and NT4) does not implement nested groups, this should
be safe.
Andrew Bartlett
Andrew Bartlett [Wed, 2 May 2012 02:57:27 +0000 (12:57 +1000)]
s3-pypassdb: add wrapper for enum_group_memberships
This will be used in samba3upgrade to try and get the group memberships by instead asking
for the groups each user is in. This reverse lookup may be more reliable, as this
is used at login time.
Andrew Bartlett
Andrew Bartlett [Wed, 2 May 2012 02:55:54 +0000 (12:55 +1000)]
s3-pypassdb: remove unused variable
Michael Adam [Wed, 2 May 2012 16:09:48 +0000 (18:09 +0200)]
s4:torture:rpc: add a new test samba3.smb2-pipe-read-logoff
- open a pipe via smb2
- trigger a read which hangs since there is nothing to read
- do a logoff
- wait for the read to return and check the status
(STATUS_PIPE_BROKEN)
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed May 2 19:57:45 CEST 2012 on sn-devel-104
Michael Adam [Wed, 2 May 2012 16:03:33 +0000 (18:03 +0200)]
s4:torture:rpc: add a new test samba3.smb2.pipe-read-tdis
- open a pipe via smb2
- trigger a read which hangs since there is nothing to read
- do a tree disconnect
- wait for the read to return and check the status
(STATUS_PIPE_BROKEN)
Michael Adam [Wed, 2 May 2012 12:25:58 +0000 (14:25 +0200)]
s4:torture:rpc: add a test samba3.smb2-pipe-read-close
* open a pipe via smb2
* trigger a read which hangs since there is nothing to read
* close the pipe file handle
* wait for the read to reaturn and check the status
(NT_STATUS_PIPE_BROKEN)
Michael Adam [Wed, 2 May 2012 15:33:33 +0000 (17:33 +0200)]
s4:torture:rpc: fix a comment typo in samba3.smb2-reauth2
Michael Adam [Wed, 2 May 2012 11:55:45 +0000 (13:55 +0200)]
s4:torture:rpc: remove an accidentially committed character (in a comment)
Andrew Bartlett [Sat, 21 Apr 2012 00:22:35 +0000 (10:22 +1000)]
s3-passdb: Add extra debug on ID mapping failures
Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed May 2 15:34:13 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 2 May 2012 08:44:16 +0000 (10:44 +0200)]
s3-idmap: remove (now) unused function idmap_cache_set_sid2both()
Signed-off-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Fri, 23 Mar 2012 10:11:33 +0000 (21:11 +1100)]
s3-idmap: convert most idmap_cache callers to unixid API
This will eventually allow the struct unixid to be passed all the way up
and down the stack.
Andrew Bartlett
Signed-off-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Fri, 23 Mar 2012 10:01:01 +0000 (21:01 +1100)]
s3-idmap: Rework idmap_cache to store ID_TYPE_BOTH values
This required that the lower level cache store a UID/GID and a type, and that
we operate on struct unixid rather than just uid/gid.
The ID_TYPE_BOTH is then handled as being a positive mapping for both
a UID and GID value. Wrapper functions are provided so that callers are not
changed in this patch.
Andrew Bartlett
Signed-off-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Fri, 23 Mar 2012 06:58:39 +0000 (17:58 +1100)]
s3-winbindd: Do not use WBC_ types internally in winbindd
Use the types from idmap.idl instead
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 2 May 2012 07:49:02 +0000 (09:49 +0200)]
s3:passdb: remove a forward declaration of wbcSidToUnixId that has become unnecessary
Michael Adam [Wed, 2 May 2012 07:48:28 +0000 (09:48 +0200)]
s3:passdb: rename sids_to_unix_ids() --> sids_to_unixids() for consistency
Andrew Bartlett [Fri, 23 Mar 2012 06:30:34 +0000 (17:30 +1100)]
s3-passdb: Use struct unixid in sids_to_unix_ids
This avoids the union in the struct wbcUnixId and moves us to using only struct unixid
internally.
Andrew Bartlett
Signed-off-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Fri, 23 Mar 2012 05:51:47 +0000 (16:51 +1100)]
s3-passdb: Rename legacy_sid_to_id -> legacy_sid_to_unixid for clarity
Signed-off-by: Michael Adam <obnox@samba.org>
Andrew Bartlett [Thu, 15 Mar 2012 22:16:23 +0000 (09:16 +1100)]
s3-passdb: Change pdb_sid_to_id() to return struct unixid
This will make it easier to consistantly pass a struct unixid all the way up and
down the idmap stack, and allow ID_TYPE_BOTH to be handled correctly.
Andrew Bartlett
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Thu, 26 Apr 2012 13:31:28 +0000 (15:31 +0200)]
selftest: make the knownfail patterns for the driver_info_winreg more specific
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed May 2 11:23:26 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 2 May 2012 00:45:51 +0000 (10:45 +1000)]
s4-provision: Fix up --use-s3fs to create the directory for xattr.tdb
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed May 2 04:45:05 CEST 2012 on sn-devel-104
Andrew Bartlett [Wed, 2 May 2012 00:45:15 +0000 (10:45 +1000)]
s4-wintest: --use-s3fs in wintest
Andrew Bartlett [Wed, 2 May 2012 00:44:45 +0000 (10:44 +1000)]
s4-provision: Fix --use-s3fs to parse correctly
Andrew Bartlett [Tue, 1 May 2012 23:49:19 +0000 (09:49 +1000)]
testsuite/libsmbclient: Remove unused and expensive-to-link testsuite
This testsuite never got off the ground, and unlike the other
libsmbclient tests, it is not integrated into make test, has no driver
script we could integrate.
As it has been in this state for 10 years, and adding it to the compile
did not find any link-time issues (particularly in comparison to the
link-time cost for so many individual binaries), I am now removing them.
The libsmbclient examples are seperate to this, and remain in
examples/libsmbclient.
Andrew Bartlett
Andrew Bartlett [Tue, 1 May 2012 23:39:33 +0000 (09:39 +1000)]
selftest: 'store dos attributes = yes' is now set in fileserver.conf
As such, there is no need to set it or the permissions-based mappings here as well.
Andrew Bartlett
Andrew Bartlett [Tue, 1 May 2012 23:38:39 +0000 (09:38 +1000)]
s4-provision: set 'dcerpc endpoint servers' but not 'vfs objects'
The VFS objects are now set in the fileserver.conf, but this is only read by smbd, so
the provision-time smb.conf needs to turn off the extra Samba4 DCE/RPC services.
Andrew Bartlett
Andrew Bartlett [Tue, 1 May 2012 23:37:08 +0000 (09:37 +1000)]
file_server: set 'store dos attributes = yes'
This means we do not need the old permissions-based mappings.
Andrew Bartlett
Andrew Bartlett [Tue, 1 May 2012 10:11:04 +0000 (20:11 +1000)]
selftest: run more raw.samba3 against secshare simple file server
This allows these tests to run in an environment where they can pass,
as they fail when ACL support is turned on in smbd.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Wed May 2 02:51:27 CEST 2012 on sn-devel-104
Andrew Bartlett [Mon, 30 Apr 2012 05:32:08 +0000 (15:32 +1000)]
selftest: Run smbtorture tests being run against s3dc against plugin_s4_dc as well
Andrew Bartlett [Tue, 1 May 2012 06:06:39 +0000 (16:06 +1000)]
selftest: Do not start samba4 srvsvc in plugin_s4_dc mode
Andrew Bartlett [Mon, 30 Apr 2012 13:39:27 +0000 (23:39 +1000)]
selftest: add hooks required for printing to Samba4.pm
Andrew Bartlett [Tue, 1 May 2012 21:19:13 +0000 (07:19 +1000)]
selftest: mark samba3.raw.samba3checkfsp as flapping on plugin_s4_dc
This fails on my Fedora 16 workstation, but passes on sn-devel.
Andrew Bartlett
Andrew Bartlett [Tue, 1 May 2012 11:47:28 +0000 (21:47 +1000)]
selftest: mark samba3.raw.acls.inheritance(plugin_s4_dc) as flapping
This seems to succeed on sn-devel, but fails in a local make test on
my workstation.
Andrew Bartlett
Andrew Bartlett [Mon, 30 Apr 2012 13:39:10 +0000 (23:39 +1000)]
selftest: add knownfail entries for plugin_s4_dc tests
Andrew Bartlett [Mon, 30 Apr 2012 10:55:30 +0000 (20:55 +1000)]
selftest: change knownfail to cope with running plugin_s4_dc as well
Andrew Bartlett [Tue, 1 May 2012 06:06:25 +0000 (16:06 +1000)]
file_server: use embedded srvsvc
Andrew Bartlett [Mon, 30 Apr 2012 06:03:33 +0000 (16:03 +1000)]
file_server: Use the embedded winreg server
Andrew Bartlett [Mon, 30 Apr 2012 05:22:04 +0000 (15:22 +1000)]
file_server: use embedded ntsvcs server
Andrew Bartlett [Mon, 30 Apr 2012 05:19:43 +0000 (15:19 +1000)]
file_server: use embedded eventlog server
Andrew Bartlett [Mon, 30 Apr 2012 05:13:49 +0000 (15:13 +1000)]
file_server: forward dssetup, but use embedded svcctl for s3fs
Andrew Bartlett [Mon, 30 Apr 2012 05:08:38 +0000 (15:08 +1000)]
selftest: Use same pattern for path to share as Samba3.pm
This helps as we declare tests that were previously targetted at Samba3 only.
Andrew Bartlett
Andrew Bartlett [Mon, 30 Apr 2012 05:17:54 +0000 (15:17 +1000)]
selftest: Add hideunread share to plugin_s4_dc
Andrew Bartlett [Mon, 30 Apr 2012 05:16:15 +0000 (15:16 +1000)]
selftest: run plugin_s4_dc with 'acl_xattr xattr_tdb streams_depot' VFS modules
Andrew Bartlett [Thu, 26 Apr 2012 05:20:02 +0000 (15:20 +1000)]
selftest: prepare to run smbtorture tests against plugin_s4_dc
Andrew Bartlett [Wed, 18 Apr 2012 06:05:22 +0000 (16:05 +1000)]
selftest: attempt to test samba3hide in a different environment
This should ensure that the samba3hide test is still run and passes,
in a non-ACLed environment.
Andrew Bartlett
Andrew Bartlett [Tue, 17 Apr 2012 01:56:23 +0000 (11:56 +1000)]
selftest: Enable ACL testing against the s3dc environment
Previously, ACL tests were skipped and the correct modules for ACL
testing were not loaded.
The addition of a knownfail entry for raw.samba3* tests is due to an
inconsitancy between the behaviour with and without ACL modules loaded
- posix chown calls appear to be ignored in this mode.
Andrew Bartlett
Andrew Bartlett [Tue, 1 May 2012 07:13:34 +0000 (17:13 +1000)]
s3-smbd: Use security_session_user_level() rather than nt_token_check_sid()
This allows the unix.whoami test to pass when configured as part of the AD DC.
The struct auth_session_info is slightly different in the AD DC configuration
when using auth_samba4. In particular, there is a distinction between Guest
and Anonymous logins.
Andrew Bartlett
Christian Ambach [Tue, 1 May 2012 19:21:40 +0000 (21:21 +0200)]
s3:torture fix flakey testcase
don't put database into /tmp, use lp_private_dir() to put
it into the selftest prefix
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Wed May 2 00:57:05 CEST 2012 on sn-devel-104
Christian Ambach [Mon, 30 Apr 2012 15:02:46 +0000 (17:02 +0200)]
s3:selftest run LOCAL-IDMAP-TDB-COMMON in make test
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue May 1 11:07:08 CEST 2012 on sn-devel-104
Christian Ambach [Wed, 22 Feb 2012 14:44:27 +0000 (15:44 +0100)]
s3:torture: add idmap_tdb_common test code
Christian Ambach [Mon, 20 Feb 2012 11:13:56 +0000 (12:13 +0100)]
s3:winbindd/idmap_tdb: use idmap_tdb_common code
Christian Ambach [Sun, 26 Feb 2012 16:49:23 +0000 (17:49 +0100)]
s3:winbindd/idmap_tdb2: fix logic error in set_mapping_action
fix an endless loop
Christian Ambach [Fri, 17 Feb 2012 16:34:03 +0000 (17:34 +0100)]
s3:winbindd/idmap_tdb2: use idmap_tdb_common code
Christian Ambach [Wed, 25 Jan 2012 18:06:16 +0000 (19:06 +0100)]
s3:winbindd/autorid use idmap_tdb_common code in autorid
- use common logic for the allocation pool
- add a idmap_tdb style 1on1 mapping for non-domain SIDs
like Everyone (S-1-1-0)
Christian Ambach [Mon, 16 Jan 2012 16:21:38 +0000 (17:21 +0100)]
s3:winbindd add idmap_tdb_common file to store common code of TDB idmap backends
Christian Ambach [Tue, 17 Jan 2012 12:59:56 +0000 (13:59 +0100)]
s3:util add sid_check_is_wellknown_builtin()
Andrew Bartlett [Tue, 1 May 2012 04:42:33 +0000 (14:42 +1000)]
move VERSION to alpha21
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue May 1 08:16:38 CEST 2012 on sn-devel-104
Andrew Bartlett [Tue, 1 May 2012 04:40:48 +0000 (14:40 +1000)]
prepare WHATSNEW for alpha20 and mark as release
Amitay Isaacs [Thu, 19 Apr 2012 23:39:53 +0000 (09:39 +1000)]
s4-upgradedns: Update serverdn with only the attributes that have changed
This fixes the issue of ldb 'Operations Error' when trying to modify
hasPartialReplicaNCs attribute.
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Tue May 1 05:28:04 CEST 2012 on sn-devel-104
Jeremy Allison [Tue, 17 Apr 2012 19:30:15 +0000 (12:30 -0700)]
Fix bug #8873 - self granting privileges in security=ads.
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue May 1 01:04:46 CEST 2012 on sn-devel-104
Jeremy Allison [Mon, 30 Apr 2012 18:05:51 +0000 (11:05 -0700)]
Fix the loop unrolling inside resolve_ads(). If we don't get
an IP list don't use interpret_string_addr(), as this only
returns one address, use interpret_string_addr_internal()
instead.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Apr 30 23:21:16 CEST 2012 on sn-devel-104
Jeremy Allison [Fri, 27 Apr 2012 23:25:58 +0000 (16:25 -0700)]
Protect all of the name resolution methods from returning null addrs. Ensure all returns go through remove_duplicate_addrs2().
Jeremy Allison [Fri, 27 Apr 2012 23:07:20 +0000 (16:07 -0700)]
Fix convert_ss2service() to filter out zero addresses.
Jeremy Allison [Fri, 27 Apr 2012 23:02:15 +0000 (16:02 -0700)]
Fix remove_duplicate_addrs2 to do exactly what it says. Previously it could leave zero addresses in the list.
Matthias Dieter Wallnöfer [Sat, 21 Apr 2012 15:32:48 +0000 (17:32 +0200)]
s4:samldb LDB module - homogenize LDB search attributes arrays
First they do not need to be "static" any longer since we have abandoned
asynchronous result handling (where global variables have been important).
In addition add some "const" in order to protect us from unwanted writes.
Reviewed-by: Andrew Bartlett
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Apr 30 16:46:20 CEST 2012 on sn-devel-104
Andrew Bartlett [Mon, 30 Apr 2012 10:29:56 +0000 (20:29 +1000)]
s4-libnet: Add mem_ctx to libnet_rpc_groupdel calls (bug #8889)
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr 30 14:41:36 CEST 2012 on sn-devel-104
Andrew Bartlett [Mon, 30 Apr 2012 10:27:33 +0000 (20:27 +1000)]
s4-libnet: Add mem_ctx to libnet_rpc_groupadd calls (bug #8889)
Andrew Bartlett [Mon, 30 Apr 2012 10:25:55 +0000 (20:25 +1000)]
s4-libnet: Add mem_ctx to libnet_rpc_usermod calls (bug #8889)
Andrew Bartlett [Mon, 30 Apr 2012 10:23:07 +0000 (20:23 +1000)]
s4-libnet: Add mem_ctx to libnet_rpc_userdel calls (bug #8889)
Andrew Bartlett [Mon, 30 Apr 2012 10:14:42 +0000 (20:14 +1000)]
s4-libnet: Add mem_ctx to libnet_rpc_useradd calls (bug #8889)
Andrew Bartlett [Mon, 30 Apr 2012 10:09:58 +0000 (20:09 +1000)]
s4-libnet: Add mem_ctx to libnet_rpc_groupinfo calls (bug #8889)
Andrew Bartlett [Mon, 30 Apr 2012 10:02:42 +0000 (20:02 +1000)]
s4-libnet: Add mem_ctx to libnet_DomainClose calls (bug #8889)
Andrew Bartlett [Mon, 30 Apr 2012 09:57:45 +0000 (19:57 +1000)]
s4-libnet: Add mem_ctx to libnet_DomainOpen calls (bug #8889)
Andrew Bartlett [Mon, 30 Apr 2012 09:35:25 +0000 (19:35 +1000)]
s4-libnet: Add mem_ctx to libnet_Lookup calls (bug #8889)
Christof Schmitt [Tue, 24 Apr 2012 21:33:46 +0000 (14:33 -0700)]
net: Let get*sid return error from passdb init
When initialize_password_db returns an error this means that the SID
stored in the backend cannot be read. Return this error directly
instead of creating a random SID through get_global_sam_sid.
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Mon Apr 30 13:07:20 CEST 2012 on sn-devel-104
Christof Schmitt [Tue, 24 Apr 2012 21:42:28 +0000 (14:42 -0700)]
passdb: Do not panic in initialize_password_db
A call to initialize_password_db leads to smb_panic in case the backend
returns an error. All callers to initialize_password_db check the return
value, so this code path should return the status instead of calling
smb_panic.
Move the call to smb_panic from pdb_get_methods_reload pdb_get_methods
to get it out of the initialize code path. This allows printing the
proper error message for 'net getlocalsid' which is much nicer than
printing the panic stack trace.
Andrew Bartlett [Wed, 25 Apr 2012 07:40:35 +0000 (17:40 +1000)]
s3-auth_samba4: use new_server_id_task() to allocate server id values
This is rather than just picking a random number out of the air.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr 30 11:29:34 CEST 2012 on sn-devel-104
Andrew Bartlett [Thu, 21 Jul 2011 06:29:38 +0000 (16:29 +1000)]
s3-lib Add a way to allocate the task_id value in server_id
This safely allocates the task_id so that when we have multiple event
contexts, they can each have their own messaging context, particularly
for the imessaging subsystem under source4.
Andrew Bartlett
Andrew Bartlett [Mon, 30 Apr 2012 05:44:01 +0000 (15:44 +1000)]
s4-messaging: Fill in the whole server_id in all use cases
This started per https://bugzilla.samba.org/show_bug.cgi?id=8872#c4
and avoids any possible collision with a different process.
We also need to ensure that across a Samba installation on a single
node that id.vnn is the same. Samba4 previously used 0, while Samba3
used NONCLUSTER_VNN. When a message is sent between these 'different'
nodes, the error NT_STATUS_INVALID_DEVICE_REQUEST is raised.
Andrew Bartlett
Andrew Bartlett [Mon, 30 Apr 2012 04:57:41 +0000 (14:57 +1000)]
s4-torture: convert samba3misc tests to use torture_failure and torture_assert
This helps us when these tests fail, as subunit-formatted failures can
be declared as knownfail entries, and show up correctly in the make
test output.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr 30 08:34:52 CEST 2012 on sn-devel-104
Andrew Bartlett [Mon, 30 Apr 2012 04:15:12 +0000 (14:15 +1000)]
s4-torture: move samba3 tests to use torture helper functions
Andrew Bartlett [Mon, 30 Apr 2012 04:05:19 +0000 (14:05 +1000)]
s4-torture: Move various samba3 tests to the torture_suite_add_1smb_test wrapper
Matthias Dieter Wallnöfer [Sat, 21 Apr 2012 16:16:43 +0000 (18:16 +0200)]
s4:samldb LDB module - implement "fSMORoleOwner" attribute protection
This is a very essential attribute since it references to various domain
master roles (PDC emulator, schema...) depending on which entry it has
been set. Incautious modifications can cause severe problems.
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Mon Apr 30 02:04:24 CEST 2012 on sn-devel-104