Fix Coverity ID 436

(This used to be commit 9e0ee1ad4fe0f0e7dec0b6824ef234147d845b8d)

diff --git a/source3/lib/popt_common.c b/source3/lib/popt_common.c
index 7f7d23fa00b9daff311984ecd93c46f7714e1ee1..8f0f7c62bb9e6ace3982774dfd07533ea99ae663 100644 (file)
--- a/source3/lib/popt_common.c
+++ b/source3/lib/popt_common.c
@@ -327,6 +327,11 @@ static void get_password_file(void)
                close_it = True;
        }
 
+       if (fd < 0) {
+               fprintf(stderr, "fd = %d, < 0\n", fd);
+               exit(1);
+       }
+
        for(p = pass, *p = '\0'; /* ensure that pass is null-terminated */
                p && p - pass < sizeof(pass);) {
                switch (read(fd, p, 1)) {