vfs_catia: Fix a potential memleak
authorVolker Lendecke <vl@samba.org>
Mon, 16 Oct 2017 15:43:09 +0000 (17:43 +0200)
committerRalph Boehme <slow@samba.org>
Tue, 17 Oct 2017 16:53:48 +0000 (18:53 +0200)
Together with the previous commit this fixes a memleak (twice) that
happens when vfs_catia is loaded with no mappings defined.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13090

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Oct 17 18:53:48 CEST 2017 on sn-devel-144

source3/modules/vfs_catia.c

index 878cd5ad05ce432dfc04bf60b42d91e0bd44a7dc..4088affc08974578ad2238c1d3482ec6f08ffa1a 100644 (file)
@@ -141,7 +141,7 @@ static NTSTATUS catia_string_replace_allocate(connection_struct *conn,
 
        if (!init_mappings(conn, &selected)) {
                /* No mappings found. Just use the old name */
-               *mapped_name = talloc_strdup(NULL, name_in);
+               *mapped_name = talloc_strdup(talloc_tos(), name_in);
                if (!*mapped_name) {
                        errno = ENOMEM;
                        return NT_STATUS_NO_MEMORY;