s3/utils: Detect (and report) failure to parse sddl

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source3/utils/smbcacls.c b/source3/utils/smbcacls.c
index 0575a254c29bdddead09f340ee02772bdbc254ab..0316868fb3df39bf440f2808db257d7aa984b3aa 100644 (file)
--- a/source3/utils/smbcacls.c
+++ b/source3/utils/smbcacls.c
@@ -2108,6 +2108,11 @@ static int cacl_restore(struct cli_state *cli,
                        }
                } else {
                        entries[index].sd = sddl_decode(lines, lines[i], sid);
+                       if(entries[index].sd == NULL) {
+                               DBG_ERR("could not decode '%s'\n", lines[i]);
+                               result = EXIT_FAILED;
+                               goto out;
+                       }
                        entries[index].sd->type |=
                            SEC_DESC_DACL_AUTO_INHERIT_REQ;
                        entries[index].sd->type |= SEC_DESC_SACL_AUTO_INHERITED;