ldb-samba: ldif_read_objectSid avoids VLA
[samba.git] / source3 / lib / tldap.c
index 9a418dddac82169752e12cdbbe4b7bc07044e4e2..ac95272fe0636a9796a406f78d8244db85b2baaa 100644 (file)
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-#include "includes.h"
+#include "replace.h"
 #include "tldap.h"
+#include "system/network.h"
+#include "system/locale.h"
+#include "lib/util/talloc_stack.h"
+#include "lib/util/samba_util.h"
+#include "lib/util_tsock.h"
 #include "../lib/util/asn1.h"
 #include "../lib/tsocket/tsocket.h"
 #include "../lib/util/tevent_unix.h"
+#include "../libcli/util/ntstatus.h"
+#include "../source4/lib/tls/tls.h"
 
-static int tldap_simple_recv(struct tevent_req *req);
+static TLDAPRC tldap_simple_recv(struct tevent_req *req);
+static bool tldap_msg_set_pending(struct tevent_req *req);
 
-bool tevent_req_is_ldap_error(struct tevent_req *req, int *perr)
+#define TEVENT_TLDAP_RC_MAGIC (0x87bcd26e)
+
+bool tevent_req_ldap_error(struct tevent_req *req, TLDAPRC rc)
+{
+       uint64_t err;
+
+       if (TLDAP_RC_IS_SUCCESS(rc)) {
+               return false;
+       }
+
+       err = TEVENT_TLDAP_RC_MAGIC;
+       err <<= 32;
+       err |= TLDAP_RC_V(rc);
+
+       return tevent_req_error(req, err);
+}
+
+bool tevent_req_is_ldap_error(struct tevent_req *req, TLDAPRC *perr)
 {
        enum tevent_req_state state;
        uint64_t err;
@@ -41,7 +66,10 @@ bool tevent_req_is_ldap_error(struct tevent_req *req, int *perr)
                *perr = TLDAP_NO_MEMORY;
                break;
        case TEVENT_REQ_USER_ERROR:
-               *perr = err;
+               if ((err >> 32) != TEVENT_TLDAP_RC_MAGIC) {
+                       abort();
+               }
+               *perr = TLDAP_RC(err & 0xffffffff);
                break;
        default:
                *perr = TLDAP_OPERATIONS_ERROR;
@@ -57,11 +85,15 @@ struct tldap_ctx_attribute {
 
 struct tldap_context {
        int ld_version;
-       struct tstream_context *conn;
-       bool server_down;
+       struct tstream_context *plain;
+       bool starttls_needed;
+       struct tstream_context *tls;
+       struct tstream_context *gensec;
+       struct tstream_context *active;
        int msgid;
        struct tevent_queue *outgoing;
        struct tevent_req **pending;
+       struct tevent_req *read_req;
 
        /* For the sync wrappers we need something like get_last_error... */
        struct tldap_message *last_msg;
@@ -85,10 +117,15 @@ struct tldap_message {
        struct tldap_attribute *attribs;
 
        /* Error data sent by the server */
-       int lderr;
+       TLDAPRC lderr;
        char *res_matcheddn;
        char *res_diagnosticmessage;
        char *res_referral;
+       DATA_BLOB res_serverSaslCreds;
+       struct {
+               char *oid;
+               DATA_BLOB blob;
+       } res_extended;
        struct tldap_control *res_sctrls;
 
        /* Controls sent by the server */
@@ -106,6 +143,11 @@ void tldap_set_debug(struct tldap_context *ld,
        ld->log_private = log_private;
 }
 
+static void tldap_debug(
+       struct tldap_context *ld,
+       enum tldap_debug_level level,
+       const char *fmt, ...) PRINTF_ATTRIBUTE(3,4);
+
 static void tldap_debug(struct tldap_context *ld,
                         enum tldap_debug_level level,
                         const char *fmt, ...)
@@ -127,7 +169,7 @@ static int tldap_next_msgid(struct tldap_context *ld)
        int result;
 
        result = ld->msgid++;
-       if (ld->msgid == 2147483647) {
+       if (ld->msgid == INT_MAX) {
                ld->msgid = 1;
        }
        return result;
@@ -142,11 +184,12 @@ struct tldap_context *tldap_context_create(TALLOC_CTX *mem_ctx, int fd)
        if (ctx == NULL) {
                return NULL;
        }
-       ret = tstream_bsd_existing_socket(ctx, fd, &ctx->conn);
+       ret = tstream_bsd_existing_socket(ctx, fd, &ctx->plain);
        if (ret == -1) {
                TALLOC_FREE(ctx);
                return NULL;
        }
+       ctx->active = ctx->plain;
        ctx->msgid = 1;
        ctx->ld_version = 3;
        ctx->outgoing = tevent_queue_create(ctx, "tldap_outgoing");
@@ -159,10 +202,93 @@ struct tldap_context *tldap_context_create(TALLOC_CTX *mem_ctx, int fd)
 
 bool tldap_connection_ok(struct tldap_context *ld)
 {
+       int ret;
+
        if (ld == NULL) {
                return false;
        }
-       return !ld->server_down;
+
+       if (ld->active == NULL) {
+               return false;
+       }
+
+       ret = tstream_pending_bytes(ld->active);
+       if (ret == -1) {
+               return false;
+       }
+
+       return true;
+}
+
+static size_t tldap_pending_reqs(struct tldap_context *ld)
+{
+       return talloc_array_length(ld->pending);
+}
+
+struct tstream_context *tldap_get_plain_tstream(struct tldap_context *ld)
+{
+       return ld->plain;
+}
+
+void tldap_set_starttls_needed(struct tldap_context *ld, bool needed)
+{
+       if (ld == NULL) {
+               return;
+       }
+
+       ld->starttls_needed = needed;
+}
+
+bool tldap_get_starttls_needed(struct tldap_context *ld)
+{
+       if (ld == NULL) {
+               return false;
+       }
+
+       return ld->starttls_needed;
+}
+
+bool tldap_has_tls_tstream(struct tldap_context *ld)
+{
+       return ld->tls != NULL && ld->active == ld->tls;
+}
+
+const DATA_BLOB *tldap_tls_channel_bindings(struct tldap_context *ld)
+{
+       return tstream_tls_channel_bindings(ld->tls);
+}
+
+void tldap_set_tls_tstream(struct tldap_context *ld,
+                          struct tstream_context **stream)
+{
+       TALLOC_FREE(ld->tls);
+       if (stream != NULL) {
+               ld->tls = talloc_move(ld, stream);
+       }
+       if (ld->tls != NULL) {
+               ld->active = ld->tls;
+       } else {
+               ld->active = ld->plain;
+       }
+}
+
+bool tldap_has_gensec_tstream(struct tldap_context *ld)
+{
+       return ld->gensec != NULL && ld->active == ld->gensec;
+}
+
+void tldap_set_gensec_tstream(struct tldap_context *ld,
+                             struct tstream_context **stream)
+{
+       TALLOC_FREE(ld->gensec);
+       if (stream != NULL) {
+               ld->gensec = talloc_move(ld, stream);
+       }
+       if (ld->gensec != NULL) {
+               ld->active = ld->gensec;
+       } else {
+               ld->active = ld->plain;
+       }
 }
 
 static struct tldap_ctx_attribute *tldap_context_findattr(
@@ -238,7 +364,6 @@ void *tldap_context_getattr(struct tldap_context *ld, const char *name)
 
 struct read_ldap_state {
        uint8_t *buf;
-       bool done;
 };
 
 static ssize_t read_ldap_more(uint8_t *buf, size_t buflen, void *private_data);
@@ -255,9 +380,8 @@ static struct tevent_req *read_ldap_send(TALLOC_CTX *mem_ctx,
        if (req == NULL) {
                return NULL;
        }
-       state->done = false;
 
-       subreq = tstream_read_packet_send(state, ev, conn, 2, read_ldap_more,
+       subreq = tstream_read_packet_send(state, ev, conn, 7, read_ldap_more,
                                          state);
        if (tevent_req_nomem(subreq, req)) {
                return tevent_req_post(req, ev);
@@ -268,48 +392,30 @@ static struct tevent_req *read_ldap_send(TALLOC_CTX *mem_ctx,
 
 static ssize_t read_ldap_more(uint8_t *buf, size_t buflen, void *private_data)
 {
-       struct read_ldap_state *state = talloc_get_type_abort(
-               private_data, struct read_ldap_state);
-       size_t len;
-       int i, lensize;
-
-       if (state->done) {
-               /* We've been here, we're done */
-               return 0;
-       }
+       const DATA_BLOB blob = data_blob_const(buf, buflen);
+       size_t pdu_len = 0;
+       int ret;
 
-       /*
-        * From ldap.h: LDAP_TAG_MESSAGE is 0x30
-        */
-       if (buf[0] != 0x30) {
+       if (buflen < 7) {
+               /*
+                * We need at least 6 bytes to workout the length
+                * of the pdu.
+                *
+                * And we have asked for 7 because the that's
+                * the size of the smallest possible LDAP pdu.
+                */
                return -1;
        }
 
-       len = buf[1];
-       if ((len & 0x80) == 0) {
-               state->done = true;
-               return len;
-       }
-
-       lensize = (len & 0x7f);
-       len = 0;
-
-       if (buflen == 2) {
-               /* Please get us the full length */
-               return lensize;
-       }
-       if (buflen > 2 + lensize) {
-               state->done = true;
+       ret = asn1_peek_full_tag(blob, ASN1_SEQUENCE(0), &pdu_len);
+       if (ret == 0) {
                return 0;
        }
-       if (buflen != 2 + lensize) {
-               return -1;
+       if (ret == EAGAIN) {
+               return pdu_len - buflen;
        }
 
-       for (i=0; i<lensize; i++) {
-               len = (len << 8) | buf[2+i];
-       }
-       return len;
+       return -1;
 }
 
 static void read_ldap_done(struct tevent_req *subreq)
@@ -382,6 +488,46 @@ static bool tldap_push_controls(struct asn1_data *data,
        return asn1_pop_tag(data); /* ASN1_CONTEXT(0) */
 }
 
+#define tldap_context_disconnect(ld, status) \
+       _tldap_context_disconnect(ld, status, __location__)
+
+static void _tldap_context_disconnect(struct tldap_context *ld,
+                                     TLDAPRC status,
+                                     const char *location)
+{
+       if (ld->active == NULL) {
+               /*
+                * We don't need to tldap_debug() on
+                * a potential 2nd run.
+                *
+                * The rest of the function would just
+                * be a noop for the 2nd run anyway.
+                */
+               return;
+       }
+
+       tldap_debug(ld, TLDAP_DEBUG_WARNING,
+                   "tldap_context_disconnect: %s at %s\n",
+                   tldap_rc2string(status),
+                   location);
+       tevent_queue_stop(ld->outgoing);
+       TALLOC_FREE(ld->read_req);
+       ld->active = NULL;
+       TALLOC_FREE(ld->gensec);
+       TALLOC_FREE(ld->tls);
+       TALLOC_FREE(ld->plain);
+
+       while (talloc_array_length(ld->pending) > 0) {
+               struct tevent_req *req = NULL;
+               struct tldap_msg_state *state = NULL;
+
+               req = ld->pending[0];
+               state = tevent_req_data(req, struct tldap_msg_state);
+               tevent_req_defer_callback(req, state->ev);
+               tevent_req_ldap_error(req, status);
+       }
+}
+
 static void tldap_msg_sent(struct tevent_req *subreq);
 static void tldap_msg_received(struct tevent_req *subreq);
 
@@ -395,6 +541,7 @@ static struct tevent_req *tldap_msg_send(TALLOC_CTX *mem_ctx,
        struct tevent_req *req, *subreq;
        struct tldap_msg_state *state;
        DATA_BLOB blob;
+       bool ok;
 
        tldap_debug(ld, TLDAP_DEBUG_TRACE, "tldap_msg_send: sending msg %d\n",
                    id);
@@ -407,31 +554,37 @@ static struct tevent_req *tldap_msg_send(TALLOC_CTX *mem_ctx,
        state->ev = ev;
        state->id = id;
 
-       if (state->ld->server_down) {
-               tevent_req_error(req, TLDAP_SERVER_DOWN);
+       ok = tldap_connection_ok(ld);
+       if (!ok) {
+               tevent_req_ldap_error(req, TLDAP_SERVER_DOWN);
                return tevent_req_post(req, ev);
        }
 
        if (!tldap_push_controls(data, sctrls, num_sctrls)) {
-               tevent_req_error(req, TLDAP_ENCODING_ERROR);
+               tevent_req_ldap_error(req, TLDAP_ENCODING_ERROR);
                return tevent_req_post(req, ev);
        }
 
 
        if (!asn1_pop_tag(data)) {
-               tevent_req_error(req, TLDAP_ENCODING_ERROR);
+               tevent_req_ldap_error(req, TLDAP_ENCODING_ERROR);
                return tevent_req_post(req, ev);
        }
 
        if (!asn1_blob(data, &blob)) {
-               tevent_req_error(req, TLDAP_ENCODING_ERROR);
+               tevent_req_ldap_error(req, TLDAP_ENCODING_ERROR);
                return tevent_req_post(req, ev);
        }
 
+       if (!tldap_msg_set_pending(req)) {
+               tevent_req_oom(req);
+               return tevent_req_post(req, ev);;
+       }
+
        state->iov.iov_base = (void *)blob.data;
        state->iov.iov_len = blob.length;
 
-       subreq = tstream_writev_queue_send(state, ev, ld->conn, ld->outgoing,
+       subreq = tstream_writev_queue_send(state, ev, ld->active, ld->outgoing,
                                           &state->iov, 1);
        if (tevent_req_nomem(subreq, req)) {
                return tevent_req_post(req, ev);
@@ -445,16 +598,11 @@ static void tldap_msg_unset_pending(struct tevent_req *req)
        struct tldap_msg_state *state = tevent_req_data(
                req, struct tldap_msg_state);
        struct tldap_context *ld = state->ld;
-       int num_pending = talloc_array_length(ld->pending);
+       int num_pending = tldap_pending_reqs(ld);
        int i;
 
        tevent_req_set_cleanup_fn(req, NULL);
 
-       if (num_pending == 1) {
-               TALLOC_FREE(ld->pending);
-               return;
-       }
-
        for (i=0; i<num_pending; i++) {
                if (req == ld->pending[i]) {
                        break;
@@ -469,6 +617,11 @@ static void tldap_msg_unset_pending(struct tevent_req *req)
                return;
        }
 
+       if (num_pending == 1) {
+               TALLOC_FREE(ld->pending);
+               return;
+       }
+
        /*
         * Remove ourselves from the cli->pending array
         */
@@ -487,14 +640,7 @@ static void tldap_msg_unset_pending(struct tevent_req *req)
 static void tldap_msg_cleanup(struct tevent_req *req,
                              enum tevent_req_state req_state)
 {
-       switch (req_state) {
-       case TEVENT_REQ_USER_ERROR:
-       case TEVENT_REQ_RECEIVED:
-               tldap_msg_unset_pending(req);
-               return;
-       default:
-               return;
-       }
+       tldap_msg_unset_pending(req);
 }
 
 static bool tldap_msg_set_pending(struct tevent_req *req)
@@ -504,10 +650,9 @@ static bool tldap_msg_set_pending(struct tevent_req *req)
        struct tldap_context *ld;
        struct tevent_req **pending;
        int num_pending;
-       struct tevent_req *subreq;
 
        ld = state->ld;
-       num_pending = talloc_array_length(ld->pending);
+       num_pending = tldap_pending_reqs(ld);
 
        pending = talloc_realloc(ld, ld->pending, struct tevent_req *,
                                 num_pending+1);
@@ -518,7 +663,7 @@ static bool tldap_msg_set_pending(struct tevent_req *req)
        ld->pending = pending;
        tevent_req_set_cleanup_fn(req, tldap_msg_cleanup);
 
-       if (num_pending > 0) {
+       if (ld->read_req != NULL) {
                return true;
        }
 
@@ -526,12 +671,12 @@ static bool tldap_msg_set_pending(struct tevent_req *req)
         * We're the first one, add the read_ldap request that waits for the
         * answer from the server
         */
-       subreq = read_ldap_send(ld->pending, state->ev, ld->conn);
-       if (subreq == NULL) {
+       ld->read_req = read_ldap_send(ld->pending, state->ev, ld->active);
+       if (ld->read_req == NULL) {
                tldap_msg_unset_pending(req);
                return false;
        }
-       tevent_req_set_callback(subreq, tldap_msg_received, ld);
+       tevent_req_set_callback(ld->read_req, tldap_msg_received, ld);
        return true;
 }
 
@@ -547,13 +692,7 @@ static void tldap_msg_sent(struct tevent_req *subreq)
        nwritten = tstream_writev_queue_recv(subreq, &err);
        TALLOC_FREE(subreq);
        if (nwritten == -1) {
-               state->ld->server_down = true;
-               tevent_req_error(req, TLDAP_SERVER_DOWN);
-               return;
-       }
-
-       if (!tldap_msg_set_pending(req)) {
-               tevent_req_oom(req);
+               tldap_context_disconnect(state->ld, TLDAP_SERVER_DOWN);
                return;
        }
 }
@@ -576,20 +715,27 @@ static void tldap_msg_received(struct tevent_req *subreq)
        uint8_t *inbuf;
        ssize_t received;
        size_t num_pending;
-       int i, err, status;
+       size_t i;
+       int err;
+       TLDAPRC status = TLDAP_PROTOCOL_ERROR;
        int id;
        uint8_t type;
        bool ok;
 
        received = read_ldap_recv(subreq, talloc_tos(), &inbuf, &err);
        TALLOC_FREE(subreq);
+       ld->read_req = NULL;
        if (received == -1) {
                status = TLDAP_SERVER_DOWN;
                goto fail;
        }
 
-       data = asn1_init(talloc_tos());
+       data = asn1_init(talloc_tos(), ASN1_MAX_TREE_DEPTH);
        if (data == NULL) {
+               /*
+                * We have to disconnect all, we can't tell which of
+                * the requests this reply is for.
+                */
                status = TLDAP_NO_MEMORY;
                goto fail;
        }
@@ -608,6 +754,17 @@ static void tldap_msg_received(struct tevent_req *subreq)
        tldap_debug(ld, TLDAP_DEBUG_TRACE, "tldap_msg_received: got msg %d "
                    "type %d\n", id, (int)type);
 
+       if (id == 0) {
+               tldap_debug(
+                       ld,
+                       TLDAP_DEBUG_WARNING,
+                       "tldap_msg_received: got msgid 0 of "
+                       "type %"PRIu8", disconnecting\n",
+                       type);
+               tldap_context_disconnect(ld, TLDAP_SERVER_DOWN);
+               return;
+       }
+
        num_pending = talloc_array_length(ld->pending);
 
        for (i=0; i<num_pending; i++) {
@@ -633,47 +790,34 @@ static void tldap_msg_received(struct tevent_req *subreq)
        tldap_msg_unset_pending(req);
        num_pending = talloc_array_length(ld->pending);
 
+       tevent_req_defer_callback(req, state->ev);
        tevent_req_done(req);
 
  done:
        if (num_pending == 0) {
                return;
        }
-       if (talloc_array_length(ld->pending) > num_pending) {
-               /*
-                * The callback functions called from tevent_req_done() above
-                * have put something on the pending queue. We don't have to
-                * trigger the read_ldap_send(), tldap_msg_set_pending() has
-                * done it for us already.
-                */
-               return;
-       }
 
        state = tevent_req_data(ld->pending[0], struct tldap_msg_state);
-       subreq = read_ldap_send(ld->pending, state->ev, ld->conn);
-       if (subreq == NULL) {
+       ld->read_req = read_ldap_send(ld->pending, state->ev, ld->active);
+       if (ld->read_req == NULL) {
                status = TLDAP_NO_MEMORY;
                goto fail;
        }
-       tevent_req_set_callback(subreq, tldap_msg_received, ld);
+       tevent_req_set_callback(ld->read_req, tldap_msg_received, ld);
        return;
 
  fail:
-       while (talloc_array_length(ld->pending) > 0) {
-               req = ld->pending[0];
-               state = tevent_req_data(req, struct tldap_msg_state);
-               tevent_req_defer_callback(req, state->ev);
-               tevent_req_error(req, status);
-       }
+       tldap_context_disconnect(ld, status);
 }
 
-static int tldap_msg_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
-                         struct tldap_message **pmsg)
+static TLDAPRC tldap_msg_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
+                             struct tldap_message **pmsg)
 {
        struct tldap_msg_state *state = tevent_req_data(
                req, struct tldap_msg_state);
        struct tldap_message *msg;
-       int err;
+       TLDAPRC err;
        uint8_t msgtype;
 
        if (tevent_req_is_ldap_error(req, &err)) {
@@ -719,7 +863,7 @@ static struct tevent_req *tldap_req_create(TALLOC_CTX *mem_ctx,
        if (req == NULL) {
                return NULL;
        }
-       state->out = asn1_init(state);
+       state->out = asn1_init(state, ASN1_MAX_TREE_DEPTH);
        if (state->out == NULL) {
                goto err;
        }
@@ -785,9 +929,14 @@ static bool tldap_decode_response(struct tldap_req_state *state)
 {
        struct asn1_data *data = state->result->data;
        struct tldap_message *msg = state->result;
+       int rc;
        bool ok = true;
 
-       ok &= asn1_read_enumerated(data, &msg->lderr);
+       ok &= asn1_read_enumerated(data, &rc);
+       if (ok) {
+               msg->lderr = TLDAP_RC(rc);
+       }
+
        ok &= asn1_read_OctetString_talloc(msg, data, &msg->res_matcheddn);
        ok &= asn1_read_OctetString_talloc(msg, data,
                                           &msg->res_diagnosticmessage);
@@ -860,7 +1009,7 @@ struct tevent_req *tldap_sasl_bind_send(TALLOC_CTX *mem_ctx,
 
   err:
 
-       tevent_req_error(req, TLDAP_ENCODING_ERROR);
+       tevent_req_ldap_error(req, TLDAP_ENCODING_ERROR);
        return tevent_req_post(req, ev);
 }
 
@@ -870,76 +1019,124 @@ static void tldap_sasl_bind_done(struct tevent_req *subreq)
                subreq, struct tevent_req);
        struct tldap_req_state *state = tevent_req_data(
                req, struct tldap_req_state);
-       int err;
+       TLDAPRC rc;
+       bool ok;
 
-       err = tldap_msg_recv(subreq, state, &state->result);
+       rc = tldap_msg_recv(subreq, state, &state->result);
        TALLOC_FREE(subreq);
-       if (err != TLDAP_SUCCESS) {
-               tevent_req_error(req, err);
+       if (tevent_req_ldap_error(req, rc)) {
                return;
        }
        if (state->result->type != TLDAP_RES_BIND) {
-               tevent_req_error(req, TLDAP_PROTOCOL_ERROR);
+               tevent_req_ldap_error(req, TLDAP_PROTOCOL_ERROR);
                return;
        }
-       if (!asn1_start_tag(state->result->data, state->result->type) ||
-           !tldap_decode_response(state) ||
-           !asn1_end_tag(state->result->data)) {
-               tevent_req_error(req, TLDAP_DECODING_ERROR);
-               return;
+
+       ok = asn1_start_tag(state->result->data, TLDAP_RES_BIND);
+       ok &= tldap_decode_response(state);
+
+       if (asn1_peek_tag(state->result->data, ASN1_CONTEXT_SIMPLE(7))) {
+               int len;
+
+               ok &= asn1_start_tag(state->result->data,
+                                    ASN1_CONTEXT_SIMPLE(7));
+               if (!ok) {
+                       goto decode_error;
+               }
+
+               len = asn1_tag_remaining(state->result->data);
+               if (len == -1) {
+                       goto decode_error;
+               }
+
+               state->result->res_serverSaslCreds =
+                       data_blob_talloc(state->result, NULL, len);
+               if (state->result->res_serverSaslCreds.data == NULL) {
+                       goto decode_error;
+               }
+
+               ok = asn1_read(state->result->data,
+                              state->result->res_serverSaslCreds.data,
+                              state->result->res_serverSaslCreds.length);
+
+               ok &= asn1_end_tag(state->result->data);
        }
-       /*
-        * TODO: pull the reply blob
-        */
-       if (state->result->lderr != TLDAP_SUCCESS) {
-               tevent_req_error(req, state->result->lderr);
+
+       ok &= asn1_end_tag(state->result->data);
+
+       if (!ok) {
+               goto decode_error;
+       }
+
+       if (!TLDAP_RC_IS_SUCCESS(state->result->lderr) &&
+           !TLDAP_RC_EQUAL(state->result->lderr,
+                           TLDAP_SASL_BIND_IN_PROGRESS)) {
+               tevent_req_ldap_error(req, state->result->lderr);
                return;
        }
        tevent_req_done(req);
+       return;
+
+decode_error:
+       tevent_req_ldap_error(req, TLDAP_DECODING_ERROR);
+       return;
 }
 
-int tldap_sasl_bind_recv(struct tevent_req *req)
+TLDAPRC tldap_sasl_bind_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
+                            DATA_BLOB *serverSaslCreds)
 {
-       return tldap_simple_recv(req);
+       struct tldap_req_state *state = tevent_req_data(
+               req, struct tldap_req_state);
+       TLDAPRC rc;
+
+       if (tevent_req_is_ldap_error(req, &rc)) {
+               return rc;
+       }
+
+       if (serverSaslCreds != NULL) {
+               serverSaslCreds->data = talloc_move(
+                       mem_ctx, &state->result->res_serverSaslCreds.data);
+               serverSaslCreds->length =
+                       state->result->res_serverSaslCreds.length;
+       }
+
+       return state->result->lderr;
 }
 
-int tldap_sasl_bind(struct tldap_context *ld,
-                   const char *dn,
-                   const char *mechanism,
-                   DATA_BLOB *creds,
-                   struct tldap_control *sctrls,
-                   int num_sctrls,
-                   struct tldap_control *cctrls,
-                   int num_cctrls)
+TLDAPRC tldap_sasl_bind(struct tldap_context *ld,
+                       const char *dn,
+                       const char *mechanism,
+                       DATA_BLOB *creds,
+                       struct tldap_control *sctrls,
+                       int num_sctrls,
+                       struct tldap_control *cctrls,
+                       int num_cctrls,
+                       TALLOC_CTX *mem_ctx,
+                       DATA_BLOB *serverSaslCreds)
 {
        TALLOC_CTX *frame = talloc_stackframe();
        struct tevent_context *ev;
        struct tevent_req *req;
-       int result;
+       TLDAPRC rc = TLDAP_NO_MEMORY;
 
        ev = samba_tevent_context_init(frame);
        if (ev == NULL) {
-               result = TLDAP_NO_MEMORY;
                goto fail;
        }
-
        req = tldap_sasl_bind_send(frame, ev, ld, dn, mechanism, creds,
                                   sctrls, num_sctrls, cctrls, num_cctrls);
        if (req == NULL) {
-               result = TLDAP_NO_MEMORY;
                goto fail;
        }
-
        if (!tevent_req_poll(req, ev)) {
-               result = TLDAP_OPERATIONS_ERROR;
+               rc = TLDAP_OPERATIONS_ERROR;
                goto fail;
        }
-
-       result = tldap_sasl_bind_recv(req);
+       rc = tldap_sasl_bind_recv(req, mem_ctx, serverSaslCreds);
        tldap_save_msg(ld, req);
  fail:
        TALLOC_FREE(frame);
-       return result;
+       return rc;
 }
 
 struct tevent_req *tldap_simple_bind_send(TALLOC_CTX *mem_ctx,
@@ -961,13 +1158,13 @@ struct tevent_req *tldap_simple_bind_send(TALLOC_CTX *mem_ctx,
                                    NULL, 0);
 }
 
-int tldap_simple_bind_recv(struct tevent_req *req)
+TLDAPRC tldap_simple_bind_recv(struct tevent_req *req)
 {
-       return tldap_sasl_bind_recv(req);
+       return tldap_sasl_bind_recv(req, NULL, NULL);
 }
 
-int tldap_simple_bind(struct tldap_context *ld, const char *dn,
-                     const char *passwd)
+TLDAPRC tldap_simple_bind(struct tldap_context *ld, const char *dn,
+                         const char *passwd)
 {
        DATA_BLOB cred;
 
@@ -978,7 +1175,8 @@ int tldap_simple_bind(struct tldap_context *ld, const char *dn,
                cred.data = discard_const_p(uint8_t, "");
                cred.length = 0;
        }
-       return tldap_sasl_bind(ld, dn, NULL, &cred, NULL, 0, NULL, 0);
+       return tldap_sasl_bind(ld, dn, NULL, &cred, NULL, 0, NULL, 0,
+                              NULL, NULL);
 }
 
 /*****************************************************************************/
@@ -1089,6 +1287,7 @@ static char *tldap_get_val(TALLOC_CTX *memctx,
        while (*s) {
                s = strchr(s, ')');
                if (s && (*(s - 1) == '\\')) {
+                       s++;
                        continue;
                }
                break;
@@ -1164,7 +1363,8 @@ static bool tldap_find_first_star(const char *val, const char **star)
 
 static bool tldap_unescape_inplace(char *value, size_t *val_len)
 {
-       int c, i, p;
+       int c;
+       size_t i, p;
 
        for (i = 0,p = 0; i < *val_len; i++) {
 
@@ -1182,6 +1382,7 @@ static bool tldap_unescape_inplace(char *value, size_t *val_len)
                        }
                        i++;
 
+                       /* LDAPv3 escaped */
                        c = tldap_hex2char(&value[i]);
                        if (c >= 0 && c < 256) {
                                value[p] = c;
@@ -1190,6 +1391,7 @@ static bool tldap_unescape_inplace(char *value, size_t *val_len)
                                break;
                        }
 
+                       /* LDAPv2 escaped */
                        switch (value[i]) {
                        case '(':
                        case ')':
@@ -1197,6 +1399,8 @@ static bool tldap_unescape_inplace(char *value, size_t *val_len)
                        case '\\':
                                value[p] = value[i];
                                p++;
+
+                               break;
                        default:
                                /* invalid */
                                return false;
@@ -1621,10 +1825,10 @@ static bool tldap_push_filter_substring(struct tldap_context *ld,
        return asn1_pop_tag(data);
 }
 
-/* NOTE: although openldap libraries allow for spaces in some places, mosly
- * around parenthesis, we do not allow any spaces (except in values of
- * course) as I couldn't fine any place in RFC 4512 or RFC 4515 where
- * leading or trailing spaces where allowed.
+/* NOTE: although openldap libraries allow for spaces in some places, mostly
+ * around parentheses, we do not allow any spaces (except in values of
+ * course) as I couldn't find any place in RFC 4512 or RFC 4515 where
+ * leading or trailing spaces were allowed.
  */
 static bool tldap_push_filter(struct tldap_context *ld,
                              struct asn1_data *data,
@@ -1699,7 +1903,7 @@ struct tevent_req *tldap_search_send(TALLOC_CTX *mem_ctx,
        return req;
 
  encoding_error:
-       tevent_req_error(req, TLDAP_ENCODING_ERROR);
+       tevent_req_ldap_error(req, TLDAP_ENCODING_ERROR);
        return tevent_req_post(req, ev);
 }
 
@@ -1709,11 +1913,10 @@ static void tldap_search_done(struct tevent_req *subreq)
                subreq, struct tevent_req);
        struct tldap_req_state *state = tevent_req_data(
                req, struct tldap_req_state);
-       int err;
+       TLDAPRC rc;
 
-       err = tldap_msg_recv(subreq, state, &state->result);
-       if (err != TLDAP_SUCCESS) {
-               tevent_req_error(req, err);
+       rc = tldap_msg_recv(subreq, state, &state->result);
+       if (tevent_req_ldap_error(req, rc)) {
                return;
        }
        switch (state->result->type) {
@@ -1732,27 +1935,27 @@ static void tldap_search_done(struct tevent_req *subreq)
                    !tldap_decode_response(state) ||
                    !asn1_end_tag(state->result->data) ||
                    !tldap_decode_controls(state)) {
-                       tevent_req_error(req, TLDAP_DECODING_ERROR);
+                       tevent_req_ldap_error(req, TLDAP_DECODING_ERROR);
                        return;
                }
                tevent_req_done(req);
                break;
        default:
-               tevent_req_error(req, TLDAP_PROTOCOL_ERROR);
+               tevent_req_ldap_error(req, TLDAP_PROTOCOL_ERROR);
                return;
        }
 }
 
-int tldap_search_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
-                     struct tldap_message **pmsg)
+TLDAPRC tldap_search_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
+                         struct tldap_message **pmsg)
 {
        struct tldap_req_state *state = tevent_req_data(
                req, struct tldap_req_state);
-       int err;
+       TLDAPRC rc;
 
        if (!tevent_req_is_in_progress(req)
-           && tevent_req_is_ldap_error(req, &err)) {
-               return err;
+           && tevent_req_is_ldap_error(req, &rc)) {
+               return rc;
        }
 
        if (tevent_req_is_in_progress(req)) {
@@ -1769,134 +1972,161 @@ int tldap_search_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
        return TLDAP_SUCCESS;
 }
 
-struct tldap_sync_search_state {
-       TALLOC_CTX *mem_ctx;
-       struct tldap_message **entries;
-       struct tldap_message **refs;
-       int rc;
+struct tldap_search_all_state {
+       struct tldap_message **msgs;
+       struct tldap_message *result;
 };
 
-static void tldap_search_cb(struct tevent_req *req)
+static void tldap_search_all_done(struct tevent_req *subreq);
+
+struct tevent_req *tldap_search_all_send(
+       TALLOC_CTX *mem_ctx, struct tevent_context *ev,
+       struct tldap_context *ld, const char *base, int scope,
+       const char *filter, const char **attrs, int num_attrs, int attrsonly,
+       struct tldap_control *sctrls, int num_sctrls,
+       struct tldap_control *cctrls, int num_cctrls,
+       int timelimit, int sizelimit, int deref)
+{
+       struct tevent_req *req, *subreq;
+       struct tldap_search_all_state *state;
+
+       req = tevent_req_create(mem_ctx, &state,
+                               struct tldap_search_all_state);
+       if (req == NULL) {
+               return NULL;
+       }
+
+       subreq = tldap_search_send(state, ev, ld, base, scope, filter,
+                                  attrs, num_attrs, attrsonly,
+                                  sctrls, num_sctrls, cctrls, num_cctrls,
+                                  timelimit, sizelimit, deref);
+       if (tevent_req_nomem(subreq, req)) {
+               return tevent_req_post(req, ev);
+       }
+       tevent_req_set_callback(subreq, tldap_search_all_done, req);
+       return req;
+}
+
+static void tldap_search_all_done(struct tevent_req *subreq)
 {
-       struct tldap_sync_search_state *state =
-               (struct tldap_sync_search_state *)
-               tevent_req_callback_data_void(req);
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct tldap_search_all_state *state = tevent_req_data(
+               req, struct tldap_search_all_state);
        struct tldap_message *msg, **tmp;
-       int rc, num_entries, num_refs;
+       size_t num_msgs;
+       TLDAPRC rc;
+       int msgtype;
 
-       rc = tldap_search_recv(req, talloc_tos(), &msg);
-       if (rc != TLDAP_SUCCESS) {
-               state->rc = rc;
+       rc = tldap_search_recv(subreq, state, &msg);
+       /* No TALLOC_FREE(subreq), this is multi-step */
+       if (tevent_req_ldap_error(req, rc)) {
                return;
        }
 
-       switch (tldap_msg_type(msg)) {
-       case TLDAP_RES_SEARCH_ENTRY:
-               num_entries = talloc_array_length(state->entries);
-               tmp = talloc_realloc(state->mem_ctx, state->entries,
-                                    struct tldap_message *, num_entries + 1);
-               if (tmp == NULL) {
-                       state->rc = TLDAP_NO_MEMORY;
-                       return;
-               }
-               state->entries = tmp;
-               state->entries[num_entries] = talloc_move(state->entries,
-                                                         &msg);
-               break;
-       case TLDAP_RES_SEARCH_REFERENCE:
-               num_refs = talloc_array_length(state->refs);
-               tmp = talloc_realloc(state->mem_ctx, state->refs,
-                                    struct tldap_message *, num_refs + 1);
-               if (tmp == NULL) {
-                       state->rc = TLDAP_NO_MEMORY;
-                       return;
-               }
-               state->refs = tmp;
-               state->refs[num_refs] = talloc_move(state->refs, &msg);
-               break;
-       case TLDAP_RES_SEARCH_RESULT:
-               state->rc = TLDAP_SUCCESS;
-               break;
-       default:
-               state->rc = TLDAP_PROTOCOL_ERROR;
-               break;
+       msgtype = tldap_msg_type(msg);
+       if (msgtype == TLDAP_RES_SEARCH_RESULT) {
+               state->result = msg;
+               tevent_req_done(req);
+               return;
        }
+
+       num_msgs = talloc_array_length(state->msgs);
+
+       tmp = talloc_realloc(state, state->msgs, struct tldap_message *,
+                            num_msgs + 1);
+       if (tevent_req_nomem(tmp, req)) {
+               return;
+       }
+       state->msgs = tmp;
+       state->msgs[num_msgs] = talloc_move(state->msgs, &msg);
 }
 
-int tldap_search(struct tldap_context *ld,
-                const char *base, int scope, const char *filter,
-                const char **attrs, int num_attrs, int attrsonly,
-                struct tldap_control *sctrls, int num_sctrls,
-                struct tldap_control *cctrls, int num_cctrls,
-                int timelimit, int sizelimit, int deref,
-                TALLOC_CTX *mem_ctx, struct tldap_message ***entries,
-                struct tldap_message ***refs)
+TLDAPRC tldap_search_all_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
+                             struct tldap_message ***msgs,
+                             struct tldap_message **result)
 {
-       TALLOC_CTX *frame = talloc_stackframe();
+       struct tldap_search_all_state *state = tevent_req_data(
+               req, struct tldap_search_all_state);
+       TLDAPRC rc;
+
+       if (tevent_req_is_ldap_error(req, &rc)) {
+               return rc;
+       }
+
+       if (msgs != NULL) {
+               *msgs = talloc_move(mem_ctx, &state->msgs);
+       }
+       if (result != NULL) {
+               *result = talloc_move(mem_ctx, &state->result);
+       }
+
+       return TLDAP_SUCCESS;
+}
+
+TLDAPRC tldap_search(struct tldap_context *ld,
+                    const char *base, int scope, const char *filter,
+                    const char **attrs, int num_attrs, int attrsonly,
+                    struct tldap_control *sctrls, int num_sctrls,
+                    struct tldap_control *cctrls, int num_cctrls,
+                    int timelimit, int sizelimit, int deref,
+                    TALLOC_CTX *mem_ctx, struct tldap_message ***pmsgs)
+{
+       TALLOC_CTX *frame;
        struct tevent_context *ev;
        struct tevent_req *req;
-       struct tldap_sync_search_state state;
+       TLDAPRC rc = TLDAP_NO_MEMORY;
+       struct tldap_message **msgs;
+       struct tldap_message *result;
 
-       ZERO_STRUCT(state);
-       state.mem_ctx = mem_ctx;
-       state.rc = TLDAP_SUCCESS;
+       if (tldap_pending_reqs(ld)) {
+               return TLDAP_BUSY;
+       }
+
+       frame = talloc_stackframe();
 
        ev = samba_tevent_context_init(frame);
        if (ev == NULL) {
-               state.rc = TLDAP_NO_MEMORY;
                goto fail;
        }
-
-       req = tldap_search_send(frame, ev, ld, base, scope, filter,
-                               attrs, num_attrs, attrsonly,
-                               sctrls, num_sctrls, cctrls, num_cctrls,
-                               timelimit, sizelimit, deref);
+       req = tldap_search_all_send(frame, ev, ld, base, scope, filter,
+                                   attrs, num_attrs, attrsonly,
+                                   sctrls, num_sctrls, cctrls, num_cctrls,
+                                   timelimit, sizelimit, deref);
        if (req == NULL) {
-               state.rc = TLDAP_NO_MEMORY;
                goto fail;
        }
-
-       tevent_req_set_callback(req, tldap_search_cb, &state);
-
-       if (!tevent_req_is_in_progress(req)) {
-               /* an error happend before sending */
-               if (tevent_req_is_ldap_error(req, &state.rc)) {
-                       goto fail;
-               }
+       if (!tevent_req_poll(req, ev)) {
+               rc = TLDAP_OPERATIONS_ERROR;
+               goto fail;
        }
-
-       while (tevent_req_is_in_progress(req)
-              && (state.rc == TLDAP_SUCCESS)) {
-               if (tevent_loop_once(ev) == -1) {
-                       return TLDAP_OPERATIONS_ERROR;
-               }
+       rc = tldap_search_all_recv(req, frame, &msgs, &result);
+       TALLOC_FREE(req);
+       if (!TLDAP_RC_IS_SUCCESS(rc)) {
+               goto fail;
        }
 
-       if (state.rc != TLDAP_SUCCESS) {
-               return state.rc;
-       }
+       TALLOC_FREE(ld->last_msg);
+       ld->last_msg = talloc_move(ld, &result);
 
-       if (entries != NULL) {
-               *entries = state.entries;
-       } else {
-               TALLOC_FREE(state.entries);
-       }
-       if (refs != NULL) {
-               *refs = state.refs;
-       } else {
-               TALLOC_FREE(state.refs);
+       if (pmsgs != NULL) {
+               *pmsgs = talloc_move(mem_ctx, &msgs);
        }
-       tldap_save_msg(ld, req);
 fail:
        TALLOC_FREE(frame);
-       return state.rc;
+       return rc;
 }
 
 static bool tldap_parse_search_entry(struct tldap_message *msg)
 {
        int num_attribs = 0;
 
-       if (!asn1_start_tag(msg->data, msg->type)) return false;
+       if (msg->type != TLDAP_RES_SEARCH_ENTRY) {
+               return false;
+       }
+       if (!asn1_start_tag(msg->data, TLDAP_RES_SEARCH_ENTRY)) {
+               return false;
+       }
 
        /* dn */
 
@@ -2038,10 +2268,10 @@ static bool tldap_decode_controls(struct tldap_req_state *state)
 
  out:
 
-       if (ret == false) {
-               TALLOC_FREE(sctrls);
-       } else {
+       if (ret) {
                msg->res_sctrls = sctrls;
+       } else {
+               TALLOC_FREE(sctrls);
        }
        return ret;
 }
@@ -2052,37 +2282,36 @@ static void tldap_simple_done(struct tevent_req *subreq, int type)
                subreq, struct tevent_req);
        struct tldap_req_state *state = tevent_req_data(
                req, struct tldap_req_state);
-       int err;
+       TLDAPRC rc;
 
-       err = tldap_msg_recv(subreq, state, &state->result);
+       rc = tldap_msg_recv(subreq, state, &state->result);
        TALLOC_FREE(subreq);
-       if (err != TLDAP_SUCCESS) {
-               tevent_req_error(req, err);
+       if (tevent_req_ldap_error(req, rc)) {
                return;
        }
        if (state->result->type != type) {
-               tevent_req_error(req, TLDAP_PROTOCOL_ERROR);
+               tevent_req_ldap_error(req, TLDAP_PROTOCOL_ERROR);
                return;
        }
        if (!asn1_start_tag(state->result->data, state->result->type) ||
            !tldap_decode_response(state) ||
            !asn1_end_tag(state->result->data) ||
            !tldap_decode_controls(state)) {
-               tevent_req_error(req, TLDAP_DECODING_ERROR);
+               tevent_req_ldap_error(req, TLDAP_DECODING_ERROR);
                return;
        }
-       if (state->result->lderr != TLDAP_SUCCESS) {
-               tevent_req_error(req, state->result->lderr);
+       if (!TLDAP_RC_IS_SUCCESS(state->result->lderr)) {
+               tevent_req_ldap_error(req, state->result->lderr);
                return;
        }
        tevent_req_done(req);
 }
 
-static int tldap_simple_recv(struct tevent_req *req)
+static TLDAPRC tldap_simple_recv(struct tevent_req *req)
 {
-       int err;
-       if (tevent_req_is_ldap_error(req, &err)) {
-               return err;
+       TLDAPRC rc;
+       if (tevent_req_is_ldap_error(req, &rc)) {
+               return rc;
        }
        return TLDAP_SUCCESS;
 }
@@ -2141,7 +2370,7 @@ struct tevent_req *tldap_add_send(TALLOC_CTX *mem_ctx,
 
   err:
 
-       tevent_req_error(req, TLDAP_ENCODING_ERROR);
+       tevent_req_ldap_error(req, TLDAP_ENCODING_ERROR);
        return tevent_req_post(req, ev);
 }
 
@@ -2150,44 +2379,39 @@ static void tldap_add_done(struct tevent_req *subreq)
        tldap_simple_done(subreq, TLDAP_RES_ADD);
 }
 
-int tldap_add_recv(struct tevent_req *req)
+TLDAPRC tldap_add_recv(struct tevent_req *req)
 {
        return tldap_simple_recv(req);
 }
 
-int tldap_add(struct tldap_context *ld, const char *dn,
-             struct tldap_mod *attributes, int num_attributes,
-             struct tldap_control *sctrls, int num_sctrls,
-             struct tldap_control *cctrls, int num_cctrls)
+TLDAPRC tldap_add(struct tldap_context *ld, const char *dn,
+                 struct tldap_mod *attributes, int num_attributes,
+                 struct tldap_control *sctrls, int num_sctrls,
+                 struct tldap_control *cctrls, int num_cctrls)
 {
        TALLOC_CTX *frame = talloc_stackframe();
        struct tevent_context *ev;
        struct tevent_req *req;
-       int result;
+       TLDAPRC rc = TLDAP_NO_MEMORY;
 
        ev = samba_tevent_context_init(frame);
        if (ev == NULL) {
-               result = TLDAP_NO_MEMORY;
                goto fail;
        }
-
        req = tldap_add_send(frame, ev, ld, dn, attributes, num_attributes,
                             sctrls, num_sctrls, cctrls, num_cctrls);
        if (req == NULL) {
-               result = TLDAP_NO_MEMORY;
                goto fail;
        }
-
        if (!tevent_req_poll(req, ev)) {
-               result = TLDAP_OPERATIONS_ERROR;
+               rc = TLDAP_OPERATIONS_ERROR;
                goto fail;
        }
-
-       result = tldap_add_recv(req);
+       rc = tldap_add_recv(req);
        tldap_save_msg(ld, req);
  fail:
        TALLOC_FREE(frame);
-       return result;
+       return rc;
 }
 
 static void tldap_modify_done(struct tevent_req *subreq);
@@ -2246,7 +2470,7 @@ struct tevent_req *tldap_modify_send(TALLOC_CTX *mem_ctx,
 
   err:
 
-       tevent_req_error(req, TLDAP_ENCODING_ERROR);
+       tevent_req_ldap_error(req, TLDAP_ENCODING_ERROR);
        return tevent_req_post(req, ev);
 }
 
@@ -2255,44 +2479,39 @@ static void tldap_modify_done(struct tevent_req *subreq)
        tldap_simple_done(subreq, TLDAP_RES_MODIFY);
 }
 
-int tldap_modify_recv(struct tevent_req *req)
+TLDAPRC tldap_modify_recv(struct tevent_req *req)
 {
        return tldap_simple_recv(req);
 }
 
-int tldap_modify(struct tldap_context *ld, const char *dn,
-                struct tldap_mod *mods, int num_mods,
-                struct tldap_control *sctrls, int num_sctrls,
-                struct tldap_control *cctrls, int num_cctrls)
+TLDAPRC tldap_modify(struct tldap_context *ld, const char *dn,
+                    struct tldap_mod *mods, int num_mods,
+                    struct tldap_control *sctrls, int num_sctrls,
+                    struct tldap_control *cctrls, int num_cctrls)
  {
        TALLOC_CTX *frame = talloc_stackframe();
        struct tevent_context *ev;
        struct tevent_req *req;
-       int result;
+       TLDAPRC rc = TLDAP_NO_MEMORY;
 
        ev = samba_tevent_context_init(frame);
        if (ev == NULL) {
-               result = TLDAP_NO_MEMORY;
                goto fail;
        }
-
        req = tldap_modify_send(frame, ev, ld, dn, mods, num_mods,
                                sctrls, num_sctrls, cctrls, num_cctrls);
        if (req == NULL) {
-               result = TLDAP_NO_MEMORY;
                goto fail;
        }
-
        if (!tevent_req_poll(req, ev)) {
-               result = TLDAP_OPERATIONS_ERROR;
+               rc = TLDAP_OPERATIONS_ERROR;
                goto fail;
        }
-
-       result = tldap_modify_recv(req);
+       rc = tldap_modify_recv(req);
        tldap_save_msg(ld, req);
  fail:
        TALLOC_FREE(frame);
-       return result;
+       return rc;
 }
 
 static void tldap_delete_done(struct tevent_req *subreq);
@@ -2328,7 +2547,7 @@ struct tevent_req *tldap_delete_send(TALLOC_CTX *mem_ctx,
 
   err:
 
-       tevent_req_error(req, TLDAP_ENCODING_ERROR);
+       tevent_req_ldap_error(req, TLDAP_ENCODING_ERROR);
        return tevent_req_post(req, ev);
 }
 
@@ -2337,43 +2556,233 @@ static void tldap_delete_done(struct tevent_req *subreq)
        tldap_simple_done(subreq, TLDAP_RES_DELETE);
 }
 
-int tldap_delete_recv(struct tevent_req *req)
+TLDAPRC tldap_delete_recv(struct tevent_req *req)
 {
        return tldap_simple_recv(req);
 }
 
-int tldap_delete(struct tldap_context *ld, const char *dn,
-                struct tldap_control *sctrls, int num_sctrls,
-                struct tldap_control *cctrls, int num_cctrls)
+TLDAPRC tldap_delete(struct tldap_context *ld, const char *dn,
+                    struct tldap_control *sctrls, int num_sctrls,
+                    struct tldap_control *cctrls, int num_cctrls)
 {
        TALLOC_CTX *frame = talloc_stackframe();
        struct tevent_context *ev;
        struct tevent_req *req;
-       int result;
+       TLDAPRC rc = TLDAP_NO_MEMORY;
 
        ev = samba_tevent_context_init(frame);
        if (ev == NULL) {
-               result = TLDAP_NO_MEMORY;
                goto fail;
        }
-
        req = tldap_delete_send(frame, ev, ld, dn, sctrls, num_sctrls,
                                cctrls, num_cctrls);
        if (req == NULL) {
-               result = TLDAP_NO_MEMORY;
                goto fail;
        }
-
        if (!tevent_req_poll(req, ev)) {
-               result = TLDAP_OPERATIONS_ERROR;
+               rc = TLDAP_OPERATIONS_ERROR;
                goto fail;
        }
+       rc = tldap_delete_recv(req);
+       tldap_save_msg(ld, req);
+ fail:
+       TALLOC_FREE(frame);
+       return rc;
+}
+
+static void tldap_extended_done(struct tevent_req *subreq);
+
+struct tevent_req *tldap_extended_send(TALLOC_CTX *mem_ctx,
+                                      struct tevent_context *ev,
+                                      struct tldap_context *ld,
+                                      const char *in_oid,
+                                      const DATA_BLOB *in_blob,
+                                      struct tldap_control *sctrls,
+                                      int num_sctrls,
+                                      struct tldap_control *cctrls,
+                                      int num_cctrls)
+{
+       struct tevent_req *req, *subreq;
+       struct tldap_req_state *state;
+
+       req = tldap_req_create(mem_ctx, ld, &state);
+       if (req == NULL) {
+               return NULL;
+       }
+
+       if (!asn1_push_tag(state->out, TLDAP_REQ_EXTENDED)) goto err;
+
+       if (!asn1_push_tag(state->out, ASN1_CONTEXT_SIMPLE(0))) goto err;
+       if (!asn1_write(state->out, in_oid, strlen(in_oid))) goto err;
+       if (!asn1_pop_tag(state->out)) goto err;
+
+       if (in_blob != NULL) {
+               if (!asn1_push_tag(state->out, ASN1_CONTEXT_SIMPLE(1))) goto err;
+               if (!asn1_write_OctetString(state->out, in_blob->data, in_blob->length)) goto err;
+               if (!asn1_pop_tag(state->out)) goto err;
+       }
+
+       if (!asn1_pop_tag(state->out)) goto err;
+
+       subreq = tldap_msg_send(state, ev, ld, state->id, state->out,
+                               sctrls, num_sctrls);
+       if (tevent_req_nomem(subreq, req)) {
+               return tevent_req_post(req, ev);
+       }
+       tevent_req_set_callback(subreq, tldap_extended_done, req);
+       return req;
+
+  err:
+
+       tevent_req_ldap_error(req, TLDAP_ENCODING_ERROR);
+       return tevent_req_post(req, ev);
+}
+
+static void tldap_extended_done(struct tevent_req *subreq)
+{
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct tldap_req_state *state = tevent_req_data(
+               req, struct tldap_req_state);
+       TLDAPRC rc;
+       bool ok;
+
+       rc = tldap_msg_recv(subreq, state, &state->result);
+       TALLOC_FREE(subreq);
+       if (tevent_req_ldap_error(req, rc)) {
+               return;
+       }
+       if (state->result->type != TLDAP_RES_EXTENDED) {
+               tevent_req_ldap_error(req, TLDAP_PROTOCOL_ERROR);
+               return;
+       }
+
+       ok = asn1_start_tag(state->result->data, TLDAP_RES_EXTENDED);
+       ok &= tldap_decode_response(state);
+
+       if (asn1_peek_tag(state->result->data, ASN1_CONTEXT_SIMPLE(10))) {
+               ok &= asn1_start_tag(state->result->data,
+                                    ASN1_CONTEXT_SIMPLE(10));
+               if (!ok) {
+                       goto decode_error;
+               }
+
+               ok &= asn1_read_LDAPString(state->result->data,
+                                          state->result,
+                                          &state->result->res_extended.oid);
+
+               ok &= asn1_end_tag(state->result->data);
+       }
+
+       if (asn1_peek_tag(state->result->data, ASN1_CONTEXT_SIMPLE(11))) {
+               int len;
+
+               ok &= asn1_start_tag(state->result->data,
+                                    ASN1_CONTEXT_SIMPLE(11));
+               if (!ok) {
+                       goto decode_error;
+               }
+
+               len = asn1_tag_remaining(state->result->data);
+               if (len == -1) {
+                       goto decode_error;
+               }
 
-       result = tldap_delete_recv(req);
+               state->result->res_extended.blob =
+                       data_blob_talloc(state->result, NULL, len);
+               if (state->result->res_extended.blob.data == NULL) {
+                       goto decode_error;
+               }
+
+               ok = asn1_read(state->result->data,
+                              state->result->res_extended.blob.data,
+                              state->result->res_extended.blob.length);
+
+               ok &= asn1_end_tag(state->result->data);
+       }
+
+       ok &= asn1_end_tag(state->result->data);
+
+       if (!ok) {
+               goto decode_error;
+       }
+
+       if (!TLDAP_RC_IS_SUCCESS(state->result->lderr)) {
+               tevent_req_ldap_error(req, state->result->lderr);
+               return;
+       }
+       tevent_req_done(req);
+       return;
+
+decode_error:
+       tevent_req_ldap_error(req, TLDAP_DECODING_ERROR);
+       return;
+}
+
+TLDAPRC tldap_extended_recv(struct tevent_req *req,
+                           TALLOC_CTX *mem_ctx,
+                           char **out_oid,
+                           DATA_BLOB *out_blob)
+{
+       struct tldap_req_state *state = tevent_req_data(
+               req, struct tldap_req_state);
+       TLDAPRC rc;
+
+       if (tevent_req_is_ldap_error(req, &rc)) {
+               return rc;
+       }
+
+       if (out_oid != NULL) {
+               *out_oid = talloc_move(mem_ctx,
+                               &state->result->res_extended.oid);
+       }
+
+       if (out_blob != NULL) {
+               out_blob->data = talloc_move(mem_ctx,
+                               &state->result->res_extended.blob.data);
+               out_blob->length =
+                               state->result->res_extended.blob.length;
+       }
+
+       return state->result->lderr;
+}
+
+TLDAPRC tldap_extended(struct tldap_context *ld,
+                       const char *in_oid,
+                       const DATA_BLOB *in_blob,
+                       struct tldap_control *sctrls,
+                       int num_sctrls,
+                       struct tldap_control *cctrls,
+                       int num_cctrls,
+                       TALLOC_CTX *mem_ctx,
+                       char **out_oid,
+                       DATA_BLOB *out_blob)
+{
+       TALLOC_CTX *frame = talloc_stackframe();
+       struct tevent_context *ev;
+       struct tevent_req *req;
+       TLDAPRC rc = TLDAP_NO_MEMORY;
+
+       ev = samba_tevent_context_init(frame);
+       if (ev == NULL) {
+               goto fail;
+       }
+       req = tldap_extended_send(frame, ev, ld,
+                                 in_oid, in_blob,
+                                 sctrls, num_sctrls,
+                                 cctrls, num_cctrls);
+       if (req == NULL) {
+               goto fail;
+       }
+       if (!tevent_req_poll(req, ev)) {
+               rc = TLDAP_OPERATIONS_ERROR;
+               goto fail;
+       }
+       rc = tldap_extended_recv(req, mem_ctx, out_oid, out_blob);
        tldap_save_msg(ld, req);
  fail:
        TALLOC_FREE(frame);
-       return result;
+       return rc;
 }
 
 int tldap_msg_id(const struct tldap_message *msg)
@@ -2427,198 +2836,135 @@ struct tldap_message *tldap_ctx_lastmsg(struct tldap_context *ld)
        return ld->last_msg;
 }
 
-const char *tldap_err2string(int rc)
-{
-       const char *res = NULL;
+static const struct { TLDAPRC rc; const char *string; } tldaprc_errmap[] =
+{
+       { TLDAP_SUCCESS,
+         "TLDAP_SUCCESS" },
+       { TLDAP_OPERATIONS_ERROR,
+         "TLDAP_OPERATIONS_ERROR" },
+       { TLDAP_PROTOCOL_ERROR,
+         "TLDAP_PROTOCOL_ERROR" },
+       { TLDAP_TIMELIMIT_EXCEEDED,
+         "TLDAP_TIMELIMIT_EXCEEDED" },
+       { TLDAP_SIZELIMIT_EXCEEDED,
+         "TLDAP_SIZELIMIT_EXCEEDED" },
+       { TLDAP_COMPARE_FALSE,
+         "TLDAP_COMPARE_FALSE" },
+       { TLDAP_COMPARE_TRUE,
+         "TLDAP_COMPARE_TRUE" },
+       { TLDAP_STRONG_AUTH_NOT_SUPPORTED,
+         "TLDAP_STRONG_AUTH_NOT_SUPPORTED" },
+       { TLDAP_STRONG_AUTH_REQUIRED,
+         "TLDAP_STRONG_AUTH_REQUIRED" },
+       { TLDAP_REFERRAL,
+         "TLDAP_REFERRAL" },
+       { TLDAP_ADMINLIMIT_EXCEEDED,
+         "TLDAP_ADMINLIMIT_EXCEEDED" },
+       { TLDAP_UNAVAILABLE_CRITICAL_EXTENSION,
+         "TLDAP_UNAVAILABLE_CRITICAL_EXTENSION" },
+       { TLDAP_CONFIDENTIALITY_REQUIRED,
+         "TLDAP_CONFIDENTIALITY_REQUIRED" },
+       { TLDAP_SASL_BIND_IN_PROGRESS,
+         "TLDAP_SASL_BIND_IN_PROGRESS" },
+       { TLDAP_NO_SUCH_ATTRIBUTE,
+         "TLDAP_NO_SUCH_ATTRIBUTE" },
+       { TLDAP_UNDEFINED_TYPE,
+         "TLDAP_UNDEFINED_TYPE" },
+       { TLDAP_INAPPROPRIATE_MATCHING,
+         "TLDAP_INAPPROPRIATE_MATCHING" },
+       { TLDAP_CONSTRAINT_VIOLATION,
+         "TLDAP_CONSTRAINT_VIOLATION" },
+       { TLDAP_TYPE_OR_VALUE_EXISTS,
+         "TLDAP_TYPE_OR_VALUE_EXISTS" },
+       { TLDAP_INVALID_SYNTAX,
+         "TLDAP_INVALID_SYNTAX" },
+       { TLDAP_NO_SUCH_OBJECT,
+         "TLDAP_NO_SUCH_OBJECT" },
+       { TLDAP_ALIAS_PROBLEM,
+         "TLDAP_ALIAS_PROBLEM" },
+       { TLDAP_INVALID_DN_SYNTAX,
+         "TLDAP_INVALID_DN_SYNTAX" },
+       { TLDAP_IS_LEAF,
+         "TLDAP_IS_LEAF" },
+       { TLDAP_ALIAS_DEREF_PROBLEM,
+         "TLDAP_ALIAS_DEREF_PROBLEM" },
+       { TLDAP_INAPPROPRIATE_AUTH,
+         "TLDAP_INAPPROPRIATE_AUTH" },
+       { TLDAP_INVALID_CREDENTIALS,
+         "TLDAP_INVALID_CREDENTIALS" },
+       { TLDAP_INSUFFICIENT_ACCESS,
+         "TLDAP_INSUFFICIENT_ACCESS" },
+       { TLDAP_BUSY,
+         "TLDAP_BUSY" },
+       { TLDAP_UNAVAILABLE,
+         "TLDAP_UNAVAILABLE" },
+       { TLDAP_UNWILLING_TO_PERFORM,
+         "TLDAP_UNWILLING_TO_PERFORM" },
+       { TLDAP_LOOP_DETECT,
+         "TLDAP_LOOP_DETECT" },
+       { TLDAP_NAMING_VIOLATION,
+         "TLDAP_NAMING_VIOLATION" },
+       { TLDAP_OBJECT_CLASS_VIOLATION,
+         "TLDAP_OBJECT_CLASS_VIOLATION" },
+       { TLDAP_NOT_ALLOWED_ON_NONLEAF,
+         "TLDAP_NOT_ALLOWED_ON_NONLEAF" },
+       { TLDAP_NOT_ALLOWED_ON_RDN,
+         "TLDAP_NOT_ALLOWED_ON_RDN" },
+       { TLDAP_ALREADY_EXISTS,
+         "TLDAP_ALREADY_EXISTS" },
+       { TLDAP_NO_OBJECT_CLASS_MODS,
+         "TLDAP_NO_OBJECT_CLASS_MODS" },
+       { TLDAP_RESULTS_TOO_LARGE,
+         "TLDAP_RESULTS_TOO_LARGE" },
+       { TLDAP_AFFECTS_MULTIPLE_DSAS,
+         "TLDAP_AFFECTS_MULTIPLE_DSAS" },
+       { TLDAP_OTHER,
+         "TLDAP_OTHER" },
+       { TLDAP_SERVER_DOWN,
+         "TLDAP_SERVER_DOWN" },
+       { TLDAP_LOCAL_ERROR,
+         "TLDAP_LOCAL_ERROR" },
+       { TLDAP_ENCODING_ERROR,
+         "TLDAP_ENCODING_ERROR" },
+       { TLDAP_DECODING_ERROR,
+         "TLDAP_DECODING_ERROR" },
+       { TLDAP_TIMEOUT,
+         "TLDAP_TIMEOUT" },
+       { TLDAP_AUTH_UNKNOWN,
+         "TLDAP_AUTH_UNKNOWN" },
+       { TLDAP_FILTER_ERROR,
+         "TLDAP_FILTER_ERROR" },
+       { TLDAP_USER_CANCELLED,
+         "TLDAP_USER_CANCELLED" },
+       { TLDAP_PARAM_ERROR,
+         "TLDAP_PARAM_ERROR" },
+       { TLDAP_NO_MEMORY,
+         "TLDAP_NO_MEMORY" },
+       { TLDAP_CONNECT_ERROR,
+         "TLDAP_CONNECT_ERROR" },
+       { TLDAP_NOT_SUPPORTED,
+         "TLDAP_NOT_SUPPORTED" },
+       { TLDAP_CONTROL_NOT_FOUND,
+         "TLDAP_CONTROL_NOT_FOUND" },
+       { TLDAP_NO_RESULTS_RETURNED,
+         "TLDAP_NO_RESULTS_RETURNED" },
+       { TLDAP_MORE_RESULTS_TO_RETURN,
+         "TLDAP_MORE_RESULTS_TO_RETURN" },
+       { TLDAP_CLIENT_LOOP,
+         "TLDAP_CLIENT_LOOP" },
+       { TLDAP_REFERRAL_LIMIT_EXCEEDED,
+         "TLDAP_REFERRAL_LIMIT_EXCEEDED" },
+};
 
-       /*
-        * This would normally be a table, but the error codes are not fully
-        * sequential. Let the compiler figure out the optimum implementation
-        * :-)
-        */
+const char *tldap_rc2string(TLDAPRC rc)
+{
+       size_t i;
 
-       switch (rc) {
-       case TLDAP_SUCCESS:
-               res = "TLDAP_SUCCESS";
-               break;
-       case TLDAP_OPERATIONS_ERROR:
-               res = "TLDAP_OPERATIONS_ERROR";
-               break;
-       case TLDAP_PROTOCOL_ERROR:
-               res = "TLDAP_PROTOCOL_ERROR";
-               break;
-       case TLDAP_TIMELIMIT_EXCEEDED:
-               res = "TLDAP_TIMELIMIT_EXCEEDED";
-               break;
-       case TLDAP_SIZELIMIT_EXCEEDED:
-               res = "TLDAP_SIZELIMIT_EXCEEDED";
-               break;
-       case TLDAP_COMPARE_FALSE:
-               res = "TLDAP_COMPARE_FALSE";
-               break;
-       case TLDAP_COMPARE_TRUE:
-               res = "TLDAP_COMPARE_TRUE";
-               break;
-       case TLDAP_STRONG_AUTH_NOT_SUPPORTED:
-               res = "TLDAP_STRONG_AUTH_NOT_SUPPORTED";
-               break;
-       case TLDAP_STRONG_AUTH_REQUIRED:
-               res = "TLDAP_STRONG_AUTH_REQUIRED";
-               break;
-       case TLDAP_REFERRAL:
-               res = "TLDAP_REFERRAL";
-               break;
-       case TLDAP_ADMINLIMIT_EXCEEDED:
-               res = "TLDAP_ADMINLIMIT_EXCEEDED";
-               break;
-       case TLDAP_UNAVAILABLE_CRITICAL_EXTENSION:
-               res = "TLDAP_UNAVAILABLE_CRITICAL_EXTENSION";
-               break;
-       case TLDAP_CONFIDENTIALITY_REQUIRED:
-               res = "TLDAP_CONFIDENTIALITY_REQUIRED";
-               break;
-       case TLDAP_SASL_BIND_IN_PROGRESS:
-               res = "TLDAP_SASL_BIND_IN_PROGRESS";
-               break;
-       case TLDAP_NO_SUCH_ATTRIBUTE:
-               res = "TLDAP_NO_SUCH_ATTRIBUTE";
-               break;
-       case TLDAP_UNDEFINED_TYPE:
-               res = "TLDAP_UNDEFINED_TYPE";
-               break;
-       case TLDAP_INAPPROPRIATE_MATCHING:
-               res = "TLDAP_INAPPROPRIATE_MATCHING";
-               break;
-       case TLDAP_CONSTRAINT_VIOLATION:
-               res = "TLDAP_CONSTRAINT_VIOLATION";
-               break;
-       case TLDAP_TYPE_OR_VALUE_EXISTS:
-               res = "TLDAP_TYPE_OR_VALUE_EXISTS";
-               break;
-       case TLDAP_INVALID_SYNTAX:
-               res = "TLDAP_INVALID_SYNTAX";
-               break;
-       case TLDAP_NO_SUCH_OBJECT:
-               res = "TLDAP_NO_SUCH_OBJECT";
-               break;
-       case TLDAP_ALIAS_PROBLEM:
-               res = "TLDAP_ALIAS_PROBLEM";
-               break;
-       case TLDAP_INVALID_DN_SYNTAX:
-               res = "TLDAP_INVALID_DN_SYNTAX";
-               break;
-       case TLDAP_IS_LEAF:
-               res = "TLDAP_IS_LEAF";
-               break;
-       case TLDAP_ALIAS_DEREF_PROBLEM:
-               res = "TLDAP_ALIAS_DEREF_PROBLEM";
-               break;
-       case TLDAP_INAPPROPRIATE_AUTH:
-               res = "TLDAP_INAPPROPRIATE_AUTH";
-               break;
-       case TLDAP_INVALID_CREDENTIALS:
-               res = "TLDAP_INVALID_CREDENTIALS";
-               break;
-       case TLDAP_INSUFFICIENT_ACCESS:
-               res = "TLDAP_INSUFFICIENT_ACCESS";
-               break;
-       case TLDAP_BUSY:
-               res = "TLDAP_BUSY";
-               break;
-       case TLDAP_UNAVAILABLE:
-               res = "TLDAP_UNAVAILABLE";
-               break;
-       case TLDAP_UNWILLING_TO_PERFORM:
-               res = "TLDAP_UNWILLING_TO_PERFORM";
-               break;
-       case TLDAP_LOOP_DETECT:
-               res = "TLDAP_LOOP_DETECT";
-               break;
-       case TLDAP_NAMING_VIOLATION:
-               res = "TLDAP_NAMING_VIOLATION";
-               break;
-       case TLDAP_OBJECT_CLASS_VIOLATION:
-               res = "TLDAP_OBJECT_CLASS_VIOLATION";
-               break;
-       case TLDAP_NOT_ALLOWED_ON_NONLEAF:
-               res = "TLDAP_NOT_ALLOWED_ON_NONLEAF";
-               break;
-       case TLDAP_NOT_ALLOWED_ON_RDN:
-               res = "TLDAP_NOT_ALLOWED_ON_RDN";
-               break;
-       case TLDAP_ALREADY_EXISTS:
-               res = "TLDAP_ALREADY_EXISTS";
-               break;
-       case TLDAP_NO_OBJECT_CLASS_MODS:
-               res = "TLDAP_NO_OBJECT_CLASS_MODS";
-               break;
-       case TLDAP_RESULTS_TOO_LARGE:
-               res = "TLDAP_RESULTS_TOO_LARGE";
-               break;
-       case TLDAP_AFFECTS_MULTIPLE_DSAS:
-               res = "TLDAP_AFFECTS_MULTIPLE_DSAS";
-               break;
-       case TLDAP_OTHER:
-               res = "TLDAP_OTHER";
-               break;
-       case TLDAP_SERVER_DOWN:
-               res = "TLDAP_SERVER_DOWN";
-               break;
-       case TLDAP_LOCAL_ERROR:
-               res = "TLDAP_LOCAL_ERROR";
-               break;
-       case TLDAP_ENCODING_ERROR:
-               res = "TLDAP_ENCODING_ERROR";
-               break;
-       case TLDAP_DECODING_ERROR:
-               res = "TLDAP_DECODING_ERROR";
-               break;
-       case TLDAP_TIMEOUT:
-               res = "TLDAP_TIMEOUT";
-               break;
-       case TLDAP_AUTH_UNKNOWN:
-               res = "TLDAP_AUTH_UNKNOWN";
-               break;
-       case TLDAP_FILTER_ERROR:
-               res = "TLDAP_FILTER_ERROR";
-               break;
-       case TLDAP_USER_CANCELLED:
-               res = "TLDAP_USER_CANCELLED";
-               break;
-       case TLDAP_PARAM_ERROR:
-               res = "TLDAP_PARAM_ERROR";
-               break;
-       case TLDAP_NO_MEMORY:
-               res = "TLDAP_NO_MEMORY";
-               break;
-       case TLDAP_CONNECT_ERROR:
-               res = "TLDAP_CONNECT_ERROR";
-               break;
-       case TLDAP_NOT_SUPPORTED:
-               res = "TLDAP_NOT_SUPPORTED";
-               break;
-       case TLDAP_CONTROL_NOT_FOUND:
-               res = "TLDAP_CONTROL_NOT_FOUND";
-               break;
-       case TLDAP_NO_RESULTS_RETURNED:
-               res = "TLDAP_NO_RESULTS_RETURNED";
-               break;
-       case TLDAP_MORE_RESULTS_TO_RETURN:
-               res = "TLDAP_MORE_RESULTS_TO_RETURN";
-               break;
-       case TLDAP_CLIENT_LOOP:
-               res = "TLDAP_CLIENT_LOOP";
-               break;
-       case TLDAP_REFERRAL_LIMIT_EXCEEDED:
-               res = "TLDAP_REFERRAL_LIMIT_EXCEEDED";
-               break;
-       default:
-               res = talloc_asprintf(talloc_tos(), "Unknown LDAP Error (%d)",
-                                     rc);
-               break;
-       }
-       if (res == NULL) {
-               res = "Unknown LDAP Error";
+       for (i=0; i<ARRAY_SIZE(tldaprc_errmap); i++) {
+               if (TLDAP_RC_EQUAL(rc, tldaprc_errmap[i].rc)) {
+                       return tldaprc_errmap[i].string;
+               }
        }
-       return res;
+
+       return "Unknown LDAP Error";
 }