VNC: Get Bytes before adding raw values to tree
authorUli Heilmeier <uh@heilmeier.eu>
Tue, 25 Jul 2017 06:31:05 +0000 (08:31 +0200)
committerMichael Mann <mmann78@netscape.net>
Tue, 25 Jul 2017 12:21:30 +0000 (12:21 +0000)
Make sure to have bytes before adding raw values to tree

Bug: 13910
Change-Id: I9c6fe679df12e0358df80caf01268acb75ee424c
Reviewed-on: https://code.wireshark.org/review/22782
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
epan/dissectors/packet-vnc.c

index 8570467bc0671ab2612fb033c54e91ca080f2989..d0ffdca82ce08592698e7c10fe94062ebd066a51 100644 (file)
@@ -2359,9 +2359,9 @@ vnc_hextile_encoding(tvbuff_t *tvb, packet_info *pinfo, gint *offset,
                        if(subencoding_mask & 0x1) { /* Raw */
                                raw_length = tile_width * tile_height * bytes_per_pixel;
 
+                               VNC_BYTES_NEEDED(raw_length);
                                proto_tree_add_item(tile_tree, hf_vnc_hextile_raw_value, tvb,
                                                    *offset, raw_length, ENC_NA);
-                               VNC_BYTES_NEEDED(raw_length);
                                *offset += raw_length;
                        } else {
                                if(subencoding_mask & 0x2) { /* Background Specified */