Second part of the fix for bug #5790 - samba returns STATUS_OBJECT_NAME_NOT_FOUND...

This was my fault. I use a singleton cache (positive and negative) to speed up pathname based qfileinfo/setfileinfo lookups for alternate fsp's open on the same path. I only invalidated the negative cache on adding a new file fsp, as I incorrectly imagined the new fsp was put at the *end* of the open files list. DLIST_ADD puts it at the start, meaning any subsequent open wasn't seen once the cache was set. Doh !
Jeremy.

diff --git a/source/smbd/files.c b/source/smbd/files.c
index 13e6dd9b2881dd309b117bacb8ef5266db50ae93..b7ac58d5232bc4a66636241714f0a376adf0f7ce 100644 (file)
--- a/source/smbd/files.c
+++ b/source/smbd/files.c
@@ -122,10 +122,12 @@ NTSTATUS file_new(connection_struct *conn, files_struct **result)
 
        chain_fsp = fsp;
 
-       /* A new fsp invalidates a negative fsp_fi_cache. */
-       if (fsp_fi_cache.fsp == NULL) {
-               ZERO_STRUCT(fsp_fi_cache);
-       }
+       /* A new fsp invalidates the positive and
+         negative fsp_fi_cache as the new fsp is pushed
+         at the start of the list and we search from
+         a cache hit to the *end* of the list. */
+
+       ZERO_STRUCT(fsp_fi_cache);
 
        *result = fsp;
        return NT_STATUS_OK;