git.samba.org
/
metze
/
samba
/
wip.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b313a6a
)
py_net: fix != None check
author
Douglas Bagnall
<douglas.bagnall@catalyst.net.nz>
Fri, 20 Apr 2018 12:37:15 +0000
(
00:37
+1200)
committer
Andrew Bartlett
<abartlet@samba.org>
Fri, 1 Feb 2019 02:36:17 +0000
(
03:36
+0100)
Py_None is not false in C, so this branch was always taken.
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/libnet/py_net.c
patch
|
blob
|
history
diff --git
a/source4/libnet/py_net.c
b/source4/libnet/py_net.c
index b50f7abfb96e1df02f981cc750344f778a6873b1..05afe3b9c48e0c74f324e0a0f16a635354cc832b 100644
(file)
--- a/
source4/libnet/py_net.c
+++ b/
source4/libnet/py_net.c
@@
-550,7
+550,7
@@
static PyObject *py_net_replicate_chunk(py_net_Object *self, PyObject *args, PyO
s->chunk.req5 = NULL;
s->chunk.req8 = NULL;
s->chunk.req10 = NULL;
- if (py_req) {
+ if (py_req
!= Py_None
) {
switch (req_level) {
case 0:
break;