lsa4: Fix Coverity ID 1499410
authorVolker Lendecke <vl@samba.org>
Wed, 15 Nov 2023 13:39:33 +0000 (14:39 +0100)
committerJeremy Allison <jra@samba.org>
Tue, 21 Nov 2023 17:34:36 +0000 (17:34 +0000)
It complains about uninitialized access, and I'm not sure it isn't
right. Just initialize the structure.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source4/rpc_server/lsa/lsa_init.c

index 87214fe335953bf1c729e99307a49e3a7418522a..575bc6fc76392e96f8334001576325f98b632e0e 100644 (file)
@@ -344,10 +344,11 @@ NTSTATUS dcesrv_lsa_OpenPolicy(struct dcesrv_call_state *dce_call, TALLOC_CTX *m
                DCESRV_FAULT(DCERPC_FAULT_ACCESS_DENIED);
        }
 
-       r2.in.system_name = NULL;
-       r2.in.attr = r->in.attr;
-       r2.in.access_mask = r->in.access_mask;
-       r2.out.handle = r->out.handle;
+       r2 = (struct lsa_OpenPolicy2) {
+               .in.attr = r->in.attr,
+               .in.access_mask = r->in.access_mask,
+               .out.handle = r->out.handle,
+       };
 
        return dcesrv_lsa_OpenPolicy2(dce_call, mem_ctx, &r2);
 }