memcpy(rec.dptr, header, sizeof(*header));
memcpy(rec.dptr + sizeof(*header), data.dptr, data.dsize);
- ret = tdb_store(ctdb_db->ltdb->tdb, key, rec, TDB_REPLACE);
+ /* if this is a persistent database without NOSYNC then we
+ will do this via a transaction */
+ if (ctdb_db->persistent && !(ctdb_db->client_tdb_flags & TDB_NOSYNC)) {
+ ret = tdb_transaction_start(ctdb_db->ltdb->tdb);
+ if (ret != 0) {
+ DEBUG(DEBUG_CRIT, ("Failed to start local transaction\n"));
+ goto failed;
+ }
+ ret = tdb_store(ctdb_db->ltdb->tdb, key, rec, TDB_REPLACE);
+ if (ret != 0) {
+ tdb_transaction_cancel(ctdb_db->ltdb->tdb);
+ goto failed;
+ }
+ ret = tdb_transaction_commit(ctdb_db->ltdb->tdb);
+ } else {
+ ret = tdb_store(ctdb_db->ltdb->tdb, key, rec, TDB_REPLACE);
+ }
+
+failed:
talloc_free(rec.dptr);
return ret;
struct ctdb_registered_call *calls; /* list of registered calls */
uint32_t seqnum;
struct timed_event *te;
+ uint32_t client_tdb_flags;
};
void *private_data);
int32_t ctdb_control_db_attach(struct ctdb_context *ctdb, TDB_DATA indata,
- TDB_DATA *outdata, bool persistent);
+ TDB_DATA *outdata, uint64_t tdb_flags, bool persistent);
int ctdb_daemon_set_call(struct ctdb_context *ctdb, uint32_t db_id,
ctdb_fn_t fn, int id);
}
case CTDB_CONTROL_DB_ATTACH:
- return ctdb_control_db_attach(ctdb, indata, outdata, false);
+ return ctdb_control_db_attach(ctdb, indata, outdata, srvid, false);
case CTDB_CONTROL_DB_ATTACH_PERSISTENT:
- return ctdb_control_db_attach(ctdb, indata, outdata, true);
+ return ctdb_control_db_attach(ctdb, indata, outdata, srvid, true);
case CTDB_CONTROL_SET_CALL: {
struct ctdb_control_set_call *sc =
a client has asked to attach a new database
*/
int32_t ctdb_control_db_attach(struct ctdb_context *ctdb, TDB_DATA indata,
- TDB_DATA *outdata, bool persistent)
+ TDB_DATA *outdata, uint64_t tdb_flags,
+ bool persistent)
{
const char *db_name = (const char *)indata.dptr;
struct ctdb_db_context *db;
struct ctdb_node *node = ctdb->nodes[ctdb->pnn];
+ /* the client can optionally pass additional tdb flags, but we
+ only allow a subset of those on the database in ctdb. Note
+ that tdb_flags is passed in via the (otherwise unused)
+ srvid to the attach control */
+ tdb_flags &= TDB_NOSYNC;
+
/* If the node is inactive it is not part of the cluster
and we should not allow clients to attach to any
databases
if (db) {
outdata->dptr = (uint8_t *)&db->db_id;
outdata->dsize = sizeof(db->db_id);
+ db->client_tdb_flags |= tdb_flags;
return 0;
}
return -1;
}
+ /* remember the flags the client has specified */
+ db->client_tdb_flags = tdb_flags;
+
outdata->dptr = (uint8_t *)&db->db_id;
outdata->dsize = sizeof(db->db_id);