Volker Lendecke [Sun, 8 Aug 2010 12:03:52 +0000 (14:03 +0200)]
s3: Lift the smbd_messaging_context from enum_all_printers_info_1_local
Volker Lendecke [Sun, 8 Aug 2010 12:02:52 +0000 (14:02 +0200)]
s3: Lift the smbd_messaging_context from enum_all_printers_info_1
Volker Lendecke [Sun, 8 Aug 2010 09:01:58 +0000 (11:01 +0200)]
s3: Lift the smbd_messaging_context from enumprinters_level0
Volker Lendecke [Sun, 8 Aug 2010 09:00:22 +0000 (11:00 +0200)]
s3: Lift the smbd_messaging_context from enum_all_printers_info_level
Volker Lendecke [Sun, 8 Aug 2010 08:58:04 +0000 (10:58 +0200)]
s3: Lift the smbd_messaging_context from construct_printer_info0
Volker Lendecke [Sun, 8 Aug 2010 08:56:50 +0000 (10:56 +0200)]
s3: Lift the smbd_messaging_context from set_printer_hnd_name
Volker Lendecke [Sun, 8 Aug 2010 08:55:41 +0000 (10:55 +0200)]
s3: Lift the smbd_messaging_context from winreg_del_driver_list
Volker Lendecke [Sun, 8 Aug 2010 08:54:01 +0000 (10:54 +0200)]
s3: Lift the smbd_messaging_context from winreg_del_driver
Volker Lendecke [Sun, 8 Aug 2010 08:52:19 +0000 (10:52 +0200)]
s3: Lift the smbd_messaging_context from winreg_get_driver
Volker Lendecke [Sun, 8 Aug 2010 08:47:35 +0000 (10:47 +0200)]
s3: Lift the smbd_messaging_context from winreg_add_driver
Volker Lendecke [Sun, 8 Aug 2010 08:46:00 +0000 (10:46 +0200)]
s3: Lift the smbd_messaging_context from winreg_printer_getform1
Volker Lendecke [Sun, 8 Aug 2010 08:44:13 +0000 (10:44 +0200)]
s3: Lift the smbd_messaging_context from winreg_printer_setform1
Volker Lendecke [Sun, 8 Aug 2010 08:41:54 +0000 (10:41 +0200)]
s3: Lift the smbd_messaging_context from winreg_printer_deleteform1
Volker Lendecke [Sun, 8 Aug 2010 08:39:42 +0000 (10:39 +0200)]
s3: Lift the smbd_messaging_context from winreg_printer_enumforms1
Volker Lendecke [Sun, 8 Aug 2010 08:37:43 +0000 (10:37 +0200)]
s3: Lift the smbd_messaging_context from winreg_printer_addform1
Volker Lendecke [Sun, 8 Aug 2010 08:35:57 +0000 (10:35 +0200)]
s3: Lift the smbd_messaging_context from winreg_printer_get_changeid
Volker Lendecke [Sun, 8 Aug 2010 08:34:00 +0000 (10:34 +0200)]
s3: Lift the smbd_messaging_context from winreg_printer_update_changeid
Volker Lendecke [Sun, 8 Aug 2010 08:29:50 +0000 (10:29 +0200)]
s3: Lift the smbd_messaging_context from winreg_delete_printer_key
Volker Lendecke [Sun, 8 Aug 2010 08:27:40 +0000 (10:27 +0200)]
s3: Lift the smbd_messaging_context from winreg_enum_printer_key
Volker Lendecke [Sun, 8 Aug 2010 08:25:54 +0000 (10:25 +0200)]
s3: Lift the smbd_messaging_context from winreg_delete_printer_dataex
Volker Lendecke [Sun, 8 Aug 2010 08:23:49 +0000 (10:23 +0200)]
s3: Lift the smbd_messaging_context from winreg_enum_printer_dataex
Volker Lendecke [Sun, 8 Aug 2010 08:22:11 +0000 (10:22 +0200)]
s3: Lift the smbd_messaging_context from winreg_get_printer_dataex
Volker Lendecke [Sun, 8 Aug 2010 08:19:35 +0000 (10:19 +0200)]
s3: Lift the smbd_messaging_context from winreg_set_printer_dataex
Volker Lendecke [Sun, 8 Aug 2010 08:14:31 +0000 (10:14 +0200)]
s3: Lift the smbd_messaging_context from winreg_set_printer_secdesc
Volker Lendecke [Sun, 8 Aug 2010 08:11:00 +0000 (10:11 +0200)]
s3: Lift the smbd_messaging_context from winreg_get_printer_secdesc
Volker Lendecke [Sun, 8 Aug 2010 08:08:22 +0000 (10:08 +0200)]
s3: Lift the smbd_messaging_context from winreg_get_printer
Volker Lendecke [Sun, 8 Aug 2010 07:37:43 +0000 (09:37 +0200)]
s3: Lift the smbd_messaging_context from winreg_update_printer
Volker Lendecke [Sun, 8 Aug 2010 07:34:23 +0000 (09:34 +0200)]
s3: Lift the smbd_messaging_context from winreg_create_printer
Volker Lendecke [Sun, 8 Aug 2010 07:32:12 +0000 (09:32 +0200)]
s3: Lift the smbd_messaging_context from winreg_printer_opendriver
Volker Lendecke [Sun, 8 Aug 2010 07:30:30 +0000 (09:30 +0200)]
s3: Lift the smbd_messaging_context from winreg_printer_openkey
Volker Lendecke [Sun, 8 Aug 2010 07:27:04 +0000 (09:27 +0200)]
s3: Lift the smbd_messaging_context from nt_printing_tdb_migrate
Volker Lendecke [Sun, 8 Aug 2010 07:22:05 +0000 (09:22 +0200)]
s3: Lift the smbd_messaging_context from rpc_pipe_open_internal
Volker Lendecke [Sun, 8 Aug 2010 07:11:45 +0000 (09:11 +0200)]
s3: Lift the smbd_messaging_context from np_open
Volker Lendecke [Sun, 8 Aug 2010 07:08:40 +0000 (09:08 +0200)]
s3: Lift the smbd_messaging_context from make_internal_rpc_pipe_p
Volker Lendecke [Sun, 8 Aug 2010 06:47:05 +0000 (08:47 +0200)]
s3: Remove a direct reference to smbd_server_conn
Volker Lendecke [Sat, 7 Aug 2010 16:39:38 +0000 (18:39 +0200)]
s3: Remove references to smbd_messaging_context()
Volker Lendecke [Sun, 8 Aug 2010 08:14:01 +0000 (10:14 +0200)]
s3: Fix a type-punned warning
Stefan Metzmacher [Thu, 5 Aug 2010 15:19:16 +0000 (17:19 +0200)]
librpc/idl/mgmt.idl: add missing size_is()
metze
Stefan Metzmacher [Thu, 5 Aug 2010 14:10:37 +0000 (16:10 +0200)]
pidl:NDR: correctly handle bracket arrays with 'string'
metze
Stefan Metzmacher [Fri, 6 Aug 2010 12:52:58 +0000 (14:52 +0200)]
s3:rpcclient: we also need some ndr_pull functions
metze
Stefan Metzmacher [Fri, 6 Aug 2010 12:51:54 +0000 (14:51 +0200)]
s3:libnet/libnet_samsync.c: we also need some ndr_pull functions
metze
Stefan Metzmacher [Fri, 6 Aug 2010 12:50:31 +0000 (14:50 +0200)]
s3:utils/net_rpc_service.c: we also need some ndr_pull functions
metze
Stefan Metzmacher [Sun, 8 Aug 2010 08:15:12 +0000 (10:15 +0200)]
s4:RPC-SPOOLSS-NOTIFY: skip test_RFFPCNEx() for now, as the test is broken
See https://bugzilla.samba.org/show_bug.cgi?id=7486.
metze
Stefan Metzmacher [Sun, 8 Aug 2010 07:23:00 +0000 (09:23 +0200)]
s3:rpc_server: fix valgrind warning
metze
Stefan Metzmacher [Sun, 8 Aug 2010 07:21:57 +0000 (09:21 +0200)]
s3:smbd: fix valgrind warning, sizeof(16) != 16...
metze
Stefan Metzmacher [Sat, 7 Aug 2010 12:27:27 +0000 (14:27 +0200)]
s3:rpc_server: fix memory leaks in rpc_pipe_internal_dispatch()
metze
Volker Lendecke [Sat, 7 Aug 2010 16:27:36 +0000 (18:27 +0200)]
s3: Fix typos
Stefan Metzmacher [Sat, 7 Aug 2010 16:15:01 +0000 (18:15 +0200)]
s4:rpc_server/lsa: better include a .h file don't include a .c file
This fixes the build with --nonshared-binary=smbtorture,
as use by the source3/ make test.
metze
Volker Lendecke [Sat, 7 Aug 2010 11:23:07 +0000 (13:23 +0200)]
s3: Remove some references to smbd_messaging_context()
Matthias Dieter Wallnöfer [Sat, 7 Aug 2010 11:32:52 +0000 (13:32 +0200)]
s4:kcc_connection.c - fix typo in error message
Matthias Dieter Wallnöfer [Sat, 7 Aug 2010 10:30:33 +0000 (12:30 +0200)]
s4:ldap.py - comment a test part which fails with another error code on Windows
Matthias Dieter Wallnöfer [Sat, 7 Aug 2010 09:59:57 +0000 (11:59 +0200)]
s4:ldap.py - test the new "systemFlags" constraint
Matthias Dieter Wallnöfer [Sat, 7 Aug 2010 09:50:10 +0000 (11:50 +0200)]
s4:objectclass LDB module - "add operation" - enhance and clean the "systemFlags" section
Also here we have to test for single-valueness.
Matthias Dieter Wallnöfer [Sat, 7 Aug 2010 09:07:03 +0000 (11:07 +0200)]
s4:ldap.py - test for an invalid "objectCategory" attribute
Matthias Dieter Wallnöfer [Sat, 7 Aug 2010 09:04:53 +0000 (11:04 +0200)]
s4:objectclass LDB module - "add operation" - implement "objectCategory" validation
Matthias Dieter Wallnöfer [Thu, 5 Aug 2010 20:23:22 +0000 (22:23 +0200)]
s4:ldap.py - proof for the impossibility to add a LSA-specific object over LDAP
Matthias Dieter Wallnöfer [Thu, 5 Aug 2010 20:22:57 +0000 (22:22 +0200)]
s4:urgent_replication.py - relax also here the add of a secrets object
Matthias Dieter Wallnöfer [Thu, 5 Aug 2010 20:00:27 +0000 (22:00 +0200)]
s3:dcesrv_lsa.c - use the RELAX control in order to create LSA objects
Matthias Dieter Wallnöfer [Thu, 5 Aug 2010 19:58:57 +0000 (21:58 +0200)]
s4:dsdb/common/util.c - add a function "dsdb_add"
Matthias Dieter Wallnöfer [Thu, 5 Aug 2010 19:40:11 +0000 (21:40 +0200)]
s4:objectclass LDB module - "add operation" - reject creation of LSA specific objects
(only using the RELAX flag allowed)
Matthias Dieter Wallnöfer [Thu, 5 Aug 2010 19:02:29 +0000 (21:02 +0200)]
s4:objectclass LDB module - "add operation" - move two checks
To be more consistent with the MS-ADTS doc.
Matthias Dieter Wallnöfer [Thu, 5 Aug 2010 19:01:38 +0000 (21:01 +0200)]
s4:objectclass LDB module - "add operation" - deny multiple "objectclass" message elements
Requested by MS-ADTS 3.1.1.5.2.2
Matthias Dieter Wallnöfer [Thu, 5 Aug 2010 18:59:56 +0000 (20:59 +0200)]
s4:objectclass LDB module - "add" operation - free "mem_ctx" as soon as possible
We don't need to have it around until the end of the function.
Volker Lendecke [Sat, 7 Aug 2010 10:35:54 +0000 (12:35 +0200)]
s3: Remove references to smbd_messaging_context() from the spoolss server
Volker Lendecke [Sat, 7 Aug 2010 10:27:22 +0000 (12:27 +0200)]
s3: Remove a reference to smbd_messaging_context()
Volker Lendecke [Sat, 7 Aug 2010 09:58:48 +0000 (11:58 +0200)]
s3: Remove some references to smbd_messaging_context()
Volker Lendecke [Thu, 8 Jul 2010 16:00:07 +0000 (18:00 +0200)]
s3: Remove procid_self() from connections_fetch_entry()
Volker Lendecke [Tue, 6 Jul 2010 20:52:19 +0000 (22:52 +0200)]
s3: Add msg_ctx to pipes_struct
Volker Lendecke [Tue, 6 Jul 2010 20:43:14 +0000 (22:43 +0200)]
s3: Remove smbd_messaging_context() from send_stat_cache_delete_message()
Andrew Bartlett [Sat, 7 Aug 2010 08:56:35 +0000 (18:56 +1000)]
s4:ntlmssp Merge more aspects of the source3/ NTLMSSP layer
This changes the talloc treatment of the session keys to avoid
memory duplication - the session key has always been allocated
onto the ntlmssp_context by the auth subsystem callback.
The remainder of the changes are cosmetics, such as avoiding
using lm_session_key as a pointer (and avoiding then doing an
if statement on something that is always true).
Andrew Bartlett
Andrew Bartlett [Fri, 6 Aug 2010 07:53:44 +0000 (17:53 +1000)]
s4:ntlmssp Re-add gensec_ntlmssp wrapper to allow merge with source3/
By re-adding this wrapper, the actual guts of these functions are now very
similar to that found in source3/libsmb/ntlmssp.c
This should make it easier to merge the implementations.
Andrew Bartlett
Andrew Bartlett [Fri, 6 Aug 2010 07:51:34 +0000 (17:51 +1000)]
s4:ntlmssp Always setup the session keys and signing state
While it would save some CPU to only setup the session key when
requested (like windows does), this instead matches the
implementation in source3/libsmb/ntlmssp.c
We could re-add this later after the codebase is merged.
Andrew Bartlett
Volker Lendecke [Sat, 7 Aug 2010 08:29:43 +0000 (10:29 +0200)]
s3: Remove a pointless "else"
Volker Lendecke [Fri, 6 Aug 2010 21:27:36 +0000 (23:27 +0200)]
s3: Remove an unnecessary NULL check
Now that connections.tdb is not used for the broadcast messaging anymore,
connections_fetch_entry is only called for real connections.
Günther Deschner [Fri, 6 Aug 2010 15:38:15 +0000 (17:38 +0200)]
s3-net: fix copy/paste typo in usage of "net printing".
Guenther
Günther Deschner [Thu, 5 Aug 2010 13:14:04 +0000 (15:14 +0200)]
s3-netlogon: remove global include of netlogon.h.
This reduces precompiled headers by another 4 MB and also slightly speeds up the
build.
Guenther
Günther Deschner [Thu, 5 Aug 2010 13:03:00 +0000 (15:03 +0200)]
s3: remove global include of samr.h
Guenther
Günther Deschner [Wed, 4 Aug 2010 10:01:50 +0000 (12:01 +0200)]
s3-build: no need to include privileges.h twice.
Guenther
Günther Deschner [Mon, 2 Aug 2010 22:03:03 +0000 (00:03 +0200)]
s3-net: only include netapi header when needed.
Guenther
Günther Deschner [Mon, 2 Aug 2010 21:21:09 +0000 (23:21 +0200)]
s3-libsmb: include nbt.h in namequery_dc code.
Guenther
Günther Deschner [Mon, 2 Aug 2010 21:18:53 +0000 (23:18 +0200)]
s3-libnet: include netlogon.h in libnet samsync header.
Guenther
Günther Deschner [Thu, 5 Aug 2010 13:25:35 +0000 (15:25 +0200)]
s3-smbtorture: include svcctl.h
Guenther
Günther Deschner [Mon, 2 Aug 2010 21:17:25 +0000 (23:17 +0200)]
s3-services: include svcctl.h where needed.
Guenther
Günther Deschner [Thu, 5 Aug 2010 13:02:09 +0000 (15:02 +0200)]
s3-build: remove global include of krb5pac.h.
Put in samr and netlogon, as they were pulled in via krb5pac.h.
Guenther
Günther Deschner [Mon, 2 Aug 2010 21:12:16 +0000 (23:12 +0200)]
s3-krb5: include krb5pac.h where needed.
Guenther
Günther Deschner [Mon, 2 Aug 2010 20:54:29 +0000 (22:54 +0200)]
s3-rap: include svcctl.h where needed.
Guenther
Günther Deschner [Mon, 2 Aug 2010 20:52:00 +0000 (22:52 +0200)]
s3-passdb: include samr.h where needed.
Guenther
Günther Deschner [Mon, 2 Aug 2010 21:23:12 +0000 (23:23 +0200)]
s3-param: include svcctl headers in loadparm.
Guenther
Günther Deschner [Mon, 2 Aug 2010 20:48:16 +0000 (22:48 +0200)]
s3-nmbd: include svcctl.h where needed.
Guenther
Volker Lendecke [Mon, 19 Jul 2010 19:00:41 +0000 (21:00 +0200)]
s3: Remove some explicit calls to procid_self()
Volker Lendecke [Mon, 19 Jul 2010 19:04:04 +0000 (21:04 +0200)]
s3: Remove some explicit calls to procid_self()
Andreas Schneider [Fri, 6 Aug 2010 11:49:37 +0000 (13:49 +0200)]
s3-spoolss: Make sure we convert a 4 byte value to uint32_t.
Andreas Schneider [Fri, 6 Aug 2010 11:49:01 +0000 (13:49 +0200)]
s3-spoolss: Fixed setting driver version correctly.
We are in a loop here, so setting tmp to 0 at the beginning of each
iteration sets info8->version to 0 if we enumerate over another value.
Stefan Metzmacher [Thu, 5 Aug 2010 08:04:57 +0000 (10:04 +0200)]
pidl: Samba3/ClientNDR - Correctly copy arrays, if r.out.size < r.in.size.
metze
Signed-off-by: Andreas Schneider <asn@samba.org>
Volker Lendecke [Fri, 6 Aug 2010 10:32:30 +0000 (12:32 +0200)]
s3: fail db_open_ctdb if ctdb is not around
Andrew Tridgell [Fri, 6 Aug 2010 03:06:42 +0000 (13:06 +1000)]
s3-printing: cope with missing printers in print migration
The printers database may be completely missing in a new install, and
we may have SECDESC entries for printers that have been removed. Don't
consider these fatal errors in the migration.
Signed-off-by: Günther Deschner <gd@samba.org>
Andrew Bartlett [Fri, 6 Aug 2010 06:14:11 +0000 (16:14 +1000)]
s4:ntlmssp Adjust Samba4 ntlmssp code to look more like the code in Samba3.
This does not change behaviour, and some of the whitespace isn't ideal, but
at the moment making this code more similar, even in cosmetics, will assist
later merge efforts.
Andrew Bartlett
Andreas Schneider [Thu, 5 Aug 2010 14:05:31 +0000 (16:05 +0200)]
s3-torture: Improve the winreg deletekey torture comments.
Andreas Schneider [Thu, 5 Aug 2010 13:35:52 +0000 (15:35 +0200)]
s3-torture: Correctly cleanup the winreg volatile key test.
Günther please check!
Andreas Schneider [Thu, 5 Aug 2010 13:24:20 +0000 (15:24 +0200)]
s4-torture: Fixed the winreg EnumValue test against Windows.
Günther please check!