libcli: Avoid a talloc/free

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

diff --git a/libcli/security/security_token.c b/libcli/security/security_token.c
index 40f13820eecd6c41e6f0f4d0a6db87583069ce4a..95a09b33783a6a26c34d18700c09a7b2425867e5 100644 (file)
--- a/libcli/security/security_token.c
+++ b/libcli/security/security_token.c
@@ -84,12 +84,14 @@ bool security_token_is_sid(const struct security_token *token, const struct dom_
 bool security_token_is_sid_string(const struct security_token *token, const char *sid_string)
 {
        bool ret;
-       struct dom_sid *sid = dom_sid_parse_talloc(NULL, sid_string);
-       if (!sid) return false;
+       struct dom_sid sid;
 
-       ret = security_token_is_sid(token, sid);
+       ret = dom_sid_parse(sid_string, &sid);
+       if (!ret) {
+               return false;
+       }
 
-       talloc_free(sid);
+       ret = security_token_is_sid(token, &sid);
        return ret;
 }