Remove use of the "staticforward" macro

This macro was used for compatibility with broken compilers.
Since Python 2.3, it is always defined as `static`, and only exists
"for source compatibility with old C extensions".

Signed-off-by: Petr Viktorin <pviktori@redhat.com>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/lib/ldb-samba/pyldb.c b/lib/ldb-samba/pyldb.c
index aae25a01e6806d6f2921d5a3b5dd56f04e55a53f..6c0d2a76b2efb9a63b0e5d908e14a63505240bd6 100644 (file)
--- a/lib/ldb-samba/pyldb.c
+++ b/lib/ldb-samba/pyldb.c
@@ -33,7 +33,7 @@ void init_ldb(void);
 
 static PyObject *pyldb_module;
 static PyObject *py_ldb_error;
-staticforward PyTypeObject PySambaLdb;
+static PyTypeObject PySambaLdb;
 
 static void PyErr_SetLdbError(PyObject *error, int ret, struct ldb_context *ldb_ctx)
 {

diff --git a/lib/ldb/pyldb.c b/lib/ldb/pyldb.c
index ee751b363e08bdc857e9b052f652e3b6a6abb8d5..5bcff72a2117876fae240aae2603d9608673548b 100644 (file)
--- a/lib/ldb/pyldb.c
+++ b/lib/ldb/pyldb.c
@@ -36,16 +36,16 @@ void initldb(void);
 static PyObject *PyLdbMessage_FromMessage(struct ldb_message *msg);
 static PyObject *PyExc_LdbError;
 
-staticforward PyTypeObject PyLdbControl;
-staticforward PyTypeObject PyLdbResult;
-staticforward PyTypeObject PyLdbMessage;
+static PyTypeObject PyLdbControl;
+static PyTypeObject PyLdbResult;
+static PyTypeObject PyLdbMessage;
 #define PyLdbMessage_Check(ob) PyObject_TypeCheck(ob, &PyLdbMessage)
-staticforward PyTypeObject PyLdbModule;
-staticforward PyTypeObject PyLdbDn;
+static PyTypeObject PyLdbModule;
+static PyTypeObject PyLdbDn;
 #define pyldb_Dn_Check(ob) PyObject_TypeCheck(ob, &PyLdbDn)
-staticforward PyTypeObject PyLdb;
+static PyTypeObject PyLdb;
 #define PyLdb_Check(ob) PyObject_TypeCheck(ob, &PyLdb)
-staticforward PyTypeObject PyLdbMessageElement;
+static PyTypeObject PyLdbMessageElement;
 #define pyldb_MessageElement_Check(ob) PyObject_TypeCheck(ob, &PyLdbMessageElement)
 
 staticforward PyTypeObject PyLdbTree;

diff --git a/lib/ntdb/pyntdb.c b/lib/ntdb/pyntdb.c
index b2a1f0cbc1b6844611d3130b0831191a55945618..72e626472a2859d6a992ab64e85d7b2b9c37370d 100644 (file)
--- a/lib/ntdb/pyntdb.c
+++ b/lib/ntdb/pyntdb.c
@@ -38,7 +38,7 @@ typedef struct {
        bool closed;
 } PyNtdbObject;
 
-staticforward PyTypeObject PyNtdb;
+static PyTypeObject PyNtdb;
 
 static void PyErr_SetTDBError(enum NTDB_ERROR e)
 {

diff --git a/lib/tevent/pytevent.c b/lib/tevent/pytevent.c
index 870f5aad6104bccfbde773f9c6b99463a1f8c8e1..af3f9d67df64f975deb6413363a38df92bd1b386 100644 (file)
--- a/lib/tevent/pytevent.c
+++ b/lib/tevent/pytevent.c
@@ -57,12 +57,12 @@ typedef struct {
        struct tevent_fd *fd;
 } TeventFd_Object;
 
-staticforward PyTypeObject TeventContext_Type;
-staticforward PyTypeObject TeventReq_Type;
-staticforward PyTypeObject TeventQueue_Type;
-staticforward PyTypeObject TeventSignal_Type;
-staticforward PyTypeObject TeventTimer_Type;
-staticforward PyTypeObject TeventFd_Type;
+static PyTypeObject TeventContext_Type;
+static PyTypeObject TeventReq_Type;
+static PyTypeObject TeventQueue_Type;
+static PyTypeObject TeventSignal_Type;
+static PyTypeObject TeventTimer_Type;
+static PyTypeObject TeventFd_Type;
 
 static int py_context_init(struct tevent_context *ev)
 {

diff --git a/pidl/lib/Parse/Pidl/Samba4/Python.pm b/pidl/lib/Parse/Pidl/Samba4/Python.pm
index 31cf63f366e84ebbf94deec8309108583419ceb7..920d10acadc50fea39ae3a4d5e40b1450859afa3 100644 (file)
--- a/pidl/lib/Parse/Pidl/Samba4/Python.pm
+++ b/pidl/lib/Parse/Pidl/Samba4/Python.pm
@@ -355,7 +355,7 @@ sub PythonStruct($$$$$$)
                $self->pidl("");
        }
 
-       $self->pidl_hdr("staticforward PyTypeObject $name\_Type;\n");
+       $self->pidl_hdr("static PyTypeObject $name\_Type;\n");
        $self->pidl("");
        my $docstring = $self->DocString($d, $name);
        my $typeobject = "$name\_Type";
@@ -691,7 +691,7 @@ sub Interface($$$)
        }
 
        if (defined $interface->{PROPERTIES}->{uuid}) {
-               $self->pidl_hdr("staticforward PyTypeObject $interface->{NAME}_InterfaceType;\n");
+               $self->pidl_hdr("static PyTypeObject $interface->{NAME}_InterfaceType;\n");
                $self->pidl("");
 
                my @fns = ();

diff --git a/source3/passdb/py_passdb.c b/source3/passdb/py_passdb.c
index 3a1e583f0f6894d2b7ddee62490f79a5979464c6..07540cd2fce54345fe5a1c3b419a2b87571855c2 100644 (file)
--- a/source3/passdb/py_passdb.c
+++ b/source3/passdb/py_passdb.c
@@ -51,9 +51,9 @@ static PyTypeObject *dom_sid_Type = NULL;
 static PyTypeObject *security_Type = NULL;
 static PyTypeObject *guid_Type = NULL;
 
-staticforward PyTypeObject PySamu;
-staticforward PyTypeObject PyGroupmap;
-staticforward PyTypeObject PyPDB;
+static PyTypeObject PySamu;
+static PyTypeObject PyGroupmap;
+static PyTypeObject PyPDB;
 
 static PyObject *py_pdb_error;
 

diff --git a/source4/libcli/pysmb.c b/source4/libcli/pysmb.c
index 456b01d87d2f592742eca36fa083c1c423067c04..dde37e0467fa3a81182544f73f7fb041d66cb504 100644 (file)
--- a/source4/libcli/pysmb.c
+++ b/source4/libcli/pysmb.c
@@ -38,7 +38,7 @@
 #include "libcli/security/security_descriptor.h"
 #include "librpc/rpc/pyrpc_util.h"
 
-staticforward PyTypeObject PySMB;
+static PyTypeObject PySMB;
 
 void initsmb(void);
 

diff --git a/source4/librpc/rpc/pyrpc.c b/source4/librpc/rpc/pyrpc.c
index 360fb24224c5ad1d394fc16aecdfa9c03016d13e..09f663213b680ebb1fb63ac5f8d8c5e769f8f666 100644 (file)
--- a/source4/librpc/rpc/pyrpc.c
+++ b/source4/librpc/rpc/pyrpc.c
@@ -30,7 +30,7 @@
 
 void initbase(void);
 
-staticforward PyTypeObject dcerpc_InterfaceType;
+static PyTypeObject dcerpc_InterfaceType;
 
 static PyTypeObject *ndr_syntax_id_Type;