Günther Deschner [Thu, 30 Apr 2009 21:36:24 +0000 (23:36 +0200)]
wkssvcs: add WKSSVC_JOIN_FLAGS_IGNORE_UNSUPPORTED_FLAGS join flag.
Guenther
Günther Deschner [Thu, 30 Apr 2009 14:49:50 +0000 (16:49 +0200)]
s3-printing: rework move_driver_file_to_download_area() a bit for clarity.
Guenther
Günther Deschner [Thu, 30 Apr 2009 10:30:10 +0000 (12:30 +0200)]
s3-lsa: use LSA_POLICY_MODE flags in _lsa_GetSystemAccessAccount().
Guenther
Günther Deschner [Thu, 30 Apr 2009 12:16:01 +0000 (14:16 +0200)]
s3-nss_wins: Fix unresolved ldb symbols in libnss_wins.so.
The objects for this module should probably be cleaned up once.
Guenther
Volker Lendecke [Thu, 30 Apr 2009 11:37:19 +0000 (13:37 +0200)]
Re-import the v3-3 version of str_list_make().
The merged version behaves differently: "Domain Users" is parsed into two
values, as it does not look at quotes. Samba3 users depend on the ability do
say for example
valid users = "domain users"
which would not work anymore with the merged version.
Thanks to Björn Jacke for testing this!
Volker
Volker Lendecke [Thu, 30 Apr 2009 10:24:51 +0000 (12:24 +0200)]
Fix notify_onelevel: notify is not necessarily enabled
Thanks to Günther Deschner!
Volker
Günther Deschner [Thu, 30 Apr 2009 09:19:42 +0000 (11:19 +0200)]
s3-spoolss: avoid referring to uid 0 in spoolss server (use sec_initial_uid() instead).
Guenther
Günther Deschner [Wed, 29 Apr 2009 23:25:23 +0000 (01:25 +0200)]
s3-printing: use move_driver_file_to_download_area() to avoid code duplication.
Guenther
Günther Deschner [Wed, 29 Apr 2009 23:07:31 +0000 (01:07 +0200)]
s3-printing: add move_driver_file_to_download_area().
Guenther
Jeremy Allison [Thu, 30 Apr 2009 01:26:02 +0000 (18:26 -0700)]
Make cli_unlink async.
Jeremy.
Jeremy Allison [Wed, 29 Apr 2009 17:48:16 +0000 (10:48 -0700)]
More async calls in libsmb/clifile.c
Jeremy.
Michael Adam [Wed, 29 Apr 2009 14:33:45 +0000 (16:33 +0200)]
s3:vfs: untangle logic for loading and probing modules in vfs_init_custom()
This is to be able to provide more specific error messages.
Michael
Günther Deschner [Wed, 29 Apr 2009 12:29:25 +0000 (14:29 +0200)]
s3-test: make it possible to find the built vlp in "make test".
Guenther
Karolin Seeger [Wed, 29 Apr 2009 12:12:01 +0000 (14:12 +0200)]
s3/docs: Fix serveral typos.
This fixes bug #4315.
Thanks to Felipe Augusto van de Wiel <faw [at] cathedrallabs [dot] org>!
Karolin
Karolin Seeger [Wed, 29 Apr 2009 10:38:28 +0000 (12:38 +0200)]
s3/docs: Remove documentation of "use kerberos keytab".
This parameter has been removed with
d96248a9b4655.
Karolin
Günther Deschner [Wed, 29 Apr 2009 09:46:43 +0000 (11:46 +0200)]
s3-docs: document "net eventlog" in net manpage.
Guenther
Günther Deschner [Wed, 29 Apr 2009 09:46:12 +0000 (11:46 +0200)]
s3-net: make "net eventlog" help output a little more appropriate.
Guenther
Bo Yang [Wed, 29 Apr 2009 01:50:41 +0000 (09:50 +0800)]
s3: fix crash in winbindd
Michael Adam [Tue, 28 Apr 2009 23:49:53 +0000 (01:49 +0200)]
s3:smbd/service: switch load_registry_service/shares to use loadparm routines
instead of reading the registry directly with tdb and activating the
configure options by hand.
This eliminates the need for repeating checks done in loadparm.
For instance it disables registry shares without path in the server
as is the case with text based shares.
Michael
Michael Adam [Tue, 28 Apr 2009 23:31:03 +0000 (01:31 +0200)]
s3:loadparm: refactor process_registry_service out or process_registry_globals
Michael
Günther Deschner [Tue, 28 Apr 2009 23:55:09 +0000 (01:55 +0200)]
samr: fix samr_ConnectVersion enum which is 32bit not 16bit.
Volker, please check.
Rafal, haven't we seen this in your tests at sambaxp as well ?
Guenther
Günther Deschner [Tue, 28 Apr 2009 23:49:26 +0000 (01:49 +0200)]
svcctl: Fix IDL for svcctl_StartServiceW().
Guenther
Jeremy Allison [Tue, 28 Apr 2009 23:45:13 +0000 (16:45 -0700)]
Doh ! Don't need "int dummy" when we have state :-).
Jeremy.
Jeremy Allison [Tue, 28 Apr 2009 23:43:16 +0000 (16:43 -0700)]
Convert cli_rename to async.
Jeremy.
Jeremy Allison [Tue, 28 Apr 2009 20:18:51 +0000 (13:18 -0700)]
Convert cli_posix_unlink() and cli_posix_rmdir()
to async. First trans calls I've done.
Jeremy.
Jeremy Allison [Tue, 28 Apr 2009 18:07:51 +0000 (11:07 -0700)]
Fix bug #6291 - force user stop working.
A previous fix broke the invariant that *uid is always
initialized on return from create_token_from_username().
Restore it.
Jeremy.
Volker Lendecke [Tue, 28 Apr 2009 13:33:21 +0000 (15:33 +0200)]
Fix a missing prototype warning
Günther Deschner [Tue, 28 Apr 2009 10:02:22 +0000 (12:02 +0200)]
s3-cldap: check for zero ip address in ads_cldap_netlogon().
Guenther
Volker Lendecke [Tue, 28 Apr 2009 10:24:26 +0000 (12:24 +0200)]
Fix Coverity ID 853 (UNINIT) -- Kai, please check!
Michael Adam [Tue, 28 Apr 2009 10:18:23 +0000 (12:18 +0200)]
pm_process():raise level of debug message
Michael
Michael Adam [Mon, 27 Apr 2009 16:10:14 +0000 (18:10 +0200)]
s3:loadparm: prevent infinite include nesting.
This introduces a hard coded MAX_INCLUDE_DEPTH of 100.
When this is exceeded, handle_include (and hence lp_load) fails.
One could of course implement a more intelligent loop detection
in the include-tree, but this would require some restructuring
of the internal loadparm housekeeping. Maybe as a second improvement
step.
Michael
Günther Deschner [Mon, 27 Apr 2009 12:39:02 +0000 (14:39 +0200)]
s3-net: make sure to call libnetapi init functions at the top of "net rpc" command.
Without the initialization "net rpc password" will prompt twice for passwords
and will not allow to define the name of the connection admin user.
In the long run we should probably only have one place where to initialize
libnetapi.
Kai, please check.
Guenther
Volker Lendecke [Tue, 28 Apr 2009 09:57:47 +0000 (11:57 +0200)]
Fix a type-punned warning
Michael Adam [Mon, 27 Apr 2009 23:24:27 +0000 (01:24 +0200)]
s3:mark registry shares without path unavailable just as with text config
This prevents users from getting access to "/" in misconfigured setups.
Michael
Volker Lendecke [Tue, 28 Apr 2009 09:16:19 +0000 (11:16 +0200)]
Fix annoying debug messages when no snapshots are used
Not being able to open the shadow copy directory is the same as having no
shadow copy support at all. The VFS module should in this case not log with
debug level 0 and set ENOSYS to indicate "no shadow copies used" to the higher
levels.
Günther Deschner [Mon, 27 Apr 2009 23:08:31 +0000 (01:08 +0200)]
s3-svcctl: Fix crash in _svcctl_EnumServicesStatusW().
The resume handle is a unique pointer, always check before dereference.
Guenther
Volker Lendecke [Wed, 22 Apr 2009 14:44:11 +0000 (16:44 +0200)]
Do not panic unnecessarily
Volker Lendecke [Thu, 23 Apr 2009 16:05:51 +0000 (18:05 +0200)]
Fix a type-punned warning
Günther Deschner [Mon, 27 Apr 2009 16:47:41 +0000 (18:47 +0200)]
s3-auth-charcnv: fix push_string(). Don't push to ucs2 and ascii after another.
This fixes all kinds of encrypted passwords used in the shared auth code naturally.
Andrew B., please check.
Guenther
Michael Adam [Mon, 27 Apr 2009 15:54:23 +0000 (17:54 +0200)]
s3:nt_printing: fix a comment typo
Michael
Derrell Lipman [Mon, 27 Apr 2009 13:27:52 +0000 (09:27 -0400)]
[FIX Bug 6235] domain enumeration breaks if master browser has space in name
Jeremy: please review to ensure this doesn't appear to break anything
The function name_status_find() is documented as used for finding a server's
name given its IP address. It was, however, looking for the first matching
name which could be a group name at times. This fix ensures that group names
are skipped when scanning for a matching name.
Derrell
Michael Adam [Mon, 27 Apr 2009 11:25:07 +0000 (13:25 +0200)]
s3:libsmbconf: fix a comment typo
Michael
Michael Adam [Mon, 23 Mar 2009 22:14:45 +0000 (23:14 +0100)]
s3:registry: replace typedef REGISTRY_OPS by struct registry_ops
Michael
Michael Adam [Mon, 23 Mar 2009 22:05:30 +0000 (23:05 +0100)]
s3:registry replace typedef REGISTRY_HOOK by struct registry_hook.
Michael
Michael Adam [Mon, 23 Mar 2009 22:02:57 +0000 (23:02 +0100)]
s3:registry: replace typedef REGISTRY_KEY by struct registry_key_handle
Michael
Michael Adam [Mon, 23 Mar 2009 22:18:26 +0000 (23:18 +0100)]
s3:registry: make a comment more precise.
Michael
Michael Adam [Mon, 23 Mar 2009 21:27:59 +0000 (22:27 +0100)]
s3:registry: replace typedef REGISTRY_VALUE by struct regval_blob
Michael
Michael Adam [Mon, 23 Mar 2009 17:14:17 +0000 (18:14 +0100)]
s3:registry: replace typedef REGVAL_CTR by struct regval_ctr.
This paves the way for hiding the typedef and the implementation
from the surface.
Michael
Michael Adam [Fri, 24 Oct 2008 11:49:16 +0000 (13:49 +0200)]
s3:net conf: support dangling parameters by specifying "" as the section name.
for {get,set,del}parm
Michael
Michael Adam [Mon, 27 Apr 2009 08:51:55 +0000 (10:51 +0200)]
s3:fix build of the pam_smbpass shared module
Michael
Stefan Metzmacher [Sat, 25 Apr 2009 04:14:40 +0000 (06:14 +0200)]
s4:selftest: don't run the smb2.durable.open test
it often crashes when the server doesn't support them.
metze
Stefan Metzmacher [Fri, 17 Apr 2009 17:59:25 +0000 (19:59 +0200)]
s4:RPC-ECHO: disable the timeout test as it can't work with our client library
We need proper ways to cancel requests in order to have that
test working against a correctly behaving server over ncacn_np.
metze
Stefan Metzmacher [Fri, 24 Apr 2009 13:36:00 +0000 (15:36 +0200)]
RAW-LOCK: samba4 behaves like windows 7 in regard of locking error codes
metze
Stefan Metzmacher [Fri, 24 Apr 2009 10:28:59 +0000 (12:28 +0200)]
s4:torture: use torture api instead of printf for RAW-LOCK
metze
Stefan Metzmacher [Fri, 24 Apr 2009 09:23:43 +0000 (11:23 +0200)]
s4:selftest: s4 doesn't support osxrename and directory rename yet
metze
Stefan Metzmacher [Fri, 24 Apr 2009 09:23:07 +0000 (11:23 +0200)]
s4:tortore: use torture api instead of printf in RAW-RENAME
metze
Jeremy Allison [Fri, 24 Apr 2009 14:06:48 +0000 (07:06 -0700)]
find/replace. Change uintX types to uintX_t types to tidy up the code.
Jeremy.
Günther Deschner [Tue, 3 Feb 2009 19:03:42 +0000 (20:03 +0100)]
s3-libnetjoin: make acct_flags dependent on secure channel type.
Guenther
Günther Deschner [Thu, 6 Nov 2008 11:26:24 +0000 (12:26 +0100)]
s3-libnetjoin: add support for WKSSVC_JOIN_FLAGS_JOIN_UNSECURE.
Guenther
Günther Deschner [Tue, 21 Apr 2009 14:18:51 +0000 (16:18 +0200)]
s3-svcctl: indicate that the spooler is already running if it does.
Guenther
Günther Deschner [Fri, 10 Apr 2009 19:39:45 +0000 (21:39 +0200)]
s3-svcctl: fix _svcctl_ControlService.
Guenther
Günther Deschner [Fri, 10 Apr 2009 19:10:07 +0000 (21:10 +0200)]
s4-smbtorture: add test_ControlService() to RPC-SVCCTL.
Guenther
Günther Deschner [Fri, 10 Apr 2009 18:55:10 +0000 (20:55 +0200)]
s4-smbtorture: add test_StartServiceW() to RPC-SVCCTL.
Guenther
Günther Deschner [Mon, 20 Apr 2009 14:49:01 +0000 (16:49 +0200)]
s4-smbtorture: change default service to spooler in RPC-SVCCTL.
Guenther
Günther Deschner [Fri, 24 Apr 2009 08:02:06 +0000 (10:02 +0200)]
s3-idmap: Fix bug #6286: Call init function for builtin idmap modules before probing for them as shared modules.
idmap-gurus of the world, please check.
Guenther
Günther Deschner [Thu, 23 Apr 2009 15:09:55 +0000 (17:09 +0200)]
s3-build: refactor LIBNET_OBJ.
Guenther
Günther Deschner [Fri, 24 Apr 2009 01:09:20 +0000 (03:09 +0200)]
s3-netlogon: Start fixing rpccli_netlogon_setup_creds after auth merge.
Guenther
Jelmer Vernooij [Fri, 24 Apr 2009 07:47:55 +0000 (09:47 +0200)]
Rename the top-level LDB test to LOCAL-LDB, so it gets picked up by the
script that determines the tests to run.
Andrew Bartlett [Fri, 24 Apr 2009 07:35:24 +0000 (09:35 +0200)]
s4:torture Fix segfault in RPC-SAMSYNC
This code needs to be fixed to match Win2008 behavior, but at least it
does not segfault any more.
Andrew Bartlett
Andrew Bartlett [Fri, 24 Apr 2009 07:17:29 +0000 (09:17 +0200)]
s4:torture Add tests for prefixMap custom attribute handler
Andrew Bartlett [Fri, 24 Apr 2009 07:17:08 +0000 (09:17 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Jelmer Vernooij [Thu, 23 Apr 2009 16:59:37 +0000 (18:59 +0200)]
Provide a ldb_global_init() function for compatibility with older versions of LDB
(including the one in Samba 3).
Andrew Bartlett [Thu, 23 Apr 2009 16:46:24 +0000 (18:46 +0200)]
More lcov code coverage generation work
Jelmer Vernooij [Thu, 23 Apr 2009 12:31:45 +0000 (14:31 +0200)]
samba3/ldb: Update the ldb_dn API to match that of the Samba 4 LDB:
* ldb_dn_new() now takes an initial DN string
* ldb_dn_string_compose() -> ldb_dn_new_fmt()
* dummy ldb_dn_validate(), since LDB DNs in the current implementation
are always valid if they could be created.
Jelmer Vernooij [Thu, 23 Apr 2009 12:27:59 +0000 (14:27 +0200)]
ldb/samba3: Support event context argument to ldb_init().
This argument is ignored (Samba3's LDB is synchronous) but having it
there is useful for API compatibility with the LDB used by Samba 4 and
available on some systems.
nadezhda ivanova [Thu, 23 Apr 2009 14:18:23 +0000 (17:18 +0300)]
Fix of a bug in the security.descriptor.as_sddl() method
security.descriptor.as_sddl() method did not work correctly when invoked without
supplying the domain sid. Returned the same value as when the sid was provided.
Test added for this case in libcli/security/tests/bindings.py
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Thu, 23 Apr 2009 15:53:25 +0000 (17:53 +0200)]
s4:torture use common libcli/auth crypto code
Jelmer Vernooij [Thu, 23 Apr 2009 15:46:54 +0000 (17:46 +0200)]
Fix push_codepoint function without iconv_convenience.
Jelmer Vernooij [Thu, 23 Apr 2009 14:03:19 +0000 (16:03 +0200)]
charcnv: Import push_codepoint().
Jelmer Vernooij [Thu, 23 Apr 2009 13:24:38 +0000 (15:24 +0200)]
Add a new non-convenience version of push_codepoint.
Andrew Bartlett [Thu, 23 Apr 2009 15:38:42 +0000 (17:38 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Sam Liddicott [Thu, 23 Apr 2009 12:47:59 +0000 (13:47 +0100)]
Add async support for reply_tcon* and ntvfs_connect
smbsrv_tcon_backend no longer creates the ntvfs_request wrapper,
so smbsrv_reply_tcon* can now do this and then invoke ntvfs_connect
in the typical manner using SMBSRV_SETUP_NTVFS_REQUEST and
SMBSRV_CALL_NTVFS_BACKEND
Previously smbsrv_tcon_backend has been responsible for instantiating
the ntvfs_module_context to service a tree-connect request, and
then create an ntvfs_request wrapper around the smbsrv_request
and pass this to ntvfs_connect for the newly created ntvfs.
These actions could not be invoked asynchronously.
This meant that any client requests made while instantiating the
ntvfs module, including any composite's used during authentication
(or related client connections for the case of proxy modules)
would block other ntvfs modules and requests in the current process as
they executed a nested event loop to await completion.
Signed-off-by: Sam Liddicott <sam@liddicott.com>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett [Thu, 23 Apr 2009 14:46:47 +0000 (16:46 +0200)]
s4:test Include 'source4' in directories to find lcov in
Volker Lendecke [Thu, 23 Apr 2009 14:17:18 +0000 (16:17 +0200)]
Add missing prototypes
Andrew Bartlett [Thu, 23 Apr 2009 13:12:35 +0000 (15:12 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba into abartlet-devel
Andrew Bartlett [Thu, 23 Apr 2009 13:11:04 +0000 (15:11 +0200)]
s4:test Fix 'make lcov' in Samba4
Volker Lendecke [Thu, 23 Apr 2009 12:54:52 +0000 (14:54 +0200)]
Revert "Do not use the file system GET_REAL_FILENAME for mangled names"
This reverts commit
b5b6ecb58aeba196c28370cde21a0826f81d8da6.
Volker Lendecke [Thu, 23 Apr 2009 12:24:16 +0000 (14:24 +0200)]
Fix a couple of warnings
Volker Lendecke [Thu, 23 Apr 2009 12:23:23 +0000 (14:23 +0200)]
Fix an uninitialized variable
Volker Lendecke [Thu, 23 Apr 2009 12:14:37 +0000 (14:14 +0200)]
Fix a type-punned warning
Volker Lendecke [Wed, 22 Apr 2009 09:54:13 +0000 (11:54 +0200)]
Fix a pointless static
Andrew Bartlett [Thu, 23 Apr 2009 10:19:10 +0000 (12:19 +0200)]
s4:samr Use ldb_context * rather than void *
Jeremy Allison [Thu, 23 Apr 2009 09:51:55 +0000 (02:51 -0700)]
Fix coverity #901 - uninitialized data.
Jeremy.
Volker Lendecke [Thu, 23 Apr 2009 09:05:49 +0000 (11:05 +0200)]
Fix Coverity ID 626: DEADCODE
Jeremy Allison [Thu, 23 Apr 2009 09:02:28 +0000 (02:02 -0700)]
Fix Coverity bug #902, uninitialized variable.
Jeremy.
Volker Lendecke [Thu, 23 Apr 2009 08:49:41 +0000 (10:49 +0200)]
Fix Coverity ID 628, Andrew B., please check!
Jeremy Allison [Thu, 23 Apr 2009 08:47:04 +0000 (01:47 -0700)]
Fix coverity #908, #909, uninitialized variable.
Jeremy.
Volker Lendecke [Thu, 23 Apr 2009 08:42:43 +0000 (10:42 +0200)]
Fix Coverity ID 884: DEADCODE
Jeremy Allison [Thu, 23 Apr 2009 08:38:21 +0000 (01:38 -0700)]
Fix coverity #910, uninitialized variable.
Jeremy.
Günther Deschner [Wed, 22 Apr 2009 21:48:24 +0000 (23:48 +0200)]
s3-selftest: test wbinfo --allocate-uid/gid.
Guenther