auth: Fix CID 1615191 Uninitialized scalar variable
[samba.git] / source3 / libsmb / clitrans.c
index 75afe5195ed8e7f842ffb4dc3f4e43adcd6d257b..2cd75d2a800baa140e2bcb0e6350ab7b1a73843d 100644 (file)
-/* 
+/*
    Unix SMB/CIFS implementation.
    client transaction calls
    Copyright (C) Andrew Tridgell 1994-1998
-   
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-#define NO_SYSLOG
-
 #include "includes.h"
-
-
-/****************************************************************************
- Send a SMB trans or trans2 request.
-****************************************************************************/
-
-BOOL cli_send_trans(struct cli_state *cli, int trans, 
-                   const char *pipe_name, 
-                   int fid, int flags,
-                   uint16 *setup, unsigned int lsetup, unsigned int msetup,
-                   const char *param, unsigned int lparam, unsigned int mparam,
-                   const char *data, unsigned int ldata, unsigned int mdata)
+#include "libsmb/libsmb.h"
+#include "../lib/util/tevent_ntstatus.h"
+#include "async_smb.h"
+#include "../libcli/smb/smbXcli_base.h"
+
+struct cli_trans_state {
+       struct cli_state *cli;
+       struct tevent_req *subreq;
+       uint16_t recv_flags2;
+       uint16_t *setup;
+       uint8_t num_setup;
+       uint8_t *param;
+       uint32_t num_param;
+       uint8_t *data;
+       uint32_t num_data;
+};
+
+static void cli_trans_done(struct tevent_req *subreq);
+static bool cli_trans_cancel(struct tevent_req *req);
+
+struct tevent_req *cli_trans_send(
+       TALLOC_CTX *mem_ctx, struct tevent_context *ev,
+       struct cli_state *cli, uint16_t additional_flags2, uint8_t cmd,
+       const char *pipe_name, uint16_t fid, uint16_t function, int flags,
+       uint16_t *setup, uint8_t num_setup, uint8_t max_setup,
+       uint8_t *param, uint32_t num_param, uint32_t max_param,
+       uint8_t *data, uint32_t num_data, uint32_t max_data)
 {
-       unsigned int i;
-       unsigned int this_ldata,this_lparam;
-       unsigned int tot_data=0,tot_param=0;
-       char *outdata,*outparam;
-       char *p;
-       int pipe_name_len=0;
-       uint16 mid;
-
-       this_lparam = MIN(lparam,cli->max_xmit - (500+lsetup*2)); /* hack */
-       this_ldata = MIN(ldata,cli->max_xmit - (500+lsetup*2+this_lparam));
-
-       memset(cli->outbuf,'\0',smb_size);
-       set_message(cli->outbuf,14+lsetup,0,True);
-       SCVAL(cli->outbuf,smb_com,trans);
-       SSVAL(cli->outbuf,smb_tid, cli->cnum);
-       cli_setup_packet(cli);
-
-       /*
-        * Save the mid we're using. We need this for finding
-        * signing replies.
-        */
-
-       mid = cli->mid;
-
-       if (pipe_name) {
-               pipe_name_len = clistr_push(cli, smb_buf(cli->outbuf), pipe_name, -1, STR_TERMINATE);
-       }
-
-       outparam = smb_buf(cli->outbuf)+(trans==SMBtrans ? pipe_name_len : 3);
-       outdata = outparam+this_lparam;
-
-       /* primary request */
-       SSVAL(cli->outbuf,smb_tpscnt,lparam);   /* tpscnt */
-       SSVAL(cli->outbuf,smb_tdscnt,ldata);    /* tdscnt */
-       SSVAL(cli->outbuf,smb_mprcnt,mparam);   /* mprcnt */
-       SSVAL(cli->outbuf,smb_mdrcnt,mdata);    /* mdrcnt */
-       SCVAL(cli->outbuf,smb_msrcnt,msetup);   /* msrcnt */
-       SSVAL(cli->outbuf,smb_flags,flags);     /* flags */
-       SIVAL(cli->outbuf,smb_timeout,0);               /* timeout */
-       SSVAL(cli->outbuf,smb_pscnt,this_lparam);       /* pscnt */
-       SSVAL(cli->outbuf,smb_psoff,smb_offset(outparam,cli->outbuf)); /* psoff */
-       SSVAL(cli->outbuf,smb_dscnt,this_ldata);        /* dscnt */
-       SSVAL(cli->outbuf,smb_dsoff,smb_offset(outdata,cli->outbuf)); /* dsoff */
-       SCVAL(cli->outbuf,smb_suwcnt,lsetup);   /* suwcnt */
-       for (i=0;i<lsetup;i++)          /* setup[] */
-               SSVAL(cli->outbuf,smb_setup+i*2,setup[i]);
-       p = smb_buf(cli->outbuf);
-       if (trans != SMBtrans) {
-               *p++ = 0;  /* put in a null smb_name */
-               *p++ = 'D'; *p++ = ' '; /* observed in OS/2 */
-       }
-       if (this_lparam)                        /* param[] */
-               memcpy(outparam,param,this_lparam);
-       if (this_ldata)                 /* data[] */
-               memcpy(outdata,data,this_ldata);
-       cli_setup_bcc(cli, outdata+this_ldata);
-
-       show_msg(cli->outbuf);
-
-       if (!cli_send_smb(cli)) {
-               return False;
-       }
-
-       if (this_ldata < ldata || this_lparam < lparam) {
-               /* receive interim response */
-               if (!cli_receive_smb(cli) || cli_is_error(cli)) {
-                       return(False);
-               }
-
-               tot_data = this_ldata;
-               tot_param = this_lparam;
-               
-               while (tot_data < ldata || tot_param < lparam)  {
-                       this_lparam = MIN(lparam-tot_param,cli->max_xmit - 500); /* hack */
-                       this_ldata = MIN(ldata-tot_data,cli->max_xmit - (500+this_lparam));
-
-                       set_message(cli->outbuf,trans==SMBtrans?8:9,0,True);
-                       SCVAL(cli->outbuf,smb_com,(trans==SMBtrans ? SMBtranss : SMBtranss2));
-                       
-                       outparam = smb_buf(cli->outbuf);
-                       outdata = outparam+this_lparam;
-                       
-                       /* secondary request */
-                       SSVAL(cli->outbuf,smb_tpscnt,lparam);   /* tpscnt */
-                       SSVAL(cli->outbuf,smb_tdscnt,ldata);    /* tdscnt */
-                       SSVAL(cli->outbuf,smb_spscnt,this_lparam);      /* pscnt */
-                       SSVAL(cli->outbuf,smb_spsoff,smb_offset(outparam,cli->outbuf)); /* psoff */
-                       SSVAL(cli->outbuf,smb_spsdisp,tot_param);       /* psdisp */
-                       SSVAL(cli->outbuf,smb_sdscnt,this_ldata);       /* dscnt */
-                       SSVAL(cli->outbuf,smb_sdsoff,smb_offset(outdata,cli->outbuf)); /* dsoff */
-                       SSVAL(cli->outbuf,smb_sdsdisp,tot_data);        /* dsdisp */
-                       if (trans==SMBtrans2)
-                               SSVALS(cli->outbuf,smb_sfid,fid);               /* fid */
-                       if (this_lparam)                        /* param[] */
-                               memcpy(outparam,param+tot_param,this_lparam);
-                       if (this_ldata)                 /* data[] */
-                               memcpy(outdata,data+tot_data,this_ldata);
-                       cli_setup_bcc(cli, outdata+this_ldata);
-                       
-                       /*
-                        * Save the mid we're using. We need this for finding
-                        * signing replies.
-                        */
-                       mid = cli->mid;
-
-                       show_msg(cli->outbuf);
-                       if (!cli_send_smb(cli)) {
-                               return False;
-                       }
-
-                       /* Ensure we use the same mid for the secondaries. */
-                       cli->mid = mid;
-                       
-                       tot_data += this_ldata;
-                       tot_param += this_lparam;
-               }
-       }
-
-       /* Note we're in a trans state. Save the sequence
-        * numbers for replies. */
-
-       cli_signing_trans_start(cli, mid);
-       return(True);
+       struct tevent_req *req;
+       struct cli_trans_state *state;
+       uint8_t additional_flags = 0;
+       uint8_t clear_flags = 0;
+       uint16_t clear_flags2 = 0;
+
+       req = tevent_req_create(mem_ctx, &state, struct cli_trans_state);
+       if (req == NULL) {
+               return NULL;
+       }
+       state->cli = cli;
+
+       state->subreq = smb1cli_trans_send(state, ev,
+                                          cli->conn, cmd,
+                                          additional_flags, clear_flags,
+                                          additional_flags2, clear_flags2,
+                                          cli->timeout,
+                                          cli->smb1.pid,
+                                          cli->smb1.tcon,
+                                          cli->smb1.session,
+                                          pipe_name, fid, function, flags,
+                                          setup, num_setup, max_setup,
+                                          param, num_param, max_param,
+                                          data, num_data, max_data);
+       if (tevent_req_nomem(state->subreq, req)) {
+               return tevent_req_post(req, ev);
+       }
+       tevent_req_set_callback(state->subreq, cli_trans_done, req);
+       tevent_req_set_cancel_fn(req, cli_trans_cancel);
+       return req;
 }
 
-/****************************************************************************
- Receive a SMB trans or trans2 response allocating the necessary memory.
-****************************************************************************/
-
-BOOL cli_receive_trans(struct cli_state *cli,int trans,
-                              char **param, unsigned int *param_len,
-                              char **data, unsigned int *data_len)
+static bool cli_trans_cancel(struct tevent_req *req)
 {
-       unsigned int total_data=0;
-       unsigned int total_param=0;
-       unsigned int this_data,this_param;
-       NTSTATUS status;
-       char *tdata;
-       char *tparam;
-
-       *data_len = *param_len = 0;
-
-       if (!cli_receive_smb(cli)) {
-               cli_signing_trans_stop(cli);
-               return False;
-       }
-
-       show_msg(cli->inbuf);
-       
-       /* sanity check */
-       if (CVAL(cli->inbuf,smb_com) != trans) {
-               DEBUG(0,("Expected %s response, got command 0x%02x\n",
-                        trans==SMBtrans?"SMBtrans":"SMBtrans2", 
-                        CVAL(cli->inbuf,smb_com)));
-               cli_signing_trans_stop(cli);
-               return(False);
-       }
-
-       /*
-        * An NT RPC pipe call can return ERRDOS, ERRmoredata
-        * to a trans call. This is not an error and should not
-        * be treated as such. Note that STATUS_NO_MORE_FILES is
-        * returned when a trans2 findfirst/next finishes.
-        */
-       status = cli_nt_error(cli);
-       
-       if (NT_STATUS_IS_ERR(status) || NT_STATUS_EQUAL(status,STATUS_NO_MORE_FILES)) {
-               cli_signing_trans_stop(cli);
-               return False;
-       }
-
-       /* parse out the lengths */
-       total_data = SVAL(cli->inbuf,smb_tdrcnt);
-       total_param = SVAL(cli->inbuf,smb_tprcnt);
-
-       /* allocate it */
-       if (total_data!=0) {
-               tdata = SMB_REALLOC(*data,total_data);
-               if (!tdata) {
-                       DEBUG(0,("cli_receive_trans: failed to enlarge data buffer\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               }
-               else
-                       *data = tdata;
-       }
-
-       if (total_param!=0) {
-               tparam = SMB_REALLOC(*param,total_param);
-               if (!tparam) {
-                       DEBUG(0,("cli_receive_trans: failed to enlarge param buffer\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               }
-               else
-                       *param = tparam;
-       }
-
-       for (;;)  {
-               this_data = SVAL(cli->inbuf,smb_drcnt);
-               this_param = SVAL(cli->inbuf,smb_prcnt);
-
-               if (this_data + *data_len > total_data ||
-                   this_param + *param_len > total_param) {
-                       DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               }
-
-               if (this_data + *data_len < this_data ||
-                               this_data + *data_len < *data_len ||
-                               this_param + *param_len < this_param ||
-                               this_param + *param_len < *param_len) {
-                       DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               }
+       struct cli_trans_state *state = tevent_req_data(
+               req, struct cli_trans_state);
+       bool ok;
 
-               if (this_data) {
-                       unsigned int data_offset_out = SVAL(cli->inbuf,smb_drdisp);
-                       unsigned int data_offset_in = SVAL(cli->inbuf,smb_droff);
-
-                       if (data_offset_out > total_data ||
-                                       data_offset_out + this_data > total_data ||
-                                       data_offset_out + this_data < data_offset_out ||
-                                       data_offset_out + this_data < this_data) {
-                               DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
-                       }
-                       if (data_offset_in > cli->bufsize ||
-                                       data_offset_in + this_data >  cli->bufsize ||
-                                       data_offset_in + this_data < data_offset_in ||
-                                       data_offset_in + this_data < this_data) {
-                               DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
-                       }
-
-                       memcpy(*data + data_offset_out, smb_base(cli->inbuf) + data_offset_in, this_data);
-               }
-               if (this_param) {
-                       unsigned int param_offset_out = SVAL(cli->inbuf,smb_prdisp);
-                       unsigned int param_offset_in = SVAL(cli->inbuf,smb_proff);
-
-                       if (param_offset_out > total_param ||
-                                       param_offset_out + this_param > total_param ||
-                                       param_offset_out + this_param < param_offset_out ||
-                                       param_offset_out + this_param < this_param) {
-                               DEBUG(1,("Param overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
-                       }
-                       if (param_offset_in > cli->bufsize ||
-                                       param_offset_in + this_param >  cli->bufsize ||
-                                       param_offset_in + this_param < param_offset_in ||
-                                       param_offset_in + this_param < this_param) {
-                               DEBUG(1,("Param overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
-                       }
-
-                       memcpy(*param + param_offset_out, smb_base(cli->inbuf) + param_offset_in, this_param);
-               }
-               *data_len += this_data;
-               *param_len += this_param;
-
-               if (total_data <= *data_len && total_param <= *param_len)
-                       break;
-               
-               if (!cli_receive_smb(cli)) {
-                       cli_signing_trans_stop(cli);
-                       return False;   
-               }
-
-               show_msg(cli->inbuf);
-               
-               /* sanity check */
-               if (CVAL(cli->inbuf,smb_com) != trans) {
-                       DEBUG(0,("Expected %s response, got command 0x%02x\n",
-                                trans==SMBtrans?"SMBtrans":"SMBtrans2", 
-                                CVAL(cli->inbuf,smb_com)));
-                       cli_signing_trans_stop(cli);
-                       return(False);
-               }
-               if (NT_STATUS_IS_ERR(cli_nt_error(cli))) {
-                       cli_signing_trans_stop(cli);
-                       return(False);
-               }
-
-               /* parse out the total lengths again - they can shrink! */
-               if (SVAL(cli->inbuf,smb_tdrcnt) < total_data)
-                       total_data = SVAL(cli->inbuf,smb_tdrcnt);
-               if (SVAL(cli->inbuf,smb_tprcnt) < total_param)
-                       total_param = SVAL(cli->inbuf,smb_tprcnt);
-               
-               if (total_data <= *data_len && total_param <= *param_len)
-                       break;
-               
-       }
-       
-       cli_signing_trans_stop(cli);
-       return(True);
+       ok = tevent_req_cancel(state->subreq);
+       return ok;
 }
 
-/****************************************************************************
- Send a SMB nttrans request.
-****************************************************************************/
-
-BOOL cli_send_nt_trans(struct cli_state *cli, 
-                      int function, 
-                      int flags,
-                      uint16 *setup, unsigned int lsetup, unsigned int msetup,
-                      char *param, unsigned int lparam, unsigned int mparam,
-                      char *data, unsigned int ldata, unsigned int mdata)
+static void cli_trans_done(struct tevent_req *subreq)
 {
-       unsigned int i;
-       unsigned int this_ldata,this_lparam;
-       unsigned int tot_data=0,tot_param=0;
-       uint16 mid;
-       char *outdata,*outparam;
-
-       this_lparam = MIN(lparam,cli->max_xmit - (500+lsetup*2)); /* hack */
-       this_ldata = MIN(ldata,cli->max_xmit - (500+lsetup*2+this_lparam));
-
-       memset(cli->outbuf,'\0',smb_size);
-       set_message(cli->outbuf,19+lsetup,0,True);
-       SCVAL(cli->outbuf,smb_com,SMBnttrans);
-       SSVAL(cli->outbuf,smb_tid, cli->cnum);
-       cli_setup_packet(cli);
-
-       /*
-        * Save the mid we're using. We need this for finding
-        * signing replies.
-        */
-
-       mid = cli->mid;
-
-       outparam = smb_buf(cli->outbuf)+3;
-       outdata = outparam+this_lparam;
-
-       /* primary request */
-       SCVAL(cli->outbuf,smb_nt_MaxSetupCount,msetup);
-       SCVAL(cli->outbuf,smb_nt_Flags,flags);
-       SIVAL(cli->outbuf,smb_nt_TotalParameterCount, lparam);
-       SIVAL(cli->outbuf,smb_nt_TotalDataCount, ldata);
-       SIVAL(cli->outbuf,smb_nt_MaxParameterCount, mparam);
-       SIVAL(cli->outbuf,smb_nt_MaxDataCount, mdata);
-       SIVAL(cli->outbuf,smb_nt_ParameterCount, this_lparam);
-       SIVAL(cli->outbuf,smb_nt_ParameterOffset, smb_offset(outparam,cli->outbuf));
-       SIVAL(cli->outbuf,smb_nt_DataCount, this_ldata);
-       SIVAL(cli->outbuf,smb_nt_DataOffset, smb_offset(outdata,cli->outbuf));
-       SIVAL(cli->outbuf,smb_nt_SetupCount, lsetup);
-       SIVAL(cli->outbuf,smb_nt_Function, function);
-       for (i=0;i<lsetup;i++)          /* setup[] */
-               SSVAL(cli->outbuf,smb_nt_SetupStart+i*2,setup[i]);
-       
-       if (this_lparam)                        /* param[] */
-               memcpy(outparam,param,this_lparam);
-       if (this_ldata)                 /* data[] */
-               memcpy(outdata,data,this_ldata);
-
-       cli_setup_bcc(cli, outdata+this_ldata);
-
-       show_msg(cli->outbuf);
-       if (!cli_send_smb(cli)) {
-               return False;
-       }       
-
-       if (this_ldata < ldata || this_lparam < lparam) {
-               /* receive interim response */
-               if (!cli_receive_smb(cli) || cli_is_error(cli)) {
-                       return(False);
-               }
-
-               tot_data = this_ldata;
-               tot_param = this_lparam;
-               
-               while (tot_data < ldata || tot_param < lparam)  {
-                       this_lparam = MIN(lparam-tot_param,cli->max_xmit - 500); /* hack */
-                       this_ldata = MIN(ldata-tot_data,cli->max_xmit - (500+this_lparam));
-
-                       set_message(cli->outbuf,18,0,True);
-                       SCVAL(cli->outbuf,smb_com,SMBnttranss);
-
-                       /* XXX - these should probably be aligned */
-                       outparam = smb_buf(cli->outbuf);
-                       outdata = outparam+this_lparam;
-                       
-                       /* secondary request */
-                       SIVAL(cli->outbuf,smb_nts_TotalParameterCount,lparam);
-                       SIVAL(cli->outbuf,smb_nts_TotalDataCount,ldata);
-                       SIVAL(cli->outbuf,smb_nts_ParameterCount,this_lparam);
-                       SIVAL(cli->outbuf,smb_nts_ParameterOffset,smb_offset(outparam,cli->outbuf));
-                       SIVAL(cli->outbuf,smb_nts_ParameterDisplacement,tot_param);
-                       SIVAL(cli->outbuf,smb_nts_DataCount,this_ldata);
-                       SIVAL(cli->outbuf,smb_nts_DataOffset,smb_offset(outdata,cli->outbuf));
-                       SIVAL(cli->outbuf,smb_nts_DataDisplacement,tot_data);
-                       if (this_lparam)                        /* param[] */
-                               memcpy(outparam,param+tot_param,this_lparam);
-                       if (this_ldata)                 /* data[] */
-                               memcpy(outdata,data+tot_data,this_ldata);
-                       cli_setup_bcc(cli, outdata+this_ldata);
-                       
-                       /*
-                        * Save the mid we're using. We need this for finding
-                        * signing replies.
-                        */
-                       mid = cli->mid;
-
-                       show_msg(cli->outbuf);
-
-                       if (!cli_send_smb(cli)) {
-                               return False;
-                       }
-                       
-                       /* Ensure we use the same mid for the secondaries. */
-                       cli->mid = mid;
-                       
-                       tot_data += this_ldata;
-                       tot_param += this_lparam;
-               }
-       }
-
-       /* Note we're in a trans state. Save the sequence
-        * numbers for replies. */
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct cli_trans_state *state = tevent_req_data(
+               req, struct cli_trans_state);
+       NTSTATUS status;
 
-       cli_signing_trans_start(cli, mid);
-       return(True);
+       status = smb1cli_trans_recv(
+               subreq,
+               state,
+               &state->recv_flags2,
+               &state->setup, 0, &state->num_setup,
+               &state->param, 0, &state->num_param,
+               &state->data, 0, &state->num_data);
+       TALLOC_FREE(subreq);
+       if (tevent_req_nterror(req, status)) {
+               return;
+       }
+       tevent_req_done(req);
 }
 
-/****************************************************************************
-  receive a SMB nttrans response allocating the necessary memory
-  ****************************************************************************/
-
-BOOL cli_receive_nt_trans(struct cli_state *cli,
-                         char **param, unsigned int *param_len,
-                         char **data, unsigned int *data_len)
+NTSTATUS cli_trans_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
+                       uint16_t *recv_flags2,
+                       uint16_t **setup, uint8_t min_setup,
+                       uint8_t *num_setup,
+                       uint8_t **param, uint32_t min_param,
+                       uint32_t *num_param,
+                       uint8_t **data, uint32_t min_data,
+                       uint32_t *num_data)
 {
-       unsigned int total_data=0;
-       unsigned int total_param=0;
-       unsigned int this_data,this_param;
-       uint8 eclass;
-       uint32 ecode;
-       char *tdata;
-       char *tparam;
-
-       *data_len = *param_len = 0;
+       struct cli_trans_state *state = tevent_req_data(
+               req, struct cli_trans_state);
+       NTSTATUS status = NT_STATUS_OK;
+       bool map_dos_errors = true;
 
-       if (!cli_receive_smb(cli)) {
-               cli_signing_trans_stop(cli);
-               return False;
+       if (tevent_req_is_nterror(req, &status)) {
+               goto map_error;
        }
 
-       show_msg(cli->inbuf);
-       
-       /* sanity check */
-       if (CVAL(cli->inbuf,smb_com) != SMBnttrans) {
-               DEBUG(0,("Expected SMBnttrans response, got command 0x%02x\n",
-                        CVAL(cli->inbuf,smb_com)));
-               cli_signing_trans_stop(cli);
-               return(False);
+       if ((state->num_setup < min_setup) ||
+           (state->num_param < min_param) ||
+           (state->num_data < min_data)) {
+               return NT_STATUS_INVALID_NETWORK_RESPONSE;
        }
 
-       /*
-        * An NT RPC pipe call can return ERRDOS, ERRmoredata
-        * to a trans call. This is not an error and should not
-        * be treated as such.
-        */
-       if (cli_is_dos_error(cli)) {
-                cli_dos_error(cli, &eclass, &ecode);
-               if (cli->pipes[cli->pipe_idx].fnum == 0 || !(eclass == ERRDOS && ecode == ERRmoredata)) {
-                       cli_signing_trans_stop(cli);
-                       return(False);
-               }
+       if (recv_flags2 != NULL) {
+               *recv_flags2 = state->recv_flags2;
        }
-
-       /*
-        * Likewise for NT_STATUS_BUFFER_TOO_SMALL
-        */
-       if (cli_is_nt_error(cli)) {
-               if (!NT_STATUS_EQUAL(cli_nt_error(cli),
-                                    NT_STATUS_BUFFER_TOO_SMALL)) {
-                       cli_signing_trans_stop(cli);
-                       return(False);
-               }
+       if (setup != NULL) {
+               *setup = talloc_move(mem_ctx, &state->setup);
+               *num_setup = state->num_setup;
        }
-
-       /* parse out the lengths */
-       total_data = SVAL(cli->inbuf,smb_ntr_TotalDataCount);
-       total_param = SVAL(cli->inbuf,smb_ntr_TotalParameterCount);
-
-       /* allocate it */
-       if (total_data) {
-               tdata = SMB_REALLOC(*data,total_data);
-               if (!tdata) {
-                       DEBUG(0,("cli_receive_nt_trans: failed to enlarge data buffer to %d\n",total_data));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               } else {
-                       *data = tdata;
-               }
+       if (param != NULL) {
+               *param = talloc_move(mem_ctx, &state->param);
+               *num_param = state->num_param;
        }
-
-       if (total_param) {
-               tparam = SMB_REALLOC(*param,total_param);
-               if (!tparam) {
-                       DEBUG(0,("cli_receive_nt_trans: failed to enlarge param buffer to %d\n", total_param));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               } else {
-                       *param = tparam;
-               }
+       if (data != NULL) {
+               *data = talloc_move(mem_ctx, &state->data);
+               *num_data = state->num_data;
        }
 
-       while (1)  {
-               this_data = SVAL(cli->inbuf,smb_ntr_DataCount);
-               this_param = SVAL(cli->inbuf,smb_ntr_ParameterCount);
-
-               if (this_data + *data_len > total_data ||
-                   this_param + *param_len > total_param) {
-                       DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               }
+map_error:
+       map_dos_errors = state->cli->map_dos_errors;
 
-               if (this_data + *data_len < this_data ||
-                               this_data + *data_len < *data_len ||
-                               this_param + *param_len < this_param ||
-                               this_param + *param_len < *param_len) {
-                       DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               }
-
-               if (this_data) {
-                       unsigned int data_offset_out = SVAL(cli->inbuf,smb_ntr_DataDisplacement);
-                       unsigned int data_offset_in = SVAL(cli->inbuf,smb_ntr_DataOffset);
-
-                       if (data_offset_out > total_data ||
-                                       data_offset_out + this_data > total_data ||
-                                       data_offset_out + this_data < data_offset_out ||
-                                       data_offset_out + this_data < this_data) {
-                               DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
-                       }
-                       if (data_offset_in > cli->bufsize ||
-                                       data_offset_in + this_data >  cli->bufsize ||
-                                       data_offset_in + this_data < data_offset_in ||
-                                       data_offset_in + this_data < this_data) {
-                               DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
-                       }
-
-                       memcpy(*data + data_offset_out, smb_base(cli->inbuf) + data_offset_in, this_data);
-               }
-
-               if (this_param) {
-                       unsigned int param_offset_out = SVAL(cli->inbuf,smb_ntr_ParameterDisplacement);
-                       unsigned int param_offset_in = SVAL(cli->inbuf,smb_ntr_ParameterOffset);
-
-                       if (param_offset_out > total_param ||
-                                       param_offset_out + this_param > total_param ||
-                                       param_offset_out + this_param < param_offset_out ||
-                                       param_offset_out + this_param < this_param) {
-                               DEBUG(1,("Param overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
-                       }
-                       if (param_offset_in > cli->bufsize ||
-                                       param_offset_in + this_param >  cli->bufsize ||
-                                       param_offset_in + this_param < param_offset_in ||
-                                       param_offset_in + this_param < this_param) {
-                               DEBUG(1,("Param overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
-                       }
-
-                       memcpy(*param + param_offset_out, smb_base(cli->inbuf) + param_offset_in, this_param);
-               }
-
-               *data_len += this_data;
-               *param_len += this_param;
+       if (NT_STATUS_IS_DOS(status) && map_dos_errors) {
+               uint8_t eclass = NT_STATUS_DOS_CLASS(status);
+               uint16_t ecode = NT_STATUS_DOS_CODE(status);
+               /*
+                * TODO: is it really a good idea to do a mapping here?
+                *
+                * The old cli_pull_error() also does it, so I do not change
+                * the behavior yet.
+                */
+               status = dos_to_ntstatus(eclass, ecode);
+       }
 
-               if (total_data <= *data_len && total_param <= *param_len)
-                       break;
-               
-               if (!cli_receive_smb(cli)) {
-                       cli_signing_trans_stop(cli);
-                       return False;
-               }
+       return status;
+}
 
-               show_msg(cli->inbuf);
-               
-               /* sanity check */
-               if (CVAL(cli->inbuf,smb_com) != SMBnttrans) {
-                       DEBUG(0,("Expected SMBnttrans response, got command 0x%02x\n",
-                                CVAL(cli->inbuf,smb_com)));
-                       cli_signing_trans_stop(cli);
-                       return(False);
-               }
-               if (cli_is_dos_error(cli)) {
-                        cli_dos_error(cli, &eclass, &ecode);
-                       if(cli->pipes[cli->pipe_idx].fnum == 0 || !(eclass == ERRDOS && ecode == ERRmoredata)) {
-                               cli_signing_trans_stop(cli);
-                               return(False);
-                       }
-               }
-               /* parse out the total lengths again - they can shrink! */
-               if (SVAL(cli->inbuf,smb_ntr_TotalDataCount) < total_data)
-                       total_data = SVAL(cli->inbuf,smb_ntr_TotalDataCount);
-               if (SVAL(cli->inbuf,smb_ntr_TotalParameterCount) < total_param)
-                       total_param = SVAL(cli->inbuf,smb_ntr_TotalParameterCount);
-               
-               if (total_data <= *data_len && total_param <= *param_len)
-                       break;
-       }
-       
-       cli_signing_trans_stop(cli);
-       return(True);
+NTSTATUS cli_trans(TALLOC_CTX *mem_ctx, struct cli_state *cli,
+                  uint8_t trans_cmd,
+                  const char *pipe_name, uint16_t fid, uint16_t function,
+                  int flags,
+                  uint16_t *setup, uint8_t num_setup, uint8_t max_setup,
+                  uint8_t *param, uint32_t num_param, uint32_t max_param,
+                  uint8_t *data, uint32_t num_data, uint32_t max_data,
+                  uint16_t *recv_flags2,
+                  uint16_t **rsetup, uint8_t min_rsetup, uint8_t *num_rsetup,
+                  uint8_t **rparam, uint32_t min_rparam, uint32_t *num_rparam,
+                  uint8_t **rdata, uint32_t min_rdata, uint32_t *num_rdata)
+{
+       TALLOC_CTX *frame = talloc_stackframe();
+       struct tevent_context *ev;
+       struct tevent_req *req;
+       NTSTATUS status = NT_STATUS_NO_MEMORY;
+
+       if (smbXcli_conn_has_async_calls(cli->conn)) {
+               /*
+                * Can't use sync call while an async call is in flight
+                */
+               status = NT_STATUS_INVALID_PARAMETER;
+               goto fail;
+       }
+       ev = samba_tevent_context_init(frame);
+       if (ev == NULL) {
+               goto fail;
+       }
+       req = cli_trans_send(
+               frame,          /* mem_ctx */
+               ev,             /* ev */
+               cli,            /* cli */
+               0,              /* additional_flags2 */
+               trans_cmd,      /* cmd */
+               pipe_name, fid, function, flags,
+               setup, num_setup, max_setup,
+               param, num_param, max_param,
+               data, num_data, max_data);
+       if (req == NULL) {
+               goto fail;
+       }
+       if (!tevent_req_poll_ntstatus(req, ev, &status)) {
+               goto fail;
+       }
+       status = cli_trans_recv(
+               req, mem_ctx, recv_flags2,
+               rsetup, min_rsetup, num_rsetup,
+               rparam, min_rparam, num_rparam,
+               rdata, min_rdata, num_rdata);
+fail:
+       TALLOC_FREE(frame);
+       return status;
 }