ctdb-daemon: Avoid signed/unsigned comparison by casting
authorMartin Schwenke <martin@meltin.net>
Thu, 1 Aug 2019 00:58:42 +0000 (10:58 +1000)
committerAmitay Isaacs <amitay@samba.org>
Wed, 14 Aug 2019 10:29:59 +0000 (10:29 +0000)
Compiling with -Wsign-compare complains:

 1047 |  &&  (call->call_id == CTDB_FETCH_WITH_HEADER_FUNC)) {
      |                     ^~

struct ctdb_call is a protocol element, so we can't simply change it.

Found by csbuild.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Wed Aug 14 10:29:59 UTC 2019 on sn-devel-184

ctdb/server/ctdb_call.c

index 876ae448cca6315868f69b08d8ad1bf840c407c6..9e1c51bf57dd2814fe6e9d73a6e282464de1c7e4 100644 (file)
@@ -1044,7 +1044,7 @@ void ctdb_request_call(struct ctdb_context *ctdb, struct ctdb_req_header *hdr)
                }
        }
        if ((c->flags & CTDB_WANT_READONLY) 
-       &&  (call->call_id == CTDB_FETCH_WITH_HEADER_FUNC)) {
+       &&  ((unsigned int)call->call_id == CTDB_FETCH_WITH_HEADER_FUNC)) {
                TDB_DATA tdata;
 
                tdata = tdb_fetch(ctdb_db->rottdb, call->key);