mm/memcontrol: Replace the PREEMPT_RT conditionals
authorThomas Gleixner <tglx@linutronix.de>
Thu, 25 Aug 2022 16:41:28 +0000 (18:41 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 19 Sep 2022 12:35:08 +0000 (14:35 +0200)
Use VM_WARN_ON_IRQS_ENABLED() and preempt_disable/enable_nested() to
replace the CONFIG_PREEMPT_RT #ifdeffery.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Acked-by: Michal Hocko <mhocko@suse.com>
Link: https://lore.kernel.org/r/20220825164131.402717-6-bigeasy@linutronix.de
mm/memcontrol.c

index b69979c9ced5c26d0bd238e0e090ce3851daa321..d35b6fa560f0a8b4752cda30721e09fe4d5b93db 100644 (file)
@@ -597,25 +597,18 @@ static u64 flush_next_time;
  */
 static void memcg_stats_lock(void)
 {
-#ifdef CONFIG_PREEMPT_RT
-      preempt_disable();
-#else
-      VM_BUG_ON(!irqs_disabled());
-#endif
+       preempt_disable_nested();
+       VM_WARN_ON_IRQS_ENABLED();
 }
 
 static void __memcg_stats_lock(void)
 {
-#ifdef CONFIG_PREEMPT_RT
-      preempt_disable();
-#endif
+       preempt_disable_nested();
 }
 
 static void memcg_stats_unlock(void)
 {
-#ifdef CONFIG_PREEMPT_RT
-      preempt_enable();
-#endif
+       preempt_enable_nested();
 }
 
 static inline void memcg_rstat_updated(struct mem_cgroup *memcg, int val)
@@ -715,7 +708,7 @@ void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx,
         * interrupt context while other caller need to have disabled interrupt.
         */
        __memcg_stats_lock();
-       if (IS_ENABLED(CONFIG_DEBUG_VM) && !IS_ENABLED(CONFIG_PREEMPT_RT)) {
+       if (IS_ENABLED(CONFIG_DEBUG_VM)) {
                switch (idx) {
                case NR_ANON_MAPPED:
                case NR_FILE_MAPPED:
@@ -725,7 +718,7 @@ void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx,
                        WARN_ON_ONCE(!in_task());
                        break;
                default:
-                       WARN_ON_ONCE(!irqs_disabled());
+                       VM_WARN_ON_IRQS_ENABLED();
                }
        }