Revert "HID: core: Do not call request_module() in async context"
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Wed, 5 Jun 2019 12:44:06 +0000 (14:44 +0200)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Wed, 5 Jun 2019 13:16:19 +0000 (15:16 +0200)
This reverts commit 4ceabaf7909d109db6afbffc4ed182741fc32043.

This patch and a025a18fe are giving extended timeouts
on boot for at least Ubuntu and openSUSE.

Revert them until we get a better fix.

Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/hid-core.c

index 4407cf549908b3440fd97728deab8119ed265140..aeae545859d4c903c0b6d5e7f731c2ad32c2de86 100644 (file)
@@ -30,7 +30,6 @@
 #include <linux/vmalloc.h>
 #include <linux/sched.h>
 #include <linux/semaphore.h>
-#include <linux/async.h>
 
 #include <linux/hid.h>
 #include <linux/hiddev.h>
@@ -2370,9 +2369,8 @@ int hid_add_device(struct hid_device *hdev)
         * not first have hid-generic binding only to have it replaced
         * immediately afterwards with a specialized driver.
         */
-       if (!current_is_async())
-               request_module("hid:b%04Xg%04Xv%08Xp%08X", hdev->bus,
-                              hdev->group, hdev->vendor, hdev->product);
+       request_module("hid:b%04Xg%04Xv%08Xp%08X",
+                      hdev->bus, hdev->group, hdev->vendor, hdev->product);
 
        hid_debug_register(hdev, dev_name(&hdev->dev));
        ret = device_add(&hdev->dev);