efi_test: get rid of pointless access_ok()
authorAl Viro <viro@zeniv.linux.org.uk>
Thu, 23 Apr 2020 03:02:16 +0000 (23:02 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 29 May 2020 15:05:54 +0000 (11:05 -0400)
really, people - get_user(), copy_from_user(), memdup_user(), etc.
all fail if access_ok() does.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/firmware/efi/test/efi_test.c

index 7baf48c01e72f2f63e65e802609059da9cdb12ee..ddf9eae396fe1c9f3333c0c2431ec161cb8c5767 100644 (file)
@@ -70,9 +70,6 @@ copy_ucs2_from_user_len(efi_char16_t **dst, efi_char16_t __user *src,
                return 0;
        }
 
-       if (!access_ok(src, 1))
-               return -EFAULT;
-
        buf = memdup_user(src, len);
        if (IS_ERR(buf)) {
                *dst = NULL;
@@ -91,9 +88,6 @@ copy_ucs2_from_user_len(efi_char16_t **dst, efi_char16_t __user *src,
 static inline int
 get_ucs2_strsize_from_user(efi_char16_t __user *src, size_t *len)
 {
-       if (!access_ok(src, 1))
-               return -EFAULT;
-
        *len = user_ucs2_strsize(src);
        if (*len == 0)
                return -EFAULT;
@@ -118,9 +112,6 @@ copy_ucs2_from_user(efi_char16_t **dst, efi_char16_t __user *src)
 {
        size_t len;
 
-       if (!access_ok(src, 1))
-               return -EFAULT;
-
        len = user_ucs2_strsize(src);
        if (len == 0)
                return -EFAULT;
@@ -142,9 +133,6 @@ copy_ucs2_to_user_len(efi_char16_t __user *dst, efi_char16_t *src, size_t len)
        if (!src)
                return 0;
 
-       if (!access_ok(dst, 1))
-               return -EFAULT;
-
        return copy_to_user(dst, src, len);
 }