drm/radeon/r600: Fix variables that are not used after assignment
authorTian Tao <tiantao6@hisilicon.com>
Thu, 8 Apr 2021 12:13:31 +0000 (20:13 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Apr 2021 20:55:08 +0000 (16:55 -0400)
err was not used after being assigned -EINVAL and was given a new value,
so here add goto to handle the error case.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/radeon/r600.c

index a0459b168d538c95ecf2fbd226b6fc8528d8a5ff..7444dc0e0c0e25ed09745ca9850cf0d253ddec62 100644 (file)
@@ -2569,6 +2569,7 @@ int r600_init_microcode(struct radeon_device *rdev)
                pr_err("r600_cp: Bogus length %zu in firmware \"%s\"\n",
                       rdev->me_fw->size, fw_name);
                err = -EINVAL;
+               goto out;
        }
 
        snprintf(fw_name, sizeof(fw_name), "radeon/%s_rlc.bin", rlc_chip_name);
@@ -2579,6 +2580,7 @@ int r600_init_microcode(struct radeon_device *rdev)
                pr_err("r600_rlc: Bogus length %zu in firmware \"%s\"\n",
                       rdev->rlc_fw->size, fw_name);
                err = -EINVAL;
+               goto out;
        }
 
        if ((rdev->family >= CHIP_RV770) && (rdev->family <= CHIP_HEMLOCK)) {