thermal: intel_powerclamp: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Jun 2019 18:38:10 +0000 (20:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Jun 2019 11:40:25 +0000 (13:40 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Finn Thain <fthain@telegraphics.com.au>
Cc: linux-pm@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thermal/intel/intel_powerclamp.c

index ac7256b5f020519608a0ec3bd4a2cb8fd652e489..39c6b589f2ed1d5e58fb74d95b7a8a22e0077584 100644 (file)
@@ -713,17 +713,9 @@ DEFINE_SHOW_ATTRIBUTE(powerclamp_debug);
 static inline void powerclamp_create_debug_files(void)
 {
        debug_dir = debugfs_create_dir("intel_powerclamp", NULL);
-       if (!debug_dir)
-               return;
-
-       if (!debugfs_create_file("powerclamp_calib", S_IRUGO, debug_dir,
-                                       cal_data, &powerclamp_debug_fops))
-               goto file_error;
 
-       return;
-
-file_error:
-       debugfs_remove_recursive(debug_dir);
+       debugfs_create_file("powerclamp_calib", S_IRUGO, debug_dir, cal_data,
+                           &powerclamp_debug_fops);
 }
 
 static enum cpuhp_state hp_state;