KVM: debugfs: Reuse binary stats descriptors
authorJing Zhang <jingzhangos@google.com>
Wed, 23 Jun 2021 21:28:46 +0000 (17:28 -0400)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 24 Jun 2021 22:00:29 +0000 (18:00 -0400)
To remove code duplication, use the binary stats descriptors in the
implementation of the debugfs interface for statistics. This unifies
the definition of statistics for the binary and debugfs interfaces.

Signed-off-by: Jing Zhang <jingzhangos@google.com>
Message-Id: <20210618222709.1858088-8-jingzhangos@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/arm64/kvm/guest.c
arch/mips/kvm/mips.c
arch/powerpc/kvm/book3s.c
arch/powerpc/kvm/booke.c
arch/s390/kvm/kvm-s390.c
arch/x86/kvm/x86.c
include/linux/kvm_host.h
virt/kvm/kvm_main.c

index f1dc2092d3a0b63a8a24500f153948951fbd95a3..1512a8007a786389807fffd66ccc5066041a9583 100644 (file)
@@ -64,22 +64,6 @@ const struct kvm_stats_header kvm_vcpu_stats_header = {
                       sizeof(kvm_vcpu_stats_desc),
 };
 
-struct kvm_stats_debugfs_item debugfs_entries[] = {
-       VCPU_STAT("halt_successful_poll", generic.halt_successful_poll),
-       VCPU_STAT("halt_attempted_poll", generic.halt_attempted_poll),
-       VCPU_STAT("halt_poll_invalid", generic.halt_poll_invalid),
-       VCPU_STAT("halt_wakeup", generic.halt_wakeup),
-       VCPU_STAT("hvc_exit_stat", hvc_exit_stat),
-       VCPU_STAT("wfe_exit_stat", wfe_exit_stat),
-       VCPU_STAT("wfi_exit_stat", wfi_exit_stat),
-       VCPU_STAT("mmio_exit_user", mmio_exit_user),
-       VCPU_STAT("mmio_exit_kernel", mmio_exit_kernel),
-       VCPU_STAT("exits", exits),
-       VCPU_STAT("halt_poll_success_ns", generic.halt_poll_success_ns),
-       VCPU_STAT("halt_poll_fail_ns", generic.halt_poll_fail_ns),
-       { NULL }
-};
-
 static bool core_reg_offset_is_vreg(u64 off)
 {
        return off >= KVM_REG_ARM_CORE_REG(fp_regs.vregs) &&
index 2aba78c2266dc502236406655e6bb2fb23733960..af9dd029a4e1217a7e98114da15ee12b62562fe8 100644 (file)
@@ -97,45 +97,6 @@ const struct kvm_stats_header kvm_vcpu_stats_header = {
                       sizeof(kvm_vcpu_stats_desc),
 };
 
-struct kvm_stats_debugfs_item debugfs_entries[] = {
-       VCPU_STAT("wait", wait_exits),
-       VCPU_STAT("cache", cache_exits),
-       VCPU_STAT("signal", signal_exits),
-       VCPU_STAT("interrupt", int_exits),
-       VCPU_STAT("cop_unusable", cop_unusable_exits),
-       VCPU_STAT("tlbmod", tlbmod_exits),
-       VCPU_STAT("tlbmiss_ld", tlbmiss_ld_exits),
-       VCPU_STAT("tlbmiss_st", tlbmiss_st_exits),
-       VCPU_STAT("addrerr_st", addrerr_st_exits),
-       VCPU_STAT("addrerr_ld", addrerr_ld_exits),
-       VCPU_STAT("syscall", syscall_exits),
-       VCPU_STAT("resvd_inst", resvd_inst_exits),
-       VCPU_STAT("break_inst", break_inst_exits),
-       VCPU_STAT("trap_inst", trap_inst_exits),
-       VCPU_STAT("msa_fpe", msa_fpe_exits),
-       VCPU_STAT("fpe", fpe_exits),
-       VCPU_STAT("msa_disabled", msa_disabled_exits),
-       VCPU_STAT("flush_dcache", flush_dcache_exits),
-       VCPU_STAT("vz_gpsi", vz_gpsi_exits),
-       VCPU_STAT("vz_gsfc", vz_gsfc_exits),
-       VCPU_STAT("vz_hc", vz_hc_exits),
-       VCPU_STAT("vz_grr", vz_grr_exits),
-       VCPU_STAT("vz_gva", vz_gva_exits),
-       VCPU_STAT("vz_ghfc", vz_ghfc_exits),
-       VCPU_STAT("vz_gpa", vz_gpa_exits),
-       VCPU_STAT("vz_resvd", vz_resvd_exits),
-#ifdef CONFIG_CPU_LOONGSON64
-       VCPU_STAT("vz_cpucfg", vz_cpucfg_exits),
-#endif
-       VCPU_STAT("halt_successful_poll", generic.halt_successful_poll),
-       VCPU_STAT("halt_attempted_poll", generic.halt_attempted_poll),
-       VCPU_STAT("halt_poll_invalid", generic.halt_poll_invalid),
-       VCPU_STAT("halt_wakeup", generic.halt_wakeup),
-       VCPU_STAT("halt_poll_success_ns", generic.halt_poll_success_ns),
-       VCPU_STAT("halt_poll_fail_ns", generic.halt_poll_fail_ns),
-       {NULL}
-};
-
 bool kvm_trace_guest_mode_change;
 
 int kvm_guest_mode_change_trace_reg(void)
index 61229302bce28f4c47c6e12045480c9bd5fa7b9a..79833f78d1da792320c46a8cbd4770b31bc8e224 100644 (file)
@@ -100,39 +100,6 @@ const struct kvm_stats_header kvm_vcpu_stats_header = {
                       sizeof(kvm_vcpu_stats_desc),
 };
 
-struct kvm_stats_debugfs_item debugfs_entries[] = {
-       VCPU_STAT("exits", sum_exits),
-       VCPU_STAT("mmio", mmio_exits),
-       VCPU_STAT("sig", signal_exits),
-       VCPU_STAT("sysc", syscall_exits),
-       VCPU_STAT("inst_emu", emulated_inst_exits),
-       VCPU_STAT("dec", dec_exits),
-       VCPU_STAT("ext_intr", ext_intr_exits),
-       VCPU_STAT("queue_intr", queue_intr),
-       VCPU_STAT("halt_poll_success_ns", generic.halt_poll_success_ns),
-       VCPU_STAT("halt_poll_fail_ns", generic.halt_poll_fail_ns),
-       VCPU_STAT("halt_wait_ns", halt_wait_ns),
-       VCPU_STAT("halt_successful_poll", generic.halt_successful_poll),
-       VCPU_STAT("halt_attempted_poll", generic.halt_attempted_poll),
-       VCPU_STAT("halt_successful_wait", halt_successful_wait),
-       VCPU_STAT("halt_poll_invalid", generic.halt_poll_invalid),
-       VCPU_STAT("halt_wakeup", generic.halt_wakeup),
-       VCPU_STAT("pf_storage", pf_storage),
-       VCPU_STAT("sp_storage", sp_storage),
-       VCPU_STAT("pf_instruc", pf_instruc),
-       VCPU_STAT("sp_instruc", sp_instruc),
-       VCPU_STAT("ld", ld),
-       VCPU_STAT("ld_slow", ld_slow),
-       VCPU_STAT("st", st),
-       VCPU_STAT("st_slow", st_slow),
-       VCPU_STAT("pthru_all", pthru_all),
-       VCPU_STAT("pthru_host", pthru_host),
-       VCPU_STAT("pthru_bad_aff", pthru_bad_aff),
-       VM_STAT("largepages_2M", num_2M_pages, .mode = 0444),
-       VM_STAT("largepages_1G", num_1G_pages, .mode = 0444),
-       { NULL }
-};
-
 static inline void kvmppc_update_int_pending(struct kvm_vcpu *vcpu,
                        unsigned long pending_now, unsigned long old_pending)
 {
index 6e8de33bc13813f794521d96b21701a0fb97d42d..551b30d84aeeb0872d912e0d68c4b07b40db65d9 100644 (file)
@@ -91,31 +91,6 @@ const struct kvm_stats_header kvm_vcpu_stats_header = {
                       sizeof(kvm_vcpu_stats_desc),
 };
 
-struct kvm_stats_debugfs_item debugfs_entries[] = {
-       VCPU_STAT("mmio", mmio_exits),
-       VCPU_STAT("sig", signal_exits),
-       VCPU_STAT("itlb_r", itlb_real_miss_exits),
-       VCPU_STAT("itlb_v", itlb_virt_miss_exits),
-       VCPU_STAT("dtlb_r", dtlb_real_miss_exits),
-       VCPU_STAT("dtlb_v", dtlb_virt_miss_exits),
-       VCPU_STAT("sysc", syscall_exits),
-       VCPU_STAT("isi", isi_exits),
-       VCPU_STAT("dsi", dsi_exits),
-       VCPU_STAT("inst_emu", emulated_inst_exits),
-       VCPU_STAT("dec", dec_exits),
-       VCPU_STAT("ext_intr", ext_intr_exits),
-       VCPU_STAT("halt_successful_poll", generic.halt_successful_poll),
-       VCPU_STAT("halt_attempted_poll", generic.halt_attempted_poll),
-       VCPU_STAT("halt_poll_invalid", generic.halt_poll_invalid),
-       VCPU_STAT("halt_wakeup", generic.halt_wakeup),
-       VCPU_STAT("doorbell", dbell_exits),
-       VCPU_STAT("guest doorbell", gdbell_exits),
-       VCPU_STAT("halt_poll_success_ns", generic.halt_poll_success_ns),
-       VCPU_STAT("halt_poll_fail_ns", generic.halt_poll_fail_ns),
-       VM_STAT("remote_tlb_flush", generic.remote_tlb_flush),
-       { NULL }
-};
-
 /* TODO: use vcpu_printf() */
 void kvmppc_dump_vcpu(struct kvm_vcpu *vcpu)
 {
index 8ac10bcaf8ba5d0aa0d499483129815ea88203f8..1695f0ced5baa759c41d269c0564147b20e1c80c 100644 (file)
@@ -186,114 +186,6 @@ const struct kvm_stats_header kvm_vcpu_stats_header = {
                       sizeof(kvm_vcpu_stats_desc),
 };
 
-struct kvm_stats_debugfs_item debugfs_entries[] = {
-       VCPU_STAT("userspace_handled", exit_userspace),
-       VCPU_STAT("exit_null", exit_null),
-       VCPU_STAT("pfault_sync", pfault_sync),
-       VCPU_STAT("exit_validity", exit_validity),
-       VCPU_STAT("exit_stop_request", exit_stop_request),
-       VCPU_STAT("exit_external_request", exit_external_request),
-       VCPU_STAT("exit_io_request", exit_io_request),
-       VCPU_STAT("exit_external_interrupt", exit_external_interrupt),
-       VCPU_STAT("exit_instruction", exit_instruction),
-       VCPU_STAT("exit_pei", exit_pei),
-       VCPU_STAT("exit_program_interruption", exit_program_interruption),
-       VCPU_STAT("exit_instr_and_program_int", exit_instr_and_program),
-       VCPU_STAT("exit_operation_exception", exit_operation_exception),
-       VCPU_STAT("halt_successful_poll", generic.halt_successful_poll),
-       VCPU_STAT("halt_attempted_poll", generic.halt_attempted_poll),
-       VCPU_STAT("halt_poll_invalid", generic.halt_poll_invalid),
-       VCPU_STAT("halt_no_poll_steal", halt_no_poll_steal),
-       VCPU_STAT("halt_wakeup", generic.halt_wakeup),
-       VCPU_STAT("halt_poll_success_ns", generic.halt_poll_success_ns),
-       VCPU_STAT("halt_poll_fail_ns", generic.halt_poll_fail_ns),
-       VCPU_STAT("instruction_lctlg", instruction_lctlg),
-       VCPU_STAT("instruction_lctl", instruction_lctl),
-       VCPU_STAT("instruction_stctl", instruction_stctl),
-       VCPU_STAT("instruction_stctg", instruction_stctg),
-       VCPU_STAT("deliver_ckc", deliver_ckc),
-       VCPU_STAT("deliver_cputm", deliver_cputm),
-       VCPU_STAT("deliver_emergency_signal", deliver_emergency_signal),
-       VCPU_STAT("deliver_external_call", deliver_external_call),
-       VCPU_STAT("deliver_service_signal", deliver_service_signal),
-       VCPU_STAT("deliver_virtio", deliver_virtio),
-       VCPU_STAT("deliver_stop_signal", deliver_stop_signal),
-       VCPU_STAT("deliver_prefix_signal", deliver_prefix_signal),
-       VCPU_STAT("deliver_restart_signal", deliver_restart_signal),
-       VCPU_STAT("deliver_program", deliver_program),
-       VCPU_STAT("deliver_io", deliver_io),
-       VCPU_STAT("deliver_machine_check", deliver_machine_check),
-       VCPU_STAT("exit_wait_state", exit_wait_state),
-       VCPU_STAT("inject_ckc", inject_ckc),
-       VCPU_STAT("inject_cputm", inject_cputm),
-       VCPU_STAT("inject_external_call", inject_external_call),
-       VM_STAT("inject_float_mchk", inject_float_mchk),
-       VCPU_STAT("inject_emergency_signal", inject_emergency_signal),
-       VM_STAT("inject_io", inject_io),
-       VCPU_STAT("inject_mchk", inject_mchk),
-       VM_STAT("inject_pfault_done", inject_pfault_done),
-       VCPU_STAT("inject_program", inject_program),
-       VCPU_STAT("inject_restart", inject_restart),
-       VM_STAT("inject_service_signal", inject_service_signal),
-       VCPU_STAT("inject_set_prefix", inject_set_prefix),
-       VCPU_STAT("inject_stop_signal", inject_stop_signal),
-       VCPU_STAT("inject_pfault_init", inject_pfault_init),
-       VM_STAT("inject_virtio", inject_virtio),
-       VCPU_STAT("instruction_epsw", instruction_epsw),
-       VCPU_STAT("instruction_gs", instruction_gs),
-       VCPU_STAT("instruction_io_other", instruction_io_other),
-       VCPU_STAT("instruction_lpsw", instruction_lpsw),
-       VCPU_STAT("instruction_lpswe", instruction_lpswe),
-       VCPU_STAT("instruction_pfmf", instruction_pfmf),
-       VCPU_STAT("instruction_ptff", instruction_ptff),
-       VCPU_STAT("instruction_stidp", instruction_stidp),
-       VCPU_STAT("instruction_sck", instruction_sck),
-       VCPU_STAT("instruction_sckpf", instruction_sckpf),
-       VCPU_STAT("instruction_spx", instruction_spx),
-       VCPU_STAT("instruction_stpx", instruction_stpx),
-       VCPU_STAT("instruction_stap", instruction_stap),
-       VCPU_STAT("instruction_iske", instruction_iske),
-       VCPU_STAT("instruction_ri", instruction_ri),
-       VCPU_STAT("instruction_rrbe", instruction_rrbe),
-       VCPU_STAT("instruction_sske", instruction_sske),
-       VCPU_STAT("instruction_ipte_interlock", instruction_ipte_interlock),
-       VCPU_STAT("instruction_essa", instruction_essa),
-       VCPU_STAT("instruction_stsi", instruction_stsi),
-       VCPU_STAT("instruction_stfl", instruction_stfl),
-       VCPU_STAT("instruction_tb", instruction_tb),
-       VCPU_STAT("instruction_tpi", instruction_tpi),
-       VCPU_STAT("instruction_tprot", instruction_tprot),
-       VCPU_STAT("instruction_tsch", instruction_tsch),
-       VCPU_STAT("instruction_sthyi", instruction_sthyi),
-       VCPU_STAT("instruction_sie", instruction_sie),
-       VCPU_STAT("instruction_sigp_sense", instruction_sigp_sense),
-       VCPU_STAT("instruction_sigp_sense_running", instruction_sigp_sense_running),
-       VCPU_STAT("instruction_sigp_external_call", instruction_sigp_external_call),
-       VCPU_STAT("instruction_sigp_emergency", instruction_sigp_emergency),
-       VCPU_STAT("instruction_sigp_cond_emergency", instruction_sigp_cond_emergency),
-       VCPU_STAT("instruction_sigp_start", instruction_sigp_start),
-       VCPU_STAT("instruction_sigp_stop", instruction_sigp_stop),
-       VCPU_STAT("instruction_sigp_stop_store_status", instruction_sigp_stop_store_status),
-       VCPU_STAT("instruction_sigp_store_status", instruction_sigp_store_status),
-       VCPU_STAT("instruction_sigp_store_adtl_status", instruction_sigp_store_adtl_status),
-       VCPU_STAT("instruction_sigp_set_arch", instruction_sigp_arch),
-       VCPU_STAT("instruction_sigp_set_prefix", instruction_sigp_prefix),
-       VCPU_STAT("instruction_sigp_restart", instruction_sigp_restart),
-       VCPU_STAT("instruction_sigp_cpu_reset", instruction_sigp_cpu_reset),
-       VCPU_STAT("instruction_sigp_init_cpu_reset", instruction_sigp_init_cpu_reset),
-       VCPU_STAT("instruction_sigp_unknown", instruction_sigp_unknown),
-       VCPU_STAT("instruction_diag_10", diagnose_10),
-       VCPU_STAT("instruction_diag_44", diagnose_44),
-       VCPU_STAT("instruction_diag_9c", diagnose_9c),
-       VCPU_STAT("diag_9c_ignored", diagnose_9c_ignored),
-       VCPU_STAT("diag_9c_forward", diagnose_9c_forward),
-       VCPU_STAT("instruction_diag_258", diagnose_258),
-       VCPU_STAT("instruction_diag_308", diagnose_308),
-       VCPU_STAT("instruction_diag_500", diagnose_500),
-       VCPU_STAT("instruction_diag_other", diagnose_other),
-       { NULL }
-};
-
 /* allow nested virtualization in KVM (if enabled by user space) */
 static int nested;
 module_param(nested, int, S_IRUGO);
index 53b7c25d6ebc5ea3a4d5204b813798e7aa2248a3..5833b8780808f7ac714cbc0dff518cfc11c025b8 100644 (file)
@@ -234,7 +234,7 @@ const struct _kvm_stats_desc kvm_vm_stats_desc[] = {
        STATS_DESC_ICOUNTER(VM, mmu_unsync),
        STATS_DESC_ICOUNTER(VM, lpages),
        STATS_DESC_ICOUNTER(VM, nx_lpage_splits),
-       STATS_DESC_ICOUNTER(VM, max_mmu_page_hash_collisions)
+       STATS_DESC_PCOUNTER(VM, max_mmu_page_hash_collisions)
 };
 static_assert(ARRAY_SIZE(kvm_vm_stats_desc) ==
                sizeof(struct kvm_vm_stat) / sizeof(u64));
@@ -289,53 +289,6 @@ const struct kvm_stats_header kvm_vcpu_stats_header = {
                       sizeof(kvm_vcpu_stats_desc),
 };
 
-struct kvm_stats_debugfs_item debugfs_entries[] = {
-       VCPU_STAT("pf_fixed", pf_fixed),
-       VCPU_STAT("pf_guest", pf_guest),
-       VCPU_STAT("tlb_flush", tlb_flush),
-       VCPU_STAT("invlpg", invlpg),
-       VCPU_STAT("exits", exits),
-       VCPU_STAT("io_exits", io_exits),
-       VCPU_STAT("mmio_exits", mmio_exits),
-       VCPU_STAT("signal_exits", signal_exits),
-       VCPU_STAT("irq_window", irq_window_exits),
-       VCPU_STAT("nmi_window", nmi_window_exits),
-       VCPU_STAT("halt_exits", halt_exits),
-       VCPU_STAT("halt_successful_poll", generic.halt_successful_poll),
-       VCPU_STAT("halt_attempted_poll", generic.halt_attempted_poll),
-       VCPU_STAT("halt_poll_invalid", generic.halt_poll_invalid),
-       VCPU_STAT("halt_wakeup", generic.halt_wakeup),
-       VCPU_STAT("hypercalls", hypercalls),
-       VCPU_STAT("request_irq", request_irq_exits),
-       VCPU_STAT("irq_exits", irq_exits),
-       VCPU_STAT("host_state_reload", host_state_reload),
-       VCPU_STAT("fpu_reload", fpu_reload),
-       VCPU_STAT("insn_emulation", insn_emulation),
-       VCPU_STAT("insn_emulation_fail", insn_emulation_fail),
-       VCPU_STAT("irq_injections", irq_injections),
-       VCPU_STAT("nmi_injections", nmi_injections),
-       VCPU_STAT("req_event", req_event),
-       VCPU_STAT("l1d_flush", l1d_flush),
-       VCPU_STAT("halt_poll_success_ns", generic.halt_poll_success_ns),
-       VCPU_STAT("halt_poll_fail_ns", generic.halt_poll_fail_ns),
-       VCPU_STAT("nested_run", nested_run),
-       VCPU_STAT("directed_yield_attempted", directed_yield_attempted),
-       VCPU_STAT("directed_yield_successful", directed_yield_successful),
-       VCPU_STAT("guest_mode", guest_mode),
-       VM_STAT("mmu_shadow_zapped", mmu_shadow_zapped),
-       VM_STAT("mmu_pte_write", mmu_pte_write),
-       VM_STAT("mmu_pde_zapped", mmu_pde_zapped),
-       VM_STAT("mmu_flooded", mmu_flooded),
-       VM_STAT("mmu_recycled", mmu_recycled),
-       VM_STAT("mmu_cache_miss", mmu_cache_miss),
-       VM_STAT("mmu_unsync", mmu_unsync),
-       VM_STAT("remote_tlb_flush", generic.remote_tlb_flush),
-       VM_STAT("largepages", lpages, .mode = 0444),
-       VM_STAT("nx_largepages_splitted", nx_lpage_splits, .mode = 0444),
-       VM_STAT("max_mmu_page_hash_collisions", max_mmu_page_hash_collisions),
-       { NULL }
-};
-
 u64 __read_mostly host_xcr0;
 u64 __read_mostly supported_xcr0;
 EXPORT_SYMBOL_GPL(supported_xcr0);
index 9e75afef16b05ad15961366ffe842d2a3bf6c77d..ae7735b490b4575a9dfb4d0bb4787ec80d8f2b4c 100644 (file)
@@ -1264,14 +1264,8 @@ enum kvm_stat_kind {
 
 struct kvm_stat_data {
        struct kvm *kvm;
-       struct kvm_stats_debugfs_item *dbgfs_item;
-};
-
-struct kvm_stats_debugfs_item {
-       const char *name;
-       int offset;
+       const struct _kvm_stats_desc *desc;
        enum kvm_stat_kind kind;
-       int mode;
 };
 
 struct _kvm_stats_desc {
@@ -1279,14 +1273,6 @@ struct _kvm_stats_desc {
        char name[KVM_STATS_NAME_SIZE];
 };
 
-#define KVM_DBGFS_GET_MODE(dbgfs_item)                                         \
-       ((dbgfs_item)->mode ? (dbgfs_item)->mode : 0644)
-
-#define VM_STAT(n, x, ...)                                                    \
-       { n, offsetof(struct kvm, stat.x), KVM_STAT_VM, ## __VA_ARGS__ }
-#define VCPU_STAT(n, x, ...)                                                  \
-       { n, offsetof(struct kvm_vcpu, stat.x), KVM_STAT_VCPU, ## __VA_ARGS__ }
-
 #define STATS_DESC_COMMON(type, unit, base, exp)                              \
        .flags = type | unit | base |                                          \
                 BUILD_BUG_ON_ZERO(type & ~KVM_STATS_TYPE_MASK) |              \
@@ -1367,7 +1353,6 @@ struct _kvm_stats_desc {
        STATS_DESC_TIME_NSEC(VCPU_GENERIC, halt_poll_success_ns),              \
        STATS_DESC_TIME_NSEC(VCPU_GENERIC, halt_poll_fail_ns)
 
-extern struct kvm_stats_debugfs_item debugfs_entries[];
 extern struct dentry *kvm_debugfs_dir;
 ssize_t kvm_stats_read(char *id, const struct kvm_stats_header *header,
                       const struct _kvm_stats_desc *desc,
index c8d0028df4ac39a88d4488214b01a09f8b05b54e..3dcc2abbfc609f18fb3c4103babc093e0b2ef0bf 100644 (file)
@@ -115,7 +115,6 @@ static DEFINE_PER_CPU(struct kvm_vcpu *, kvm_running_vcpu);
 struct dentry *kvm_debugfs_dir;
 EXPORT_SYMBOL_GPL(kvm_debugfs_dir);
 
-static int kvm_debugfs_num_entries;
 static const struct file_operations stat_fops_per_vm;
 
 static long kvm_vcpu_ioctl(struct file *file, unsigned int ioctl,
@@ -860,9 +859,24 @@ static void kvm_free_memslots(struct kvm *kvm, struct kvm_memslots *slots)
        kvfree(slots);
 }
 
+static umode_t kvm_stats_debugfs_mode(const struct _kvm_stats_desc *pdesc)
+{
+       switch (pdesc->desc.flags & KVM_STATS_TYPE_MASK) {
+       case KVM_STATS_TYPE_INSTANT:
+               return 0444;
+       case KVM_STATS_TYPE_CUMULATIVE:
+       case KVM_STATS_TYPE_PEAK:
+       default:
+               return 0644;
+       }
+}
+
+
 static void kvm_destroy_vm_debugfs(struct kvm *kvm)
 {
        int i;
+       int kvm_debugfs_num_entries = kvm_vm_stats_header.num_desc +
+                                     kvm_vcpu_stats_header.num_desc;
 
        if (!kvm->debugfs_dentry)
                return;
@@ -880,7 +894,10 @@ static int kvm_create_vm_debugfs(struct kvm *kvm, int fd)
 {
        char dir_name[ITOA_MAX_LEN * 2];
        struct kvm_stat_data *stat_data;
-       struct kvm_stats_debugfs_item *p;
+       const struct _kvm_stats_desc *pdesc;
+       int i;
+       int kvm_debugfs_num_entries = kvm_vm_stats_header.num_desc +
+                                     kvm_vcpu_stats_header.num_desc;
 
        if (!debugfs_initialized())
                return 0;
@@ -894,15 +911,32 @@ static int kvm_create_vm_debugfs(struct kvm *kvm, int fd)
        if (!kvm->debugfs_stat_data)
                return -ENOMEM;
 
-       for (p = debugfs_entries; p->name; p++) {
+       for (i = 0; i < kvm_vm_stats_header.num_desc; ++i) {
+               pdesc = &kvm_vm_stats_desc[i];
                stat_data = kzalloc(sizeof(*stat_data), GFP_KERNEL_ACCOUNT);
                if (!stat_data)
                        return -ENOMEM;
 
                stat_data->kvm = kvm;
-               stat_data->dbgfs_item = p;
-               kvm->debugfs_stat_data[p - debugfs_entries] = stat_data;
-               debugfs_create_file(p->name, KVM_DBGFS_GET_MODE(p),
+               stat_data->desc = pdesc;
+               stat_data->kind = KVM_STAT_VM;
+               kvm->debugfs_stat_data[i] = stat_data;
+               debugfs_create_file(pdesc->name, kvm_stats_debugfs_mode(pdesc),
+                                   kvm->debugfs_dentry, stat_data,
+                                   &stat_fops_per_vm);
+       }
+
+       for (i = 0; i < kvm_vcpu_stats_header.num_desc; ++i) {
+               pdesc = &kvm_vcpu_stats_desc[i];
+               stat_data = kzalloc(sizeof(*stat_data), GFP_KERNEL_ACCOUNT);
+               if (!stat_data)
+                       return -ENOMEM;
+
+               stat_data->kvm = kvm;
+               stat_data->desc = pdesc;
+               stat_data->kind = KVM_STAT_VCPU;
+               kvm->debugfs_stat_data[i] = stat_data;
+               debugfs_create_file(pdesc->name, kvm_stats_debugfs_mode(pdesc),
                                    kvm->debugfs_dentry, stat_data,
                                    &stat_fops_per_vm);
        }
@@ -4900,7 +4934,7 @@ static int kvm_debugfs_open(struct inode *inode, struct file *file,
                return -ENOENT;
 
        if (simple_attr_open(inode, file, get,
-                   KVM_DBGFS_GET_MODE(stat_data->dbgfs_item) & 0222
+                   kvm_stats_debugfs_mode(stat_data->desc) & 0222
                    ? set : NULL,
                    fmt)) {
                kvm_put_kvm(stat_data->kvm);
@@ -4923,14 +4957,14 @@ static int kvm_debugfs_release(struct inode *inode, struct file *file)
 
 static int kvm_get_stat_per_vm(struct kvm *kvm, size_t offset, u64 *val)
 {
-       *val = *(u64 *)((void *)kvm + offset);
+       *val = *(u64 *)((void *)(&kvm->stat) + offset);
 
        return 0;
 }
 
 static int kvm_clear_stat_per_vm(struct kvm *kvm, size_t offset)
 {
-       *(u64 *)((void *)kvm + offset) = 0;
+       *(u64 *)((void *)(&kvm->stat) + offset) = 0;
 
        return 0;
 }
@@ -4943,7 +4977,7 @@ static int kvm_get_stat_per_vcpu(struct kvm *kvm, size_t offset, u64 *val)
        *val = 0;
 
        kvm_for_each_vcpu(i, vcpu, kvm)
-               *val += *(u64 *)((void *)vcpu + offset);
+               *val += *(u64 *)((void *)(&vcpu->stat) + offset);
 
        return 0;
 }
@@ -4954,7 +4988,7 @@ static int kvm_clear_stat_per_vcpu(struct kvm *kvm, size_t offset)
        struct kvm_vcpu *vcpu;
 
        kvm_for_each_vcpu(i, vcpu, kvm)
-               *(u64 *)((void *)vcpu + offset) = 0;
+               *(u64 *)((void *)(&vcpu->stat) + offset) = 0;
 
        return 0;
 }
@@ -4964,14 +4998,14 @@ static int kvm_stat_data_get(void *data, u64 *val)
        int r = -EFAULT;
        struct kvm_stat_data *stat_data = (struct kvm_stat_data *)data;
 
-       switch (stat_data->dbgfs_item->kind) {
+       switch (stat_data->kind) {
        case KVM_STAT_VM:
                r = kvm_get_stat_per_vm(stat_data->kvm,
-                                       stat_data->dbgfs_item->offset, val);
+                                       stat_data->desc->desc.offset, val);
                break;
        case KVM_STAT_VCPU:
                r = kvm_get_stat_per_vcpu(stat_data->kvm,
-                                         stat_data->dbgfs_item->offset, val);
+                                         stat_data->desc->desc.offset, val);
                break;
        }
 
@@ -4986,14 +5020,14 @@ static int kvm_stat_data_clear(void *data, u64 val)
        if (val)
                return -EINVAL;
 
-       switch (stat_data->dbgfs_item->kind) {
+       switch (stat_data->kind) {
        case KVM_STAT_VM:
                r = kvm_clear_stat_per_vm(stat_data->kvm,
-                                         stat_data->dbgfs_item->offset);
+                                         stat_data->desc->desc.offset);
                break;
        case KVM_STAT_VCPU:
                r = kvm_clear_stat_per_vcpu(stat_data->kvm,
-                                           stat_data->dbgfs_item->offset);
+                                           stat_data->desc->desc.offset);
                break;
        }
 
@@ -5050,6 +5084,7 @@ static int vm_stat_clear(void *_offset, u64 val)
 }
 
 DEFINE_SIMPLE_ATTRIBUTE(vm_stat_fops, vm_stat_get, vm_stat_clear, "%llu\n");
+DEFINE_SIMPLE_ATTRIBUTE(vm_stat_readonly_fops, vm_stat_get, NULL, "%llu\n");
 
 static int vcpu_stat_get(void *_offset, u64 *val)
 {
@@ -5086,11 +5121,7 @@ static int vcpu_stat_clear(void *_offset, u64 val)
 
 DEFINE_SIMPLE_ATTRIBUTE(vcpu_stat_fops, vcpu_stat_get, vcpu_stat_clear,
                        "%llu\n");
-
-static const struct file_operations *stat_fops[] = {
-       [KVM_STAT_VCPU] = &vcpu_stat_fops,
-       [KVM_STAT_VM]   = &vm_stat_fops,
-};
+DEFINE_SIMPLE_ATTRIBUTE(vcpu_stat_readonly_fops, vcpu_stat_get, NULL, "%llu\n");
 
 static void kvm_uevent_notify_change(unsigned int type, struct kvm *kvm)
 {
@@ -5144,15 +5175,32 @@ static void kvm_uevent_notify_change(unsigned int type, struct kvm *kvm)
 
 static void kvm_init_debug(void)
 {
-       struct kvm_stats_debugfs_item *p;
+       const struct file_operations *fops;
+       const struct _kvm_stats_desc *pdesc;
+       int i;
 
        kvm_debugfs_dir = debugfs_create_dir("kvm", NULL);
 
-       kvm_debugfs_num_entries = 0;
-       for (p = debugfs_entries; p->name; ++p, kvm_debugfs_num_entries++) {
-               debugfs_create_file(p->name, KVM_DBGFS_GET_MODE(p),
-                                   kvm_debugfs_dir, (void *)(long)p->offset,
-                                   stat_fops[p->kind]);
+       for (i = 0; i < kvm_vm_stats_header.num_desc; ++i) {
+               pdesc = &kvm_vm_stats_desc[i];
+               if (kvm_stats_debugfs_mode(pdesc) & 0222)
+                       fops = &vm_stat_fops;
+               else
+                       fops = &vm_stat_readonly_fops;
+               debugfs_create_file(pdesc->name, kvm_stats_debugfs_mode(pdesc),
+                               kvm_debugfs_dir,
+                               (void *)(long)pdesc->desc.offset, fops);
+       }
+
+       for (i = 0; i < kvm_vcpu_stats_header.num_desc; ++i) {
+               pdesc = &kvm_vcpu_stats_desc[i];
+               if (kvm_stats_debugfs_mode(pdesc) & 0222)
+                       fops = &vcpu_stat_fops;
+               else
+                       fops = &vcpu_stat_readonly_fops;
+               debugfs_create_file(pdesc->name, kvm_stats_debugfs_mode(pdesc),
+                               kvm_debugfs_dir,
+                               (void *)(long)pdesc->desc.offset, fops);
        }
 }