ASoC: wcd9335: Fix spurious event generation
authorMark Brown <broonie@kernel.org>
Fri, 3 Jun 2022 12:46:09 +0000 (14:46 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 24 Jun 2022 15:21:44 +0000 (16:21 +0100)
The slimbus mux put operation unconditionally reports a change in value
which means that spurious events are generated. Fix this by exiting early
in that case.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20220603124609.4024666-1-broonie@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wcd9335.c

index 597420679505b948c78abcca6da23b96e47ef9ec..d9f1352006881ee2d17d3faa4220e84c7e447f61 100644 (file)
@@ -1287,6 +1287,9 @@ static int slim_rx_mux_put(struct snd_kcontrol *kc,
        struct snd_soc_dapm_update *update = NULL;
        u32 port_id = w->shift;
 
+       if (wcd->rx_port_value[port_id] == ucontrol->value.enumerated.item[0])
+               return 0;
+
        wcd->rx_port_value[port_id] = ucontrol->value.enumerated.item[0];
 
        /* Remove channel from any list it's in before adding it to a new one */