drm/malidp: Annotate dma-fence critical section in commit path
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 21 Jan 2021 15:29:53 +0000 (16:29 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 23 Feb 2021 11:54:20 +0000 (12:54 +0100)
Again needs to be put right after the call to
drm_atomic_helper_commit_hw_done(), since that's the last thing which
can hold up a subsequent atomic commit.

No surprises here.

Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: "James (Qian) Wang" <james.qian.wang@arm.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Mihail Atanassov <mihail.atanassov@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210121152959.1725404-6-daniel.vetter@ffwll.ch
drivers/gpu/drm/arm/malidp_drv.c

index fceda010d65a1fa1fc88db24f163179ef8ba6873..d83c7366b348ba7faa7949bcc5f185266644dfe6 100644 (file)
@@ -234,6 +234,7 @@ static void malidp_atomic_commit_tail(struct drm_atomic_state *state)
        struct drm_crtc *crtc;
        struct drm_crtc_state *old_crtc_state;
        int i;
+       bool fence_cookie = dma_fence_begin_signalling();
 
        pm_runtime_get_sync(drm->dev);
 
@@ -260,6 +261,8 @@ static void malidp_atomic_commit_tail(struct drm_atomic_state *state)
 
        malidp_atomic_commit_hw_done(state);
 
+       dma_fence_end_signalling(fence_cookie);
+
        pm_runtime_put(drm->dev);
 
        drm_atomic_helper_cleanup_planes(drm, state);