i2c: ali1535: mention that the device should not be disabled
authorWolfram Sang <wsa@kernel.org>
Fri, 25 Jun 2021 15:17:58 +0000 (17:17 +0200)
committerWolfram Sang <wsa@kernel.org>
Fri, 2 Jul 2021 07:14:46 +0000 (09:14 +0200)
The comment from the i801 driver is valid here, too, so copy it.

Reported-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-ali1535.c

index fb93152845f433bc1c015002320bf71991aa8fa6..ee83c4581bce059205515db11621d915e3023836 100644 (file)
@@ -508,6 +508,11 @@ static void ali1535_remove(struct pci_dev *dev)
 {
        i2c_del_adapter(&ali1535_adapter);
        release_region(ali1535_smba, ALI1535_SMB_IOSIZE);
+
+       /*
+        * do not call pci_disable_device(dev) since it can cause hard hangs on
+        * some systems during power-off
+        */
 }
 
 static struct pci_driver ali1535_driver = {