PCI/MSI: Reject MSI-X early
authorThomas Gleixner <tglx@linutronix.de>
Fri, 11 Nov 2022 13:55:11 +0000 (14:55 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 17 Nov 2022 14:15:22 +0000 (15:15 +0100)
Similar to PCI multi-MSI reject MSI-X enablement when a irq domain is
attached to the device which does not support MSI-X.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://lore.kernel.org/r/20221111122015.631728309@linutronix.de
drivers/pci/msi/msi.c

index bc84647c6dbd466f5941b7bf86548bf69f3dca9c..0740acd10bdef6cbafc8d59d3fc4afc5d83eb72b 100644 (file)
@@ -762,6 +762,10 @@ int __pci_enable_msix_range(struct pci_dev *dev, struct msix_entry *entries, int
        if (WARN_ON_ONCE(dev->msix_enabled))
                return -EINVAL;
 
+       /* Check MSI-X early on irq domain enabled architectures */
+       if (!pci_msi_domain_supports(dev, MSI_FLAG_PCI_MSIX, ALLOW_LEGACY))
+               return -ENOTSUPP;
+
        if (!pci_msi_supported(dev, nvec) || dev->current_state != PCI_D0)
                return -EINVAL;