drm/gm12u320: Use devm_drm_dev_alloc
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 15 Apr 2020 07:39:56 +0000 (09:39 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 28 Apr 2020 13:54:38 +0000 (15:54 +0200)
Already using devm_drm_dev_init, so very simple replacment.

Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200415074034.175360-22-daniel.vetter@ffwll.ch
drivers/gpu/drm/tiny/gm12u320.c

index 6f0ea2827d62ca63e52f6ecebad746d0bb41315b..907739a67bf661331a5af159917bb8a94794197f 100644 (file)
@@ -631,22 +631,17 @@ static int gm12u320_usb_probe(struct usb_interface *interface,
        if (interface->cur_altsetting->desc.bInterfaceNumber != 0)
                return -ENODEV;
 
-       gm12u320 = kzalloc(sizeof(*gm12u320), GFP_KERNEL);
-       if (gm12u320 == NULL)
-               return -ENOMEM;
+       gm12u320 = devm_drm_dev_alloc(&interface->dev, &gm12u320_drm_driver,
+                                     struct gm12u320_device, dev);
+       if (IS_ERR(gm12u320))
+               return PTR_ERR(gm12u320);
 
        gm12u320->udev = interface_to_usbdev(interface);
        INIT_DELAYED_WORK(&gm12u320->fb_update.work, gm12u320_fb_update_work);
        mutex_init(&gm12u320->fb_update.lock);
 
        dev = &gm12u320->dev;
-       ret = devm_drm_dev_init(&interface->dev, dev, &gm12u320_drm_driver);
-       if (ret) {
-               kfree(gm12u320);
-               return ret;
-       }
        dev->dev_private = gm12u320;
-       drmm_add_final_kfree(dev, gm12u320);
 
        ret = drmm_mode_config_init(dev);
        if (ret)