bcache: Really show state of work pending bit
authorPetr Mladek <pmladek@suse.com>
Mon, 5 Oct 2015 12:39:52 +0000 (14:39 +0200)
committerJiri Kosina <jkosina@suse.cz>
Fri, 6 Nov 2015 14:06:05 +0000 (15:06 +0100)
WORK_STRUCT_PENDING is a mask for testing the pending bit.
test_bit() expects the number of the bit and we need to
use WORK_STRUCT_PENDING_BIT there.

Also work_data_bits() is defined in workqueues.h now.

I have noticed this just by chance when looking how
WORK_STRUCT_PENDING_BIT is used. The change is compile
tested.

Signed-off-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/md/bcache/closure.c

index 7a228de95fd7e94fa61acb0758a53d8670770383..9eaf1d6e83023a2045063b8761a89b3983952f7c 100644 (file)
@@ -167,8 +167,6 @@ EXPORT_SYMBOL(closure_debug_destroy);
 
 static struct dentry *debug;
 
-#define work_data_bits(work) ((unsigned long *)(&(work)->data))
-
 static int debug_seq_show(struct seq_file *f, void *data)
 {
        struct closure *cl;
@@ -182,7 +180,7 @@ static int debug_seq_show(struct seq_file *f, void *data)
                           r & CLOSURE_REMAINING_MASK);
 
                seq_printf(f, "%s%s%s%s\n",
-                          test_bit(WORK_STRUCT_PENDING,
+                          test_bit(WORK_STRUCT_PENDING_BIT,
                                    work_data_bits(&cl->work)) ? "Q" : "",
                           r & CLOSURE_RUNNING  ? "R" : "",
                           r & CLOSURE_STACK    ? "S" : "",