Merge tag 'input-for-v6.4-rc0' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor...
authorLinus Torvalds <torvalds@linux-foundation.org>
Tue, 2 May 2023 00:18:56 +0000 (17:18 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 2 May 2023 00:18:56 +0000 (17:18 -0700)
Pull input updates from Dmitry Torokhov:

 - a new driver for Novatek touch controllers

 - a new driver for power button for NXP BBNSM

 - a skeleton KUnit tests for the input core

 - improvements to Xpad game controller driver to support more devices

 - improvements to edt-ft5x06, hideep and other drivers

* tag 'input-for-v6.4-rc0' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input: (42 commits)
  Revert "Input: xpad - fix support for some third-party controllers"
  dt-bindings: input: pwm-beeper: convert to dt schema
  Input: xpad - fix PowerA EnWired Controller guide button
  Input: xpad - add constants for GIP interface numbers
  Input: synaptics-rmi4 - fix function name in kerneldoc
  Input: raspberrypi-ts - fix refcount leak in rpi_ts_probe
  Input: edt-ft5x06 - select REGMAP_I2C
  Input: melfas_mip4 - report palm touches
  Input: cma3000_d0x - remove unneeded code
  Input: edt-ft5x06 - calculate points data length only once
  Input: edt-ft5x06 - unify the crc check
  Input: edt-ft5x06 - convert to use regmap API
  Input: edt-ft5x06 - don't print error messages with dev_dbg()
  Input: edt-ft5x06 - remove code duplication
  Input: edt-ft5x06 - don't recalculate the CRC
  Input: edt-ft5x06 - add spaces to ensure format specification
  Input: edt-ft5x06 - remove unnecessary blank lines
  Input: edt-ft5x06 - fix indentation
  Input: tsc2007 - enable cansleep pendown GPIO
  Input: Add KUnit tests for some of the input core helper functions
  ...

37 files changed:
Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
Documentation/devicetree/bindings/input/pwm-beeper.txt [deleted file]
Documentation/devicetree/bindings/input/pwm-beeper.yaml [new file with mode: 0644]
MAINTAINERS
arch/arm/mach-pxa/spitz.c
drivers/input/Kconfig
drivers/input/Makefile
drivers/input/joystick/xpad.c
drivers/input/keyboard/gpio_keys.c
drivers/input/keyboard/iqs62x-keys.c
drivers/input/keyboard/matrix_keypad.c
drivers/input/keyboard/omap4-keypad.c
drivers/input/keyboard/samsung-keypad.c
drivers/input/keyboard/st-keyscan.c
drivers/input/keyboard/tegra-kbc.c
drivers/input/keyboard/tm2-touchkey.c
drivers/input/misc/Kconfig
drivers/input/misc/Makefile
drivers/input/misc/cma3000_d0x.c
drivers/input/misc/hp_sdc_rtc.c
drivers/input/misc/nxp-bbnsm-pwrkey.c [new file with mode: 0644]
drivers/input/rmi4/rmi_bus.c
drivers/input/tests/.kunitconfig [new file with mode: 0644]
drivers/input/tests/Makefile [new file with mode: 0644]
drivers/input/tests/input_test.c [new file with mode: 0644]
drivers/input/touchscreen/Kconfig
drivers/input/touchscreen/Makefile
drivers/input/touchscreen/bcm_iproc_tsc.c
drivers/input/touchscreen/edt-ft5x06.c
drivers/input/touchscreen/hideep.c
drivers/input/touchscreen/melfas_mip4.c
drivers/input/touchscreen/novatek-nvt-ts.c [new file with mode: 0644]
drivers/input/touchscreen/raspberrypi-ts.c
drivers/input/touchscreen/sun4i-ts.c
drivers/input/touchscreen/tsc2007_core.c
drivers/input/touchscreen/zinitix.c
include/linux/input/matrix_keypad.h

index 3486c81699a84d8b98d6c32643637468a570157c..fefaaf46a2400e8f8539e8cfae397b9773dd0bbb 100644 (file)
@@ -45,7 +45,7 @@ properties:
       when the keyboard has a custom design for the top row keys.
 
 dependencies:
-  function-row-phsymap: [ 'linux,keymap' ]
+  function-row-physmap: [ 'linux,keymap' ]
   google,needs-ghost-filter: [ 'linux,keymap' ]
 
 required:
diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.txt b/Documentation/devicetree/bindings/input/pwm-beeper.txt
deleted file mode 100644 (file)
index 8fc0e48..0000000
+++ /dev/null
@@ -1,24 +0,0 @@
-* PWM beeper device tree bindings
-
-Registers a PWM device as beeper.
-
-Required properties:
-- compatible: should be "pwm-beeper"
-- pwms: phandle to the physical PWM device
-
-Optional properties:
-- amp-supply: phandle to a regulator that acts as an amplifier for the beeper
-- beeper-hz:  bell frequency in Hz
-
-Example:
-
-beeper_amp: amplifier {
-       compatible = "fixed-regulator";
-       gpios = <&gpio0 1 GPIO_ACTIVE_HIGH>;
-};
-
-beeper {
-       compatible = "pwm-beeper";
-       pwms = <&pwm0>;
-       amp-supply = <&beeper_amp>;
-};
diff --git a/Documentation/devicetree/bindings/input/pwm-beeper.yaml b/Documentation/devicetree/bindings/input/pwm-beeper.yaml
new file mode 100644 (file)
index 0000000..a7611c2
--- /dev/null
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/input/pwm-beeper.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: PWM beeper
+
+maintainers:
+  - Sascha Hauer <s.hauer@pengutronix.de>
+
+properties:
+  compatible:
+    const: pwm-beeper
+
+  pwms:
+    maxItems: 1
+
+  amp-supply:
+    description: an amplifier for the beeper
+
+  beeper-hz:
+    description: bell frequency in Hz
+    minimum: 10
+    maximum: 10000
+
+required:
+  - compatible
+  - pwms
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    beeper {
+        compatible = "pwm-beeper";
+        pwms = <&pwm0>;
+        amp-supply = <&beeper_amp>;
+        beeper-hz = <1000>;
+    };
index c754befb94e7c3c60e1d62ecd1a40ba99bc41c31..7575d3992fcf84795e8cde670f4d2c61c33e7bf4 100644 (file)
@@ -14877,6 +14877,12 @@ T:     git git://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/nolibc.git
 F:     tools/include/nolibc/
 F:     tools/testing/selftests/nolibc/
 
+NOVATEK NVT-TS I2C TOUCHSCREEN DRIVER
+M:     Hans de Goede <hdegoede@redhat.com>
+L:     linux-input@vger.kernel.org
+S:     Maintained
+F:     drivers/input/touchscreen/novatek-nvt-ts.c
+
 NSDEPS
 M:     Matthias Maennich <maennich@google.com>
 S:     Maintained
index 26f0ebc4d1365d59eb9f2e4e8150fa344dc27e3e..4325bdc2b9ff8b4168b50e361de436caa954a676 100644 (file)
@@ -25,6 +25,7 @@
 #include <linux/spi/pxa2xx_spi.h>
 #include <linux/mtd/sharpsl.h>
 #include <linux/mtd/physmap.h>
+#include <linux/input-event-codes.h>
 #include <linux/input/matrix_keypad.h>
 #include <linux/regulator/machine.h>
 #include <linux/io.h>
index e2752f7364bcfe8e687710926846fe175d86e4da..735f90b74ee5ad44b34e85ad9c7888ec2b6c3261 100644 (file)
@@ -166,6 +166,16 @@ config INPUT_EVBUG
          To compile this driver as a module, choose M here: the
          module will be called evbug.
 
+config INPUT_KUNIT_TEST
+       tristate "KUnit tests for Input" if !KUNIT_ALL_TESTS
+       depends on INPUT && KUNIT=y
+       default KUNIT_ALL_TESTS
+       help
+         Say Y here if you want to build the KUnit tests for the input
+         subsystem.
+
+         If in doubt, say "N".
+
 config INPUT_APMPOWER
        tristate "Input Power Event -> APM Bridge" if EXPERT
        depends on INPUT && APM_EMULATION
index 2266c7d010efca94d348881dcb40233422508e51..c787532749214cc1fee3b4f9a6ddb713143e71cf 100644 (file)
@@ -26,6 +26,7 @@ obj-$(CONFIG_INPUT_JOYSTICK)  += joystick/
 obj-$(CONFIG_INPUT_TABLET)     += tablet/
 obj-$(CONFIG_INPUT_TOUCHSCREEN)        += touchscreen/
 obj-$(CONFIG_INPUT_MISC)       += misc/
+obj-$(CONFIG_INPUT_KUNIT_TEST) += tests/
 
 obj-$(CONFIG_INPUT_APMPOWER)   += apm-power.o
 
index 29131f1a2f067166eef3638d60546304c941e786..28be88e0e96abed47f0c0453e741b934e53ba15b 100644 (file)
@@ -126,7 +126,6 @@ static const struct xpad_device {
        char *name;
        u8 mapping;
        u8 xtype;
-       u8 packet_type;
 } xpad_device[] = {
        { 0x0079, 0x18d4, "GPD Win 2 X-Box Controller", 0, XTYPE_XBOX360 },
        { 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 },
@@ -475,6 +474,7 @@ static const struct usb_device_id xpad_table[] = {
        XPAD_XBOX360_VENDOR(0x0f0d),            /* Hori Controllers */
        XPAD_XBOXONE_VENDOR(0x0f0d),            /* Hori Controllers */
        XPAD_XBOX360_VENDOR(0x1038),            /* SteelSeries Controllers */
+       XPAD_XBOXONE_VENDOR(0x10f5),            /* Turtle Beach Controllers */
        XPAD_XBOX360_VENDOR(0x11c9),            /* Nacon GC100XF */
        XPAD_XBOX360_VENDOR(0x1209),            /* Ardwiino Controllers */
        XPAD_XBOX360_VENDOR(0x12ab),            /* X-Box 360 dance pads */
@@ -493,6 +493,7 @@ static const struct usb_device_id xpad_table[] = {
        XPAD_XBOXONE_VENDOR(0x24c6),            /* PowerA Controllers */
        XPAD_XBOX360_VENDOR(0x2563),            /* OneXPlayer Gamepad */
        XPAD_XBOX360_VENDOR(0x260d),            /* Dareu H101 */
+       XPAD_XBOX360_VENDOR(0x2c22),            /* Qanba Controllers */
        XPAD_XBOX360_VENDOR(0x2dc8),            /* 8BitDo Pro 2 Wired Controller */
        XPAD_XBOXONE_VENDOR(0x2dc8),            /* 8BitDo Pro 2 Wired Controller for Xbox */
        XPAD_XBOXONE_VENDOR(0x2e24),            /* Hyperkin Duke X-Box One pad */
@@ -559,6 +560,9 @@ struct xboxone_init_packet {
 #define GIP_MOTOR_LT BIT(3)
 #define GIP_MOTOR_ALL (GIP_MOTOR_R | GIP_MOTOR_L | GIP_MOTOR_RT | GIP_MOTOR_LT)
 
+#define GIP_WIRED_INTF_DATA 0
+#define GIP_WIRED_INTF_AUDIO 1
+
 /*
  * This packet is required for all Xbox One pads with 2015
  * or later firmware installed (or present from the factory).
@@ -1392,6 +1396,21 @@ static int xpad_start_xbox_one(struct usb_xpad *xpad)
        unsigned long flags;
        int retval;
 
+       if (usb_ifnum_to_if(xpad->udev, GIP_WIRED_INTF_AUDIO)) {
+               /*
+                * Explicitly disable the audio interface. This is needed
+                * for some controllers, such as the PowerA Enhanced Wired
+                * Controller for Series X|S (0x20d6:0x200e) to report the
+                * guide button.
+                */
+               retval = usb_set_interface(xpad->udev,
+                                          GIP_WIRED_INTF_AUDIO, 0);
+               if (retval)
+                       dev_warn(&xpad->dev->dev,
+                                "unable to disable audio interface: %d\n",
+                                retval);
+       }
+
        spin_lock_irqsave(&xpad->odata_lock, flags);
 
        /*
@@ -2003,7 +2022,7 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
        }
 
        if (xpad->xtype == XTYPE_XBOXONE &&
-           intf->cur_altsetting->desc.bInterfaceNumber != 0) {
+           intf->cur_altsetting->desc.bInterfaceNumber != GIP_WIRED_INTF_DATA) {
                /*
                 * The Xbox One controller lists three interfaces all with the
                 * same interface class, subclass and protocol. Differentiate by
index 5496482a38c1b05a023d88333a20746694b2bdce..c42f86ad0766b560f54ca45b32dd9341fea4ea02 100644 (file)
@@ -770,6 +770,9 @@ gpio_keys_get_devtree_pdata(struct device *dev)
                                             &button->type))
                        button->type = EV_KEY;
 
+               fwnode_property_read_u32(child, "linux,input-value",
+                                        (u32 *)&button->value);
+
                button->wakeup =
                        fwnode_property_read_bool(child, "wakeup-source") ||
                        /* legacy name */
index db793a550c258c35f8795b53e87f1589dd46a765..02ceebad7bdaaddc3e24436d4f0ac97ae06ceb6e 100644 (file)
@@ -320,7 +320,7 @@ static int iqs62x_keys_remove(struct platform_device *pdev)
        if (ret)
                dev_err(&pdev->dev, "Failed to unregister notifier: %d\n", ret);
 
-       return ret;
+       return 0;
 }
 
 static struct platform_driver iqs62x_keys_platform_driver = {
index 203310727d88e08a0f44c44310653be832d51038..a1b037891af25f0b173e5bb35aed03ee1c3d907a 100644 (file)
@@ -425,14 +425,12 @@ matrix_keypad_parse_dt(struct device *dev)
                return ERR_PTR(-EINVAL);
        }
 
-       if (of_get_property(np, "linux,no-autorepeat", NULL))
-               pdata->no_autorepeat = true;
+       pdata->no_autorepeat = of_property_read_bool(np, "linux,no-autorepeat");
 
        pdata->wakeup = of_property_read_bool(np, "wakeup-source") ||
                        of_property_read_bool(np, "linux,wakeup"); /* legacy */
 
-       if (of_get_property(np, "gpio-activelow", NULL))
-               pdata->active_low = true;
+       pdata->active_low = of_property_read_bool(np, "gpio-activelow");
 
        pdata->drive_inactive_cols =
                of_property_read_bool(np, "drive-inactive-cols");
index 4426120398b029e927a18a7dbf5284d3d9d5b1df..9f085d5679dbbccb5dcf6b38e955e887add6ecea 100644 (file)
@@ -274,8 +274,7 @@ static int omap4_keypad_parse_dt(struct device *dev,
        if (err)
                return err;
 
-       if (of_get_property(np, "linux,input-no-autorepeat", NULL))
-               keypad_data->no_autorepeat = true;
+       keypad_data->no_autorepeat = of_property_read_bool(np, "linux,input-no-autorepeat");
 
        return 0;
 }
index 09e883ea13520db35e8f298faa8b70ec97a0b266..d85dd2489293463cfeabf00b1414834806b563ca 100644 (file)
@@ -291,8 +291,7 @@ samsung_keypad_parse_dt(struct device *dev)
                *keymap++ = KEY(row, col, key_code);
        }
 
-       if (of_get_property(np, "linux,input-no-autorepeat", NULL))
-               pdata->no_autorepeat = true;
+       pdata->no_autorepeat = of_property_read_bool(np, "linux,input-no-autorepeat");
 
        pdata->wakeup = of_property_read_bool(np, "wakeup-source") ||
                        /* legacy name */
index b6e83324f97a3ab3dab33bdde7652ad01679fd00..0d27324af809b2a01be24248a93ce172bf4c7158 100644 (file)
@@ -259,7 +259,7 @@ static struct platform_driver keyscan_device_driver = {
        .driver         = {
                .name   = "st-keyscan",
                .pm     = pm_sleep_ptr(&keyscan_dev_pm_ops),
-               .of_match_table = of_match_ptr(keyscan_of_match),
+               .of_match_table = keyscan_of_match,
        }
 };
 
index da4019cf0c8372f35e2f01b8ea9361458785fcfd..d5a6c7d8eb25d0f57f40096dabc707fb01105c50 100644 (file)
@@ -504,8 +504,7 @@ static int tegra_kbc_parse_dt(struct tegra_kbc *kbc)
        if (!of_property_read_u32(np, "nvidia,repeat-delay-ms", &prop))
                kbc->repeat_cnt = prop;
 
-       if (of_find_property(np, "nvidia,needs-ghost-filter", NULL))
-               kbc->use_ghost_filter = true;
+       kbc->use_ghost_filter = of_property_present(np, "nvidia,needs-ghost-filter");
 
        if (of_property_read_bool(np, "wakeup-source") ||
            of_property_read_bool(np, "nvidia,wakeup-source")) /* legacy */
index 6627e65f06e5ef11dc610a044711c78ee848d708..4e20571cb4c3820c026271aec5493e59628373e1 100644 (file)
@@ -354,7 +354,7 @@ static struct i2c_driver tm2_touchkey_driver = {
        .driver = {
                .name = TM2_TOUCHKEY_DEV_NAME,
                .pm = pm_sleep_ptr(&tm2_touchkey_pm_ops),
-               .of_match_table = of_match_ptr(tm2_touchkey_of_match),
+               .of_match_table = tm2_touchkey_of_match,
        },
        .probe_new = tm2_touchkey_probe,
        .id_table = tm2_touchkey_id_table,
index 5c2d0c06d2a53166b222743106d417dbb6010b74..81a54a59e13c4411e7f831e49f7c99424aae2750 100644 (file)
@@ -119,6 +119,17 @@ config INPUT_ATMEL_CAPTOUCH
          To compile this driver as a module, choose M here: the
          module will be called atmel_captouch.
 
+config INPUT_BBNSM_PWRKEY
+       tristate "NXP BBNSM Power Key Driver"
+       depends on ARCH_MXC || COMPILE_TEST
+       depends on OF
+       help
+         This is the bbnsm powerkey driver for the NXP i.MX application
+         processors.
+
+         To compile this driver as a module, choose M here; the
+         module will be called bbnsm_pwrkey.
+
 config INPUT_BMA150
        tristate "BMA150/SMB380 acceleration sensor support"
        depends on I2C
index 61949263300d5a39d22770860c0d9159fc87dea8..04296a4abe8e87ac41873d4451abc8e3c00d02a5 100644 (file)
@@ -21,6 +21,7 @@ obj-$(CONFIG_INPUT_ATC260X_ONKEY)     += atc260x-onkey.o
 obj-$(CONFIG_INPUT_ATI_REMOTE2)                += ati_remote2.o
 obj-$(CONFIG_INPUT_ATLAS_BTNS)         += atlas_btns.o
 obj-$(CONFIG_INPUT_ATMEL_CAPTOUCH)     += atmel_captouch.o
+obj-$(CONFIG_INPUT_BBNSM_PWRKEY)       += nxp-bbnsm-pwrkey.o
 obj-$(CONFIG_INPUT_BMA150)             += bma150.o
 obj-$(CONFIG_INPUT_CM109)              += cm109.o
 obj-$(CONFIG_INPUT_CMA3000)            += cma3000_d0x.o
index e6feb73bb52be53f61a82684d21314c15635abb3..1772846708d28db948201cff745daadd2f0ee05a 100644 (file)
@@ -325,8 +325,6 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq,
        input_dev->open = cma3000_open;
        input_dev->close = cma3000_close;
 
-        __set_bit(EV_ABS, input_dev->evbit);
-
        input_set_abs_params(input_dev, ABS_X,
                        -data->g_range, data->g_range, pdata->fuzz_x, 0);
        input_set_abs_params(input_dev, ABS_Y,
index 199bc17ddb1df149cc5c65038ff3ba3440d58c2c..afc0d6dc5787ceb4300bfb7d7f9cd9f84fc9ac51 100644 (file)
@@ -265,7 +265,7 @@ static inline int hp_sdc_rtc_read_ct(struct timespec64 *res) {
        return 0;
 }
 
-static int hp_sdc_rtc_proc_show(struct seq_file *m, void *v)
+static int __maybe_unused hp_sdc_rtc_proc_show(struct seq_file *m, void *v)
 {
 #define YN(bit) ("no")
 #define NY(bit) ("yes")
diff --git a/drivers/input/misc/nxp-bbnsm-pwrkey.c b/drivers/input/misc/nxp-bbnsm-pwrkey.c
new file mode 100644 (file)
index 0000000..1d99206
--- /dev/null
@@ -0,0 +1,193 @@
+// SPDX-License-Identifier: GPL-2.0+
+//
+// Copyright 2022 NXP.
+
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/input.h>
+#include <linux/interrupt.h>
+#include <linux/io.h>
+#include <linux/jiffies.h>
+#include <linux/kernel.h>
+#include <linux/mfd/syscon.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_address.h>
+#include <linux/platform_device.h>
+#include <linux/pm_wakeirq.h>
+#include <linux/regmap.h>
+
+#define BBNSM_CTRL             0x8
+#define BBNSM_INT_EN           0x10
+#define BBNSM_EVENTS           0x14
+#define BBNSM_PAD_CTRL         0x24
+
+#define BBNSM_BTN_PRESSED      BIT(7)
+#define BBNSM_PWR_ON           BIT(6)
+#define BBNSM_BTN_OFF          BIT(5)
+#define BBNSM_EMG_OFF          BIT(4)
+#define BBNSM_PWRKEY_EVENTS    (BBNSM_PWR_ON | BBNSM_BTN_OFF | BBNSM_EMG_OFF)
+#define BBNSM_DP_EN            BIT(24)
+
+#define DEBOUNCE_TIME          30
+#define REPEAT_INTERVAL                60
+
+struct bbnsm_pwrkey {
+       struct regmap *regmap;
+       int irq;
+       int keycode;
+       int keystate;  /* 1:pressed */
+       struct timer_list check_timer;
+       struct input_dev *input;
+};
+
+static void bbnsm_pwrkey_check_for_events(struct timer_list *t)
+{
+       struct bbnsm_pwrkey *bbnsm = from_timer(bbnsm, t, check_timer);
+       struct input_dev *input = bbnsm->input;
+       u32 state;
+
+       regmap_read(bbnsm->regmap, BBNSM_EVENTS, &state);
+
+       state = state & BBNSM_BTN_PRESSED ? 1 : 0;
+
+       /* only report new event if status changed */
+       if (state ^ bbnsm->keystate) {
+               bbnsm->keystate = state;
+               input_event(input, EV_KEY, bbnsm->keycode, state);
+               input_sync(input);
+               pm_relax(bbnsm->input->dev.parent);
+       }
+
+       /* repeat check if pressed long */
+       if (state)
+               mod_timer(&bbnsm->check_timer,
+                         jiffies + msecs_to_jiffies(REPEAT_INTERVAL));
+}
+
+static irqreturn_t bbnsm_pwrkey_interrupt(int irq, void *dev_id)
+{
+       struct platform_device *pdev = dev_id;
+       struct bbnsm_pwrkey *bbnsm = platform_get_drvdata(pdev);
+       u32 event;
+
+       regmap_read(bbnsm->regmap, BBNSM_EVENTS, &event);
+       if (!(event & BBNSM_BTN_OFF))
+               return IRQ_NONE;
+
+       pm_wakeup_event(bbnsm->input->dev.parent, 0);
+
+       mod_timer(&bbnsm->check_timer,
+                  jiffies + msecs_to_jiffies(DEBOUNCE_TIME));
+
+       /* clear PWR OFF */
+       regmap_write(bbnsm->regmap, BBNSM_EVENTS, BBNSM_BTN_OFF);
+
+       return IRQ_HANDLED;
+}
+
+static void bbnsm_pwrkey_act(void *pdata)
+{
+       struct bbnsm_pwrkey *bbnsm = pdata;
+
+       timer_shutdown_sync(&bbnsm->check_timer);
+}
+
+static int bbnsm_pwrkey_probe(struct platform_device *pdev)
+{
+       struct bbnsm_pwrkey *bbnsm;
+       struct input_dev *input;
+       struct device_node *np = pdev->dev.of_node;
+       int error;
+
+       bbnsm = devm_kzalloc(&pdev->dev, sizeof(*bbnsm), GFP_KERNEL);
+       if (!bbnsm)
+               return -ENOMEM;
+
+       bbnsm->regmap = syscon_node_to_regmap(np->parent);
+       if (IS_ERR(bbnsm->regmap)) {
+               dev_err(&pdev->dev, "bbnsm pwerkey get regmap failed\n");
+               return PTR_ERR(bbnsm->regmap);
+       }
+
+       if (device_property_read_u32(&pdev->dev, "linux,code",
+                                    &bbnsm->keycode)) {
+               bbnsm->keycode = KEY_POWER;
+               dev_warn(&pdev->dev, "key code is not specified, using default KEY_POWER\n");
+       }
+
+       bbnsm->irq = platform_get_irq(pdev, 0);
+       if (bbnsm->irq < 0)
+               return -EINVAL;
+
+       /* config the BBNSM power related register */
+       regmap_update_bits(bbnsm->regmap, BBNSM_CTRL, BBNSM_DP_EN, BBNSM_DP_EN);
+
+       /* clear the unexpected interrupt before driver ready */
+       regmap_write_bits(bbnsm->regmap, BBNSM_EVENTS, BBNSM_PWRKEY_EVENTS,
+                         BBNSM_PWRKEY_EVENTS);
+
+       timer_setup(&bbnsm->check_timer, bbnsm_pwrkey_check_for_events, 0);
+
+       input = devm_input_allocate_device(&pdev->dev);
+       if (!input) {
+               dev_err(&pdev->dev, "failed to allocate the input device\n");
+               return -ENOMEM;
+       }
+
+       input->name = pdev->name;
+       input->phys = "bbnsm-pwrkey/input0";
+       input->id.bustype = BUS_HOST;
+
+       input_set_capability(input, EV_KEY, bbnsm->keycode);
+
+       /* input customer action to cancel release timer */
+       error = devm_add_action(&pdev->dev, bbnsm_pwrkey_act, bbnsm);
+       if (error) {
+               dev_err(&pdev->dev, "failed to register remove action\n");
+               return error;
+       }
+
+       bbnsm->input = input;
+       platform_set_drvdata(pdev, bbnsm);
+
+       error = devm_request_irq(&pdev->dev, bbnsm->irq, bbnsm_pwrkey_interrupt,
+                                IRQF_SHARED, pdev->name, pdev);
+       if (error) {
+               dev_err(&pdev->dev, "interrupt not available.\n");
+               return error;
+       }
+
+       error = input_register_device(input);
+       if (error) {
+               dev_err(&pdev->dev, "failed to register input device\n");
+               return error;
+       }
+
+       device_init_wakeup(&pdev->dev, true);
+       error = dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq);
+       if (error)
+               dev_warn(&pdev->dev, "irq wake enable failed.\n");
+
+       return 0;
+}
+
+static const struct of_device_id bbnsm_pwrkey_ids[] = {
+       { .compatible = "nxp,imx93-bbnsm-pwrkey" },
+       { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, bbnsm_pwrkey_ids);
+
+static struct platform_driver bbnsm_pwrkey_driver = {
+       .driver = {
+               .name = "bbnsm_pwrkey",
+               .of_match_table = bbnsm_pwrkey_ids,
+       },
+       .probe = bbnsm_pwrkey_probe,
+};
+module_platform_driver(bbnsm_pwrkey_driver);
+
+MODULE_AUTHOR("Jacky Bai <ping.bai@nxp.com>");
+MODULE_DESCRIPTION("NXP bbnsm power key Driver");
+MODULE_LICENSE("GPL");
index 50a0134b6901b7c4f1968c50fde595d751970c00..f2e093b0b9982d238cca68454c0fbdbef174a81d 100644 (file)
@@ -285,7 +285,7 @@ void rmi_unregister_function(struct rmi_function *fn)
 }
 
 /**
- * rmi_register_function_handler - register a handler for an RMI function
+ * __rmi_register_function_handler - register a handler for an RMI function
  * @handler: RMI handler that should be registered.
  * @owner: pointer to module that implements the handler
  * @mod_name: name of the module implementing the handler
diff --git a/drivers/input/tests/.kunitconfig b/drivers/input/tests/.kunitconfig
new file mode 100644 (file)
index 0000000..2f5bedf
--- /dev/null
@@ -0,0 +1,3 @@
+CONFIG_KUNIT=y
+CONFIG_INPUT=y
+CONFIG_INPUT_KUNIT_TEST=y
diff --git a/drivers/input/tests/Makefile b/drivers/input/tests/Makefile
new file mode 100644 (file)
index 0000000..90cf954
--- /dev/null
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+
+obj-$(CONFIG_INPUT_KUNIT_TEST) += input_test.o
diff --git a/drivers/input/tests/input_test.c b/drivers/input/tests/input_test.c
new file mode 100644 (file)
index 0000000..e5a6c1a
--- /dev/null
@@ -0,0 +1,150 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * KUnit test for the input core.
+ *
+ * Copyright (c) 2023 Red Hat Inc
+ */
+
+#include <linux/delay.h>
+#include <linux/input.h>
+
+#include <kunit/test.h>
+
+#define POLL_INTERVAL 100
+
+static int input_test_init(struct kunit *test)
+{
+       struct input_dev *input_dev;
+       int ret;
+
+       input_dev = input_allocate_device();
+       KUNIT_ASSERT_NOT_ERR_OR_NULL(test, input_dev);
+
+       input_dev->name = "Test input device";
+       input_dev->id.bustype = BUS_VIRTUAL;
+       input_dev->id.vendor = 1;
+       input_dev->id.product = 1;
+       input_dev->id.version = 1;
+       input_set_capability(input_dev, EV_KEY, BTN_LEFT);
+       input_set_capability(input_dev, EV_KEY, BTN_RIGHT);
+
+       ret = input_register_device(input_dev);
+       if (ret) {
+               input_free_device(input_dev);
+               KUNIT_ASSERT_FAILURE(test, "Register device failed: %d", ret);
+       }
+
+       test->priv = input_dev;
+
+       return 0;
+}
+
+static void input_test_exit(struct kunit *test)
+{
+       struct input_dev *input_dev = test->priv;
+
+       input_unregister_device(input_dev);
+       input_free_device(input_dev);
+}
+
+static void input_test_poll(struct input_dev *input) { }
+
+static void input_test_polling(struct kunit *test)
+{
+       struct input_dev *input_dev = test->priv;
+
+       /* Must fail because a poll handler has not been set-up yet */
+       KUNIT_ASSERT_EQ(test, input_get_poll_interval(input_dev), -EINVAL);
+
+       KUNIT_ASSERT_EQ(test, input_setup_polling(input_dev, input_test_poll), 0);
+
+       input_set_poll_interval(input_dev, POLL_INTERVAL);
+
+       /* Must succeed because poll handler was set-up and poll interval set */
+       KUNIT_ASSERT_EQ(test, input_get_poll_interval(input_dev), POLL_INTERVAL);
+}
+
+static void input_test_timestamp(struct kunit *test)
+{
+       const ktime_t invalid_timestamp = ktime_set(0, 0);
+       struct input_dev *input_dev = test->priv;
+       ktime_t *timestamp, time;
+
+       timestamp = input_get_timestamp(input_dev);
+       time = timestamp[INPUT_CLK_MONO];
+
+       /* The returned timestamp must always be valid */
+       KUNIT_ASSERT_EQ(test, ktime_compare(time, invalid_timestamp), 1);
+
+       time = ktime_get();
+       input_set_timestamp(input_dev, time);
+
+       timestamp = input_get_timestamp(input_dev);
+       /* The timestamp must be the same than set before */
+       KUNIT_ASSERT_EQ(test, ktime_compare(timestamp[INPUT_CLK_MONO], time), 0);
+}
+
+static void input_test_match_device_id(struct kunit *test)
+{
+       struct input_dev *input_dev = test->priv;
+       struct input_device_id id;
+
+       /*
+        * Must match when the input device bus, vendor, product, version
+        * and events capable of handling are the same and fail to match
+        * otherwise.
+        */
+       id.flags = INPUT_DEVICE_ID_MATCH_BUS;
+       id.bustype = BUS_VIRTUAL;
+       KUNIT_ASSERT_TRUE(test, input_match_device_id(input_dev, &id));
+
+       id.bustype = BUS_I2C;
+       KUNIT_ASSERT_FALSE(test, input_match_device_id(input_dev, &id));
+
+       id.flags = INPUT_DEVICE_ID_MATCH_VENDOR;
+       id.vendor = 1;
+       KUNIT_ASSERT_TRUE(test, input_match_device_id(input_dev, &id));
+
+       id.vendor = 2;
+       KUNIT_ASSERT_FALSE(test, input_match_device_id(input_dev, &id));
+
+       id.flags = INPUT_DEVICE_ID_MATCH_PRODUCT;
+       id.product = 1;
+       KUNIT_ASSERT_TRUE(test, input_match_device_id(input_dev, &id));
+
+       id.product = 2;
+       KUNIT_ASSERT_FALSE(test, input_match_device_id(input_dev, &id));
+
+       id.flags = INPUT_DEVICE_ID_MATCH_VERSION;
+       id.version = 1;
+       KUNIT_ASSERT_TRUE(test, input_match_device_id(input_dev, &id));
+
+       id.version = 2;
+       KUNIT_ASSERT_FALSE(test, input_match_device_id(input_dev, &id));
+
+       id.flags = INPUT_DEVICE_ID_MATCH_EVBIT;
+       __set_bit(EV_KEY, id.evbit);
+       KUNIT_ASSERT_TRUE(test, input_match_device_id(input_dev, &id));
+
+       __set_bit(EV_ABS, id.evbit);
+       KUNIT_ASSERT_FALSE(test, input_match_device_id(input_dev, &id));
+}
+
+static struct kunit_case input_tests[] = {
+       KUNIT_CASE(input_test_polling),
+       KUNIT_CASE(input_test_timestamp),
+       KUNIT_CASE(input_test_match_device_id),
+       { /* sentinel */ }
+};
+
+static struct kunit_suite input_test_suite = {
+       .name = "input_core",
+       .init = input_test_init,
+       .exit = input_test_exit,
+       .test_cases = input_tests,
+};
+
+kunit_test_suite(input_test_suite);
+
+MODULE_AUTHOR("Javier Martinez Canillas <javierm@redhat.com>");
+MODULE_LICENSE("GPL");
index 1a2049b336a6eb043ea15ba99aa743a20b9951d2..143ff43c67ae339ed38e33ac32f8db85afff9744 100644 (file)
@@ -654,6 +654,16 @@ config TOUCHSCREEN_MTOUCH
          To compile this driver as a module, choose M here: the
          module will be called mtouch.
 
+config TOUCHSCREEN_NOVATEK_NVT_TS
+       tristate "Novatek NVT-ts touchscreen support"
+       depends on I2C
+       help
+         Say Y here if you have a Novatek NVT-ts touchscreen.
+         If unsure, say N.
+
+         To compile this driver as a module, choose M here: the
+         module will be called novatek-nvt-ts.
+
 config TOUCHSCREEN_IMAGIS
        tristate "Imagis touchscreen support"
        depends on I2C
@@ -758,6 +768,7 @@ config TOUCHSCREEN_PENMOUNT
 config TOUCHSCREEN_EDT_FT5X06
        tristate "EDT FocalTech FT5x06 I2C Touchscreen support"
        depends on I2C
+       select REGMAP_I2C
        help
          Say Y here if you have an EDT "Polytouch" touchscreen based
          on the FocalTech FT5x06 family of controllers connected to
index f2fd28cc34a6d44abf2e63a6e26afdc877c6b0e8..159cd5136fdbca6938d31e2772296c6b73953ec2 100644 (file)
@@ -67,6 +67,7 @@ obj-$(CONFIG_TOUCHSCREEN_MMS114)      += mms114.o
 obj-$(CONFIG_TOUCHSCREEN_MSG2638)      += msg2638.o
 obj-$(CONFIG_TOUCHSCREEN_MTOUCH)       += mtouch.o
 obj-$(CONFIG_TOUCHSCREEN_MK712)                += mk712.o
+obj-$(CONFIG_TOUCHSCREEN_NOVATEK_NVT_TS)       += novatek-nvt-ts.o
 obj-$(CONFIG_TOUCHSCREEN_HP600)                += hp680_ts_input.o
 obj-$(CONFIG_TOUCHSCREEN_HP7XX)                += jornada720_ts.o
 obj-$(CONFIG_TOUCHSCREEN_IPAQ_MICRO)   += ipaq-micro-ts.o
index 35e2fe9911a455353cfb5514d2e8dcb6d7fb65b3..9c84235327bfb778e44740eaf2356d8a254ab794 100644 (file)
@@ -511,7 +511,7 @@ static struct platform_driver iproc_ts_driver = {
        .probe = iproc_ts_probe,
        .driver = {
                .name   = IPROC_TS_NAME,
-               .of_match_table = of_match_ptr(iproc_ts_of_match),
+               .of_match_table = iproc_ts_of_match,
        },
 };
 
index 2746649561c7105109fadb468f2adba61aa338c7..24ab9e9f5b21e220fae6100aa226c55cf37f3549 100644 (file)
@@ -3,6 +3,7 @@
  * Copyright (C) 2012 Simon Budig, <simon.budig@kernelconcepts.de>
  * Daniel Wagener <daniel.wagener@kernelconcepts.de> (M09 firmware support)
  * Lothar Waßmann <LW@KARO-electronics.de> (DT support)
+ * Dario Binacchi <dario.binacchi@amarulasolutions.com> (regmap support)
  */
 
 /*
@@ -26,6 +27,7 @@
 #include <linux/module.h>
 #include <linux/property.h>
 #include <linux/ratelimit.h>
+#include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
 #include <linux/slab.h>
 #include <linux/uaccess.h>
@@ -75,6 +77,9 @@
 #define EDT_DEFAULT_NUM_X              1024
 #define EDT_DEFAULT_NUM_Y              1024
 
+#define M06_REG_CMD(factory) ((factory) ? 0xf3 : 0xfc)
+#define M06_REG_ADDR(factory, addr) ((factory) ? (addr) & 0x7f : (addr) & 0x3f)
+
 enum edt_pmode {
        EDT_PMODE_NOT_SUPPORTED,
        EDT_PMODE_HIBERNATE,
@@ -112,6 +117,8 @@ struct edt_ft5x06_ts_data {
        struct gpio_desc *reset_gpio;
        struct gpio_desc *wake_gpio;
 
+       struct regmap *regmap;
+
 #if defined(CONFIG_DEBUG_FS)
        struct dentry *debug_dir;
        u8 *raw_buffer;
@@ -128,6 +135,10 @@ struct edt_ft5x06_ts_data {
        int offset_y;
        int report_rate;
        int max_support_points;
+       int point_len;
+       u8 tdata_cmd;
+       int tdata_len;
+       int tdata_offset;
 
        char name[EDT_NAME_LEN];
        char fw_version[EDT_NAME_LEN];
@@ -142,37 +153,10 @@ struct edt_i2c_chip_data {
        int  max_support_points;
 };
 
-static int edt_ft5x06_ts_readwrite(struct i2c_client *client,
-                                  u16 wr_len, u8 *wr_buf,
-                                  u16 rd_len, u8 *rd_buf)
-{
-       struct i2c_msg wrmsg[2];
-       int i = 0;
-       int ret;
-
-       if (wr_len) {
-               wrmsg[i].addr  = client->addr;
-               wrmsg[i].flags = 0;
-               wrmsg[i].len = wr_len;
-               wrmsg[i].buf = wr_buf;
-               i++;
-       }
-       if (rd_len) {
-               wrmsg[i].addr  = client->addr;
-               wrmsg[i].flags = I2C_M_RD;
-               wrmsg[i].len = rd_len;
-               wrmsg[i].buf = rd_buf;
-               i++;
-       }
-
-       ret = i2c_transfer(client->adapter, wrmsg, i);
-       if (ret < 0)
-               return ret;
-       if (ret != i)
-               return -EIO;
-
-       return 0;
-}
+static const struct regmap_config edt_ft5x06_i2c_regmap_config = {
+       .reg_bits = 8,
+       .val_bits = 8,
+};
 
 static bool edt_ft5x06_ts_check_crc(struct edt_ft5x06_ts_data *tsdata,
                                    u8 *buf, int buflen)
@@ -183,78 +167,154 @@ static bool edt_ft5x06_ts_check_crc(struct edt_ft5x06_ts_data *tsdata,
        for (i = 0; i < buflen - 1; i++)
                crc ^= buf[i];
 
-       if (crc != buf[buflen-1]) {
+       if (crc != buf[buflen - 1]) {
                tsdata->crc_errors++;
                dev_err_ratelimited(&tsdata->client->dev,
                                    "crc error: 0x%02x expected, got 0x%02x\n",
-                                   crc, buf[buflen-1]);
+                                   crc, buf[buflen - 1]);
                return false;
        }
 
        return true;
 }
 
-static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev_id)
+static int edt_M06_i2c_read(void *context, const void *reg_buf, size_t reg_size,
+                           void *val_buf, size_t val_size)
 {
-       struct edt_ft5x06_ts_data *tsdata = dev_id;
-       struct device *dev = &tsdata->client->dev;
-       u8 cmd;
-       u8 rdbuf[63];
-       int i, type, x, y, id;
-       int offset, tplen, datalen, crclen;
-       int error;
+       struct device *dev = context;
+       struct i2c_client *i2c = to_i2c_client(dev);
+       struct edt_ft5x06_ts_data *tsdata = i2c_get_clientdata(i2c);
+       struct i2c_msg xfer[2];
+       bool reg_read = false;
+       u8 addr;
+       u8 wlen;
+       u8 wbuf[4], rbuf[3];
+       int ret;
 
-       switch (tsdata->version) {
-       case EDT_M06:
-               cmd = 0xf9; /* tell the controller to send touch data */
-               offset = 5; /* where the actual touch data starts */
-               tplen = 4;  /* data comes in so called frames */
-               crclen = 1; /* length of the crc data */
+       addr = *((u8 *)reg_buf);
+       wbuf[0] = addr;
+       switch (addr) {
+       case 0xf5:
+               wlen = 3;
+               wbuf[0] = 0xf5;
+               wbuf[1] = 0xe;
+               wbuf[2] = *((u8 *)val_buf);
                break;
-
-       case EDT_M09:
-       case EDT_M12:
-       case EV_FT:
-       case GENERIC_FT:
-               cmd = 0x0;
-               offset = 3;
-               tplen = 6;
-               crclen = 0;
+       case 0xf9:
+               wlen = 1;
                break;
-
        default:
-               goto out;
+               wlen = 2;
+               reg_read = true;
+               wbuf[0] = M06_REG_CMD(tsdata->factory_mode);
+               wbuf[1] = M06_REG_ADDR(tsdata->factory_mode, addr);
+               wbuf[1] |= tsdata->factory_mode ? 0x80 : 0x40;
        }
 
-       memset(rdbuf, 0, sizeof(rdbuf));
-       datalen = tplen * tsdata->max_support_points + offset + crclen;
+       xfer[0].addr  = i2c->addr;
+       xfer[0].flags = 0;
+       xfer[0].len = wlen;
+       xfer[0].buf = wbuf;
 
-       error = edt_ft5x06_ts_readwrite(tsdata->client,
-                                       sizeof(cmd), &cmd,
-                                       datalen, rdbuf);
-       if (error) {
-               dev_err_ratelimited(dev, "Unable to fetch data, error: %d\n",
-                                   error);
-               goto out;
+       xfer[1].addr = i2c->addr;
+       xfer[1].flags = I2C_M_RD;
+       xfer[1].len = reg_read ? 2 : val_size;
+       xfer[1].buf = reg_read ? rbuf : val_buf;
+
+       ret = i2c_transfer(i2c->adapter, xfer, 2);
+       if (ret != 2) {
+               if (ret < 0)
+                       return ret;
+
+               return -EIO;
        }
 
-       /* M09/M12 does not send header or CRC */
-       if (tsdata->version == EDT_M06) {
-               if (rdbuf[0] != 0xaa || rdbuf[1] != 0xaa ||
-                       rdbuf[2] != datalen) {
+       if (addr == 0xf9) {
+               u8 *buf = (u8 *)val_buf;
+
+               if (buf[0] != 0xaa || buf[1] != 0xaa ||
+                   buf[2] != val_size) {
                        tsdata->header_errors++;
                        dev_err_ratelimited(dev,
-                                       "Unexpected header: %02x%02x%02x!\n",
-                                       rdbuf[0], rdbuf[1], rdbuf[2]);
-                       goto out;
+                                           "Unexpected header: %02x%02x%02x\n",
+                                           buf[0], buf[1], buf[2]);
+                       return -EIO;
                }
 
-               if (!edt_ft5x06_ts_check_crc(tsdata, rdbuf, datalen))
-                       goto out;
+               if (!edt_ft5x06_ts_check_crc(tsdata, val_buf, val_size))
+                       return -EIO;
+       } else if (reg_read) {
+               wbuf[2] = rbuf[0];
+               wbuf[3] = rbuf[1];
+               if (!edt_ft5x06_ts_check_crc(tsdata, wbuf, 4))
+                       return -EIO;
+
+               *((u8 *)val_buf) = rbuf[0];
+       }
+
+       return 0;
+}
+
+static int edt_M06_i2c_write(void *context, const void *data, size_t count)
+{
+       struct device *dev = context;
+       struct i2c_client *i2c = to_i2c_client(dev);
+       struct edt_ft5x06_ts_data *tsdata = i2c_get_clientdata(i2c);
+       u8 addr, val;
+       u8 wbuf[4];
+       struct i2c_msg xfer;
+       int ret;
+
+       addr = *((u8 *)data);
+       val = *((u8 *)data + 1);
+
+       wbuf[0] = M06_REG_CMD(tsdata->factory_mode);
+       wbuf[1] = M06_REG_ADDR(tsdata->factory_mode, addr);
+       wbuf[2] = val;
+       wbuf[3] = wbuf[0] ^ wbuf[1] ^ wbuf[2];
+
+       xfer.addr  = i2c->addr;
+       xfer.flags = 0;
+       xfer.len = 4;
+       xfer.buf = wbuf;
+
+       ret = i2c_transfer(i2c->adapter, &xfer, 1);
+       if (ret != 1) {
+               if (ret < 0)
+                       return ret;
+
+               return -EIO;
+       }
+
+       return 0;
+}
+
+static const struct regmap_config edt_M06_i2c_regmap_config = {
+       .reg_bits = 8,
+       .val_bits = 8,
+       .read = edt_M06_i2c_read,
+       .write = edt_M06_i2c_write,
+};
+
+static irqreturn_t edt_ft5x06_ts_isr(int irq, void *dev_id)
+{
+       struct edt_ft5x06_ts_data *tsdata = dev_id;
+       struct device *dev = &tsdata->client->dev;
+       u8 rdbuf[63];
+       int i, type, x, y, id;
+       int error;
+
+       memset(rdbuf, 0, sizeof(rdbuf));
+       error = regmap_bulk_read(tsdata->regmap, tsdata->tdata_cmd, rdbuf,
+                                tsdata->tdata_len);
+       if (error) {
+               dev_err_ratelimited(dev, "Unable to fetch data, error: %d\n",
+                                   error);
+               goto out;
        }
 
        for (i = 0; i < tsdata->max_support_points; i++) {
-               u8 *buf = &rdbuf[i * tplen + offset];
+               u8 *buf = &rdbuf[i * tsdata->point_len + tsdata->tdata_offset];
 
                type = buf[0] >> 6;
                /* ignore Reserved events */
@@ -287,79 +347,6 @@ out:
        return IRQ_HANDLED;
 }
 
-static int edt_ft5x06_register_write(struct edt_ft5x06_ts_data *tsdata,
-                                    u8 addr, u8 value)
-{
-       u8 wrbuf[4];
-
-       switch (tsdata->version) {
-       case EDT_M06:
-               wrbuf[0] = tsdata->factory_mode ? 0xf3 : 0xfc;
-               wrbuf[1] = tsdata->factory_mode ? addr & 0x7f : addr & 0x3f;
-               wrbuf[2] = value;
-               wrbuf[3] = wrbuf[0] ^ wrbuf[1] ^ wrbuf[2];
-               return edt_ft5x06_ts_readwrite(tsdata->client, 4,
-                                       wrbuf, 0, NULL);
-
-       case EDT_M09:
-       case EDT_M12:
-       case EV_FT:
-       case GENERIC_FT:
-               wrbuf[0] = addr;
-               wrbuf[1] = value;
-
-               return edt_ft5x06_ts_readwrite(tsdata->client, 2,
-                                       wrbuf, 0, NULL);
-
-       default:
-               return -EINVAL;
-       }
-}
-
-static int edt_ft5x06_register_read(struct edt_ft5x06_ts_data *tsdata,
-                                   u8 addr)
-{
-       u8 wrbuf[2], rdbuf[2];
-       int error;
-
-       switch (tsdata->version) {
-       case EDT_M06:
-               wrbuf[0] = tsdata->factory_mode ? 0xf3 : 0xfc;
-               wrbuf[1] = tsdata->factory_mode ? addr & 0x7f : addr & 0x3f;
-               wrbuf[1] |= tsdata->factory_mode ? 0x80 : 0x40;
-
-               error = edt_ft5x06_ts_readwrite(tsdata->client, 2, wrbuf, 2,
-                                               rdbuf);
-               if (error)
-                       return error;
-
-               if ((wrbuf[0] ^ wrbuf[1] ^ rdbuf[0]) != rdbuf[1]) {
-                       dev_err(&tsdata->client->dev,
-                               "crc error: 0x%02x expected, got 0x%02x\n",
-                               wrbuf[0] ^ wrbuf[1] ^ rdbuf[0],
-                               rdbuf[1]);
-                       return -EIO;
-               }
-               break;
-
-       case EDT_M09:
-       case EDT_M12:
-       case EV_FT:
-       case GENERIC_FT:
-               wrbuf[0] = addr;
-               error = edt_ft5x06_ts_readwrite(tsdata->client, 1,
-                                               wrbuf, 1, rdbuf);
-               if (error)
-                       return error;
-               break;
-
-       default:
-               return -EINVAL;
-       }
-
-       return rdbuf[0];
-}
-
 struct edt_ft5x06_attribute {
        struct device_attribute dattr;
        size_t field_offset;
@@ -393,7 +380,7 @@ static ssize_t edt_ft5x06_setting_show(struct device *dev,
        struct edt_ft5x06_attribute *attr =
                        container_of(dattr, struct edt_ft5x06_attribute, dattr);
        u8 *field = (u8 *)tsdata + attr->field_offset;
-       int val;
+       unsigned int val;
        size_t count = 0;
        int error = 0;
        u8 addr;
@@ -426,9 +413,8 @@ static ssize_t edt_ft5x06_setting_show(struct device *dev,
        }
 
        if (addr != NO_REGISTER) {
-               val = edt_ft5x06_register_read(tsdata, addr);
-               if (val < 0) {
-                       error = val;
+               error = regmap_read(tsdata->regmap, addr, &val);
+               if (error) {
                        dev_err(&tsdata->client->dev,
                                "Failed to fetch attribute %s, error %d\n",
                                dattr->attr.name, error);
@@ -501,7 +487,7 @@ static ssize_t edt_ft5x06_setting_store(struct device *dev,
        }
 
        if (addr != NO_REGISTER) {
-               error = edt_ft5x06_register_write(tsdata, addr, val);
+               error = regmap_write(tsdata->regmap, addr, val);
                if (error) {
                        dev_err(&tsdata->client->dev,
                                "Failed to update attribute %s, error: %d\n",
@@ -602,24 +588,19 @@ static const struct attribute_group edt_ft5x06_attr_group = {
 static void edt_ft5x06_restore_reg_parameters(struct edt_ft5x06_ts_data *tsdata)
 {
        struct edt_reg_addr *reg_addr = &tsdata->reg_addr;
+       struct regmap *regmap = tsdata->regmap;
 
-       edt_ft5x06_register_write(tsdata, reg_addr->reg_threshold,
-                                 tsdata->threshold);
-       edt_ft5x06_register_write(tsdata, reg_addr->reg_gain,
-                                 tsdata->gain);
+       regmap_write(regmap, reg_addr->reg_threshold, tsdata->threshold);
+       regmap_write(regmap, reg_addr->reg_gain, tsdata->gain);
        if (reg_addr->reg_offset != NO_REGISTER)
-               edt_ft5x06_register_write(tsdata, reg_addr->reg_offset,
-                                         tsdata->offset);
+               regmap_write(regmap, reg_addr->reg_offset, tsdata->offset);
        if (reg_addr->reg_offset_x != NO_REGISTER)
-               edt_ft5x06_register_write(tsdata, reg_addr->reg_offset_x,
-                                         tsdata->offset_x);
+               regmap_write(regmap, reg_addr->reg_offset_x, tsdata->offset_x);
        if (reg_addr->reg_offset_y != NO_REGISTER)
-               edt_ft5x06_register_write(tsdata, reg_addr->reg_offset_y,
-                                         tsdata->offset_y);
+               regmap_write(regmap, reg_addr->reg_offset_y, tsdata->offset_y);
        if (reg_addr->reg_report_rate != NO_REGISTER)
-               edt_ft5x06_register_write(tsdata, reg_addr->reg_report_rate,
-                                 tsdata->report_rate);
-
+               regmap_write(regmap, reg_addr->reg_report_rate,
+                            tsdata->report_rate);
 }
 
 #ifdef CONFIG_DEBUG_FS
@@ -627,7 +608,7 @@ static int edt_ft5x06_factory_mode(struct edt_ft5x06_ts_data *tsdata)
 {
        struct i2c_client *client = tsdata->client;
        int retries = EDT_SWITCH_MODE_RETRIES;
-       int ret;
+       unsigned int val;
        int error;
 
        if (tsdata->version != EDT_M06) {
@@ -649,7 +630,7 @@ static int edt_ft5x06_factory_mode(struct edt_ft5x06_ts_data *tsdata)
        }
 
        /* mode register is 0x3c when in the work mode */
-       error = edt_ft5x06_register_write(tsdata, WORK_REGISTER_OPMODE, 0x03);
+       error = regmap_write(tsdata->regmap, WORK_REGISTER_OPMODE, 0x03);
        if (error) {
                dev_err(&client->dev,
                        "failed to switch to factory mode, error %d\n", error);
@@ -660,8 +641,9 @@ static int edt_ft5x06_factory_mode(struct edt_ft5x06_ts_data *tsdata)
        do {
                mdelay(EDT_SWITCH_MODE_DELAY);
                /* mode register is 0x01 when in factory mode */
-               ret = edt_ft5x06_register_read(tsdata, FACTORY_REGISTER_OPMODE);
-               if (ret == 0x03)
+               error = regmap_read(tsdata->regmap, FACTORY_REGISTER_OPMODE,
+                                   &val);
+               if (!error && val == 0x03)
                        break;
        } while (--retries > 0);
 
@@ -687,11 +669,11 @@ static int edt_ft5x06_work_mode(struct edt_ft5x06_ts_data *tsdata)
 {
        struct i2c_client *client = tsdata->client;
        int retries = EDT_SWITCH_MODE_RETRIES;
-       int ret;
+       unsigned int val;
        int error;
 
        /* mode register is 0x01 when in the factory mode */
-       error = edt_ft5x06_register_write(tsdata, FACTORY_REGISTER_OPMODE, 0x1);
+       error = regmap_write(tsdata->regmap, FACTORY_REGISTER_OPMODE, 0x1);
        if (error) {
                dev_err(&client->dev,
                        "failed to switch to work mode, error: %d\n", error);
@@ -703,8 +685,8 @@ static int edt_ft5x06_work_mode(struct edt_ft5x06_ts_data *tsdata)
        do {
                mdelay(EDT_SWITCH_MODE_DELAY);
                /* mode register is 0x01 when in factory mode */
-               ret = edt_ft5x06_register_read(tsdata, WORK_REGISTER_OPMODE);
-               if (ret == 0x01)
+               error = regmap_read(tsdata->regmap, WORK_REGISTER_OPMODE, &val);
+               if (!error && val == 0x01)
                        break;
        } while (--retries > 0);
 
@@ -757,15 +739,16 @@ DEFINE_SIMPLE_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get,
                        edt_ft5x06_debugfs_mode_set, "%llu\n");
 
 static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,
-                               char __user *buf, size_t count, loff_t *off)
+                                               char __user *buf, size_t count,
+                                               loff_t *off)
 {
        struct edt_ft5x06_ts_data *tsdata = file->private_data;
        struct i2c_client *client = tsdata->client;
        int retries  = EDT_RAW_DATA_RETRIES;
-       int val, i, error;
+       unsigned int val;
+       int i, error;
        size_t read = 0;
        int colbytes;
-       char wrbuf[3];
        u8 *rdbuf;
 
        if (*off < 0 || *off >= tsdata->raw_bufsize)
@@ -778,29 +761,29 @@ static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,
                goto out;
        }
 
-       error = edt_ft5x06_register_write(tsdata, 0x08, 0x01);
+       error = regmap_write(tsdata->regmap, 0x08, 0x01);
        if (error) {
-               dev_dbg(&client->dev,
+               dev_err(&client->dev,
                        "failed to write 0x08 register, error %d\n", error);
                goto out;
        }
 
        do {
                usleep_range(EDT_RAW_DATA_DELAY, EDT_RAW_DATA_DELAY + 100);
-               val = edt_ft5x06_register_read(tsdata, 0x08);
-               if (val < 1)
+               error = regmap_read(tsdata->regmap, 0x08, &val);
+               if (error) {
+                       dev_err(&client->dev,
+                               "failed to read 0x08 register, error %d\n",
+                               error);
+                       goto out;
+               }
+
+               if (val == 1)
                        break;
        } while (--retries > 0);
 
-       if (val < 0) {
-               error = val;
-               dev_dbg(&client->dev,
-                       "failed to read 0x08 register, error %d\n", error);
-               goto out;
-       }
-
        if (retries == 0) {
-               dev_dbg(&client->dev,
+               dev_err(&client->dev,
                        "timed out waiting for register to settle\n");
                error = -ETIMEDOUT;
                goto out;
@@ -809,13 +792,9 @@ static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,
        rdbuf = tsdata->raw_buffer;
        colbytes = tsdata->num_y * sizeof(u16);
 
-       wrbuf[0] = 0xf5;
-       wrbuf[1] = 0x0e;
        for (i = 0; i < tsdata->num_x; i++) {
-               wrbuf[2] = i;  /* column index */
-               error = edt_ft5x06_ts_readwrite(tsdata->client,
-                                               sizeof(wrbuf), wrbuf,
-                                               colbytes, rdbuf);
+               rdbuf[0] = i;  /* column index */
+               error = regmap_bulk_read(tsdata->regmap, 0xf5, rdbuf, colbytes);
                if (error)
                        goto out;
 
@@ -891,8 +870,7 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client,
         * to have garbage in there
         */
        memset(rdbuf, 0, sizeof(rdbuf));
-       error = edt_ft5x06_ts_readwrite(client, 1, "\xBB",
-                                       EDT_NAME_LEN - 1, rdbuf);
+       error = regmap_bulk_read(tsdata->regmap, 0xBB, rdbuf, EDT_NAME_LEN - 1);
        if (error)
                return error;
 
@@ -914,6 +892,14 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client,
                        *p++ = '\0';
                strscpy(model_name, rdbuf + 1, EDT_NAME_LEN);
                strscpy(fw_version, p ? p : "", EDT_NAME_LEN);
+
+               regmap_exit(tsdata->regmap);
+               tsdata->regmap = regmap_init_i2c(client,
+                                                &edt_M06_i2c_regmap_config);
+               if (IS_ERR(tsdata->regmap)) {
+                       dev_err(&client->dev, "regmap allocation failed\n");
+                       return PTR_ERR(tsdata->regmap);
+               }
        } else if (!strncasecmp(rdbuf, "EP0", 3)) {
                tsdata->version = EDT_M12;
 
@@ -940,15 +926,13 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client,
                 */
                tsdata->version = GENERIC_FT;
 
-               error = edt_ft5x06_ts_readwrite(client, 1, "\xA6",
-                                               2, rdbuf);
+               error = regmap_bulk_read(tsdata->regmap, 0xA6, rdbuf, 2);
                if (error)
                        return error;
 
                strscpy(fw_version, rdbuf, 2);
 
-               error = edt_ft5x06_ts_readwrite(client, 1, "\xA8",
-                                               1, rdbuf);
+               error = regmap_bulk_read(tsdata->regmap, 0xA8, rdbuf, 1);
                if (error)
                        return error;
 
@@ -965,20 +949,19 @@ static int edt_ft5x06_ts_identify(struct i2c_client *client,
                case 0x70:   /* EDT EP0700M09 */
                        tsdata->version = EDT_M09;
                        snprintf(model_name, EDT_NAME_LEN, "EP0%i%i0M09",
-                               rdbuf[0] >> 4, rdbuf[0] & 0x0F);
+                                rdbuf[0] >> 4, rdbuf[0] & 0x0F);
                        break;
                case 0xa1:   /* EDT EP1010ML00 */
                        tsdata->version = EDT_M09;
                        snprintf(model_name, EDT_NAME_LEN, "EP%i%i0ML00",
-                               rdbuf[0] >> 4, rdbuf[0] & 0x0F);
+                                rdbuf[0] >> 4, rdbuf[0] & 0x0F);
                        break;
                case 0x5a:   /* Solomon Goldentek Display */
                        snprintf(model_name, EDT_NAME_LEN, "GKTW50SCED1R0");
                        break;
                case 0x59:  /* Evervision Display with FT5xx6 TS */
                        tsdata->version = EV_FT;
-                       error = edt_ft5x06_ts_readwrite(client, 1, "\x53",
-                                                       1, rdbuf);
+                       error = regmap_bulk_read(tsdata->regmap, 0x53, rdbuf, 1);
                        if (error)
                                return error;
                        strscpy(fw_version, rdbuf, 1);
@@ -1000,42 +983,40 @@ static void edt_ft5x06_ts_get_defaults(struct device *dev,
                                       struct edt_ft5x06_ts_data *tsdata)
 {
        struct edt_reg_addr *reg_addr = &tsdata->reg_addr;
+       struct regmap *regmap = tsdata->regmap;
        u32 val;
        int error;
 
        error = device_property_read_u32(dev, "threshold", &val);
        if (!error) {
-               edt_ft5x06_register_write(tsdata, reg_addr->reg_threshold, val);
+               regmap_write(regmap, reg_addr->reg_threshold, val);
                tsdata->threshold = val;
        }
 
        error = device_property_read_u32(dev, "gain", &val);
        if (!error) {
-               edt_ft5x06_register_write(tsdata, reg_addr->reg_gain, val);
+               regmap_write(regmap, reg_addr->reg_gain, val);
                tsdata->gain = val;
        }
 
        error = device_property_read_u32(dev, "offset", &val);
        if (!error) {
                if (reg_addr->reg_offset != NO_REGISTER)
-                       edt_ft5x06_register_write(tsdata,
-                                                 reg_addr->reg_offset, val);
+                       regmap_write(regmap, reg_addr->reg_offset, val);
                tsdata->offset = val;
        }
 
        error = device_property_read_u32(dev, "offset-x", &val);
        if (!error) {
                if (reg_addr->reg_offset_x != NO_REGISTER)
-                       edt_ft5x06_register_write(tsdata,
-                                                 reg_addr->reg_offset_x, val);
+                       regmap_write(regmap, reg_addr->reg_offset_x, val);
                tsdata->offset_x = val;
        }
 
        error = device_property_read_u32(dev, "offset-y", &val);
        if (!error) {
                if (reg_addr->reg_offset_y != NO_REGISTER)
-                       edt_ft5x06_register_write(tsdata,
-                                                 reg_addr->reg_offset_y, val);
+                       regmap_write(regmap, reg_addr->reg_offset_y, val);
                tsdata->offset_y = val;
        }
 }
@@ -1043,30 +1024,50 @@ static void edt_ft5x06_ts_get_defaults(struct device *dev,
 static void edt_ft5x06_ts_get_parameters(struct edt_ft5x06_ts_data *tsdata)
 {
        struct edt_reg_addr *reg_addr = &tsdata->reg_addr;
+       struct regmap *regmap = tsdata->regmap;
+       unsigned int val;
 
-       tsdata->threshold = edt_ft5x06_register_read(tsdata,
-                                                    reg_addr->reg_threshold);
-       tsdata->gain = edt_ft5x06_register_read(tsdata, reg_addr->reg_gain);
+       regmap_read(regmap, reg_addr->reg_threshold, &tsdata->threshold);
+       regmap_read(regmap, reg_addr->reg_gain, &tsdata->gain);
        if (reg_addr->reg_offset != NO_REGISTER)
-               tsdata->offset =
-                       edt_ft5x06_register_read(tsdata, reg_addr->reg_offset);
+               regmap_read(regmap, reg_addr->reg_offset, &tsdata->offset);
        if (reg_addr->reg_offset_x != NO_REGISTER)
-               tsdata->offset_x = edt_ft5x06_register_read(tsdata,
-                                               reg_addr->reg_offset_x);
+               regmap_read(regmap, reg_addr->reg_offset_x, &tsdata->offset_x);
        if (reg_addr->reg_offset_y != NO_REGISTER)
-               tsdata->offset_y = edt_ft5x06_register_read(tsdata,
-                                               reg_addr->reg_offset_y);
+               regmap_read(regmap, reg_addr->reg_offset_y, &tsdata->offset_y);
        if (reg_addr->reg_report_rate != NO_REGISTER)
-               tsdata->report_rate = edt_ft5x06_register_read(tsdata,
-                                               reg_addr->reg_report_rate);
+               regmap_read(regmap, reg_addr->reg_report_rate,
+                           &tsdata->report_rate);
        tsdata->num_x = EDT_DEFAULT_NUM_X;
-       if (reg_addr->reg_num_x != NO_REGISTER)
-               tsdata->num_x = edt_ft5x06_register_read(tsdata,
-                                                        reg_addr->reg_num_x);
+       if (reg_addr->reg_num_x != NO_REGISTER) {
+               if (!regmap_read(regmap, reg_addr->reg_num_x, &val))
+                       tsdata->num_x = val;
+       }
        tsdata->num_y = EDT_DEFAULT_NUM_Y;
-       if (reg_addr->reg_num_y != NO_REGISTER)
-               tsdata->num_y = edt_ft5x06_register_read(tsdata,
-                                                        reg_addr->reg_num_y);
+       if (reg_addr->reg_num_y != NO_REGISTER) {
+               if (!regmap_read(regmap, reg_addr->reg_num_y, &val))
+                       tsdata->num_y = val;
+       }
+}
+
+static void edt_ft5x06_ts_set_tdata_parameters(struct edt_ft5x06_ts_data *tsdata)
+{
+       int crclen;
+
+       if (tsdata->version == EDT_M06) {
+               tsdata->tdata_cmd = 0xf9;
+               tsdata->tdata_offset = 5;
+               tsdata->point_len = 4;
+               crclen = 1;
+       } else {
+               tsdata->tdata_cmd = 0x0;
+               tsdata->tdata_offset = 3;
+               tsdata->point_len = 6;
+               crclen = 0;
+       }
+
+       tsdata->tdata_len = tsdata->point_len * tsdata->max_support_points +
+               tsdata->tdata_offset + crclen;
 }
 
 static void edt_ft5x06_ts_set_regs(struct edt_ft5x06_ts_data *tsdata)
@@ -1136,7 +1137,7 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
        const struct i2c_device_id *id = i2c_client_get_device_id(client);
        const struct edt_i2c_chip_data *chip_data;
        struct edt_ft5x06_ts_data *tsdata;
-       u8 buf[2] = { 0xfc, 0x00 };
+       unsigned int val;
        struct input_dev *input;
        unsigned long irq_flags;
        int error;
@@ -1150,6 +1151,12 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
                return -ENOMEM;
        }
 
+       tsdata->regmap = regmap_init_i2c(client, &edt_ft5x06_i2c_regmap_config);
+       if (IS_ERR(tsdata->regmap)) {
+               dev_err(&client->dev, "regmap allocation failed\n");
+               return PTR_ERR(tsdata->regmap);
+       }
+
        chip_data = device_get_match_data(&client->dev);
        if (!chip_data)
                chip_data = (const struct edt_i2c_chip_data *)id->driver_data;
@@ -1252,6 +1259,7 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
        tsdata->client = client;
        tsdata->input = input;
        tsdata->factory_mode = false;
+       i2c_set_clientdata(client, tsdata);
 
        error = edt_ft5x06_ts_identify(client, tsdata);
        if (error) {
@@ -1263,8 +1271,9 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
         * Dummy read access. EP0700MLP1 returns bogus data on the first
         * register read access and ignores writes.
         */
-       edt_ft5x06_ts_readwrite(tsdata->client, 2, buf, 2, buf);
+       regmap_read(tsdata->regmap, 0x00, &val);
 
+       edt_ft5x06_ts_set_tdata_parameters(tsdata);
        edt_ft5x06_ts_set_regs(tsdata);
        edt_ft5x06_ts_get_defaults(&client->dev, tsdata);
        edt_ft5x06_ts_get_parameters(tsdata);
@@ -1285,9 +1294,8 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
                if (tsdata->version == EDT_M06)
                        tsdata->report_rate /= 10;
 
-               edt_ft5x06_register_write(tsdata,
-                                         tsdata->reg_addr.reg_report_rate,
-                                         tsdata->report_rate);
+               regmap_write(tsdata->regmap, tsdata->reg_addr.reg_report_rate,
+                            tsdata->report_rate);
        }
 
        dev_dbg(&client->dev,
@@ -1306,22 +1314,20 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client)
        touchscreen_parse_properties(input, true, &tsdata->prop);
 
        error = input_mt_init_slots(input, tsdata->max_support_points,
-                               INPUT_MT_DIRECT);
+                                   INPUT_MT_DIRECT);
        if (error) {
                dev_err(&client->dev, "Unable to init MT slots.\n");
                return error;
        }
 
-       i2c_set_clientdata(client, tsdata);
-
        irq_flags = irq_get_trigger_type(client->irq);
        if (irq_flags == IRQF_TRIGGER_NONE)
                irq_flags = IRQF_TRIGGER_FALLING;
        irq_flags |= IRQF_ONESHOT;
 
        error = devm_request_threaded_irq(&client->dev, client->irq,
-                                       NULL, edt_ft5x06_ts_isr, irq_flags,
-                                       client->name, tsdata);
+                                         NULL, edt_ft5x06_ts_isr, irq_flags,
+                                         client->name, tsdata);
        if (error) {
                dev_err(&client->dev, "Unable to request touchscreen IRQ.\n");
                return error;
@@ -1351,6 +1357,7 @@ static void edt_ft5x06_ts_remove(struct i2c_client *client)
        struct edt_ft5x06_ts_data *tsdata = i2c_get_clientdata(client);
 
        edt_ft5x06_ts_teardown_debugfs(tsdata);
+       regmap_exit(tsdata->regmap);
 }
 
 static int edt_ft5x06_ts_suspend(struct device *dev)
@@ -1367,8 +1374,8 @@ static int edt_ft5x06_ts_suspend(struct device *dev)
                return 0;
 
        /* Enter hibernate mode. */
-       ret = edt_ft5x06_register_write(tsdata, PMOD_REGISTER_OPMODE,
-                                       PMOD_REGISTER_HIBERNATE);
+       ret = regmap_write(tsdata->regmap, PMOD_REGISTER_OPMODE,
+                          PMOD_REGISTER_HIBERNATE);
        if (ret)
                dev_warn(dev, "Failed to set hibernate mode\n");
 
@@ -1455,7 +1462,6 @@ static int edt_ft5x06_ts_resume(struct device *dev)
                gpiod_set_value_cansleep(wake_gpio, 1);
        }
 
-
        return ret;
 }
 
index bd454d93f1f77f60fc064a12ca12abd432a3bb2e..7c7020099b0ff128a6eeaba6a9fcbba9bc166558 100644 (file)
@@ -35,6 +35,7 @@
 #define HIDEEP_EVENT_ADDR              0x240
 
 /* command list */
+#define HIDEEP_WORK_MODE               0x081e
 #define HIDEEP_RESET_CMD               0x9800
 
 /* event bit */
@@ -271,9 +272,14 @@ static int hideep_pgm_w_reg(struct hideep_ts *ts, u32 addr, u32 val)
 
 #define SW_RESET_IN_PGM(clk)                                   \
 {                                                              \
+       __be32 data = cpu_to_be32(0x01);                        \
        hideep_pgm_w_reg(ts, HIDEEP_SYSCON_WDT_CNT, (clk));     \
        hideep_pgm_w_reg(ts, HIDEEP_SYSCON_WDT_CON, 0x03);      \
-       hideep_pgm_w_reg(ts, HIDEEP_SYSCON_WDT_CON, 0x01);      \
+       /*                                                      \
+        * The first write may already cause a reset, use a raw \
+        * write for the second write to avoid error logging.   \
+        */                                                     \
+       hideep_pgm_w_mem(ts, HIDEEP_SYSCON_WDT_CON, &data, 1);  \
 }
 
 #define SET_FLASH_PIO(ce)                                      \
@@ -467,9 +473,9 @@ static int hideep_program_nvm(struct hideep_ts *ts,
        u32 addr = 0;
        int error;
 
-       error = hideep_nvm_unlock(ts);
-       if (error)
-               return error;
+       error = hideep_nvm_unlock(ts);
+       if (error)
+               return error;
 
        while (ucode_len > 0) {
                xfer_len = min_t(size_t, ucode_len, HIDEEP_NVM_PAGE_SIZE);
@@ -959,6 +965,21 @@ static const struct attribute_group hideep_ts_attr_group = {
        .attrs = hideep_ts_sysfs_entries,
 };
 
+static void hideep_set_work_mode(struct hideep_ts *ts)
+{
+       /*
+        * Reset touch report format to the native HiDeep 20 protocol if requested.
+        * This is necessary to make touchscreens which come up in I2C-HID mode
+        * work with this driver.
+        *
+        * Note this is a kernel internal device-property set by x86 platform code,
+        * this MUST not be used in devicetree files without first adding it to
+        * the DT bindings.
+        */
+       if (device_property_read_bool(&ts->client->dev, "hideep,force-native-protocol"))
+               regmap_write(ts->reg, HIDEEP_WORK_MODE, 0x00);
+}
+
 static int hideep_suspend(struct device *dev)
 {
        struct i2c_client *client = to_i2c_client(dev);
@@ -982,6 +1003,8 @@ static int hideep_resume(struct device *dev)
                return error;
        }
 
+       hideep_set_work_mode(ts);
+
        enable_irq(client->irq);
 
        return 0;
@@ -1058,6 +1081,8 @@ static int hideep_probe(struct i2c_client *client)
                return error;
        }
 
+       hideep_set_work_mode(ts);
+
        error = hideep_init_input(ts);
        if (error)
                return error;
index acdfbdea2b6e02f28c3bd4895f2374a03650d7db..89b6020a9a61563f19331ae528a25596dcffaf57 100644 (file)
@@ -466,7 +466,7 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)
 {
        int id;
        bool __always_unused hover;
-       bool __always_unused palm;
+       bool palm;
        bool state;
        u16 x, y;
        u8 __always_unused pressure_stage = 0;
@@ -522,21 +522,21 @@ static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)
 
        if (unlikely(id < 0 || id >= MIP4_MAX_FINGERS)) {
                dev_err(&ts->client->dev, "Screen - invalid slot ID: %d\n", id);
-       } else if (state) {
-               /* Press or Move event */
-               input_mt_slot(ts->input, id);
-               input_mt_report_slot_state(ts->input, MT_TOOL_FINGER, true);
+               goto out;
+       }
+
+       input_mt_slot(ts->input, id);
+       if (input_mt_report_slot_state(ts->input,
+                                      palm ? MT_TOOL_PALM : MT_TOOL_FINGER,
+                                      state)) {
                input_report_abs(ts->input, ABS_MT_POSITION_X, x);
                input_report_abs(ts->input, ABS_MT_POSITION_Y, y);
                input_report_abs(ts->input, ABS_MT_PRESSURE, pressure);
                input_report_abs(ts->input, ABS_MT_TOUCH_MAJOR, touch_major);
                input_report_abs(ts->input, ABS_MT_TOUCH_MINOR, touch_minor);
-       } else {
-               /* Release event */
-               input_mt_slot(ts->input, id);
-               input_mt_report_slot_inactive(ts->input);
        }
 
+out:
        input_mt_sync_frame(ts->input);
 }
 
@@ -1483,6 +1483,7 @@ static int mip4_probe(struct i2c_client *client)
        input->keycodesize = sizeof(*ts->key_code);
        input->keycodemax = ts->key_num;
 
+       input_set_abs_params(input, ABS_MT_TOOL_TYPE, 0, MT_TOOL_PALM, 0, 0);
        input_set_abs_params(input, ABS_MT_POSITION_X, 0, ts->max_x, 0, 0);
        input_set_abs_params(input, ABS_MT_POSITION_Y, 0, ts->max_y, 0, 0);
        input_set_abs_params(input, ABS_MT_PRESSURE,
diff --git a/drivers/input/touchscreen/novatek-nvt-ts.c b/drivers/input/touchscreen/novatek-nvt-ts.c
new file mode 100644 (file)
index 0000000..3e551f9
--- /dev/null
@@ -0,0 +1,301 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Driver for Novatek i2c touchscreen controller as found on
+ * the Acer Iconia One 7 B1-750 tablet. The Touchscreen controller
+ * model-number is unknown. Android calls this a "NVT-ts" touchscreen,
+ * but that may apply to other Novatek controller models too.
+ *
+ * Copyright (c) 2023 Hans de Goede <hdegoede@redhat.com>
+ */
+
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/interrupt.h>
+#include <linux/i2c.h>
+#include <linux/input.h>
+#include <linux/input/mt.h>
+#include <linux/input/touchscreen.h>
+#include <linux/module.h>
+
+#include <asm/unaligned.h>
+
+#define NVT_TS_TOUCH_START             0x00
+#define NVT_TS_TOUCH_SIZE              6
+
+#define NVT_TS_PARAMETERS_START                0x78
+/* These are offsets from NVT_TS_PARAMETERS_START */
+#define NVT_TS_PARAMS_WIDTH            0x04
+#define NVT_TS_PARAMS_HEIGHT           0x06
+#define NVT_TS_PARAMS_MAX_TOUCH                0x09
+#define NVT_TS_PARAMS_MAX_BUTTONS      0x0a
+#define NVT_TS_PARAMS_IRQ_TYPE         0x0b
+#define NVT_TS_PARAMS_WAKE_TYPE                0x0c
+#define NVT_TS_PARAMS_CHIP_ID          0x0e
+#define NVT_TS_PARAMS_SIZE             0x0f
+
+#define NVT_TS_SUPPORTED_WAKE_TYPE     0x05
+#define NVT_TS_SUPPORTED_CHIP_ID       0x05
+
+#define NVT_TS_MAX_TOUCHES             10
+#define NVT_TS_MAX_SIZE                        4096
+
+#define NVT_TS_TOUCH_INVALID           0xff
+#define NVT_TS_TOUCH_SLOT_SHIFT                3
+#define NVT_TS_TOUCH_TYPE_MASK         GENMASK(2, 0)
+#define NVT_TS_TOUCH_NEW               1
+#define NVT_TS_TOUCH_UPDATE            2
+#define NVT_TS_TOUCH_RELEASE           3
+
+static const int nvt_ts_irq_type[4] = {
+       IRQF_TRIGGER_RISING,
+       IRQF_TRIGGER_FALLING,
+       IRQF_TRIGGER_LOW,
+       IRQF_TRIGGER_HIGH
+};
+
+struct nvt_ts_data {
+       struct i2c_client *client;
+       struct input_dev *input;
+       struct gpio_desc *reset_gpio;
+       struct touchscreen_properties prop;
+       int max_touches;
+       u8 buf[NVT_TS_TOUCH_SIZE * NVT_TS_MAX_TOUCHES];
+};
+
+static int nvt_ts_read_data(struct i2c_client *client, u8 reg, u8 *data, int count)
+{
+       struct i2c_msg msg[2] = {
+               {
+                       .addr = client->addr,
+                       .len = 1,
+                       .buf = &reg,
+               },
+               {
+                       .addr = client->addr,
+                       .flags = I2C_M_RD,
+                       .len = count,
+                       .buf = data,
+               }
+       };
+       int ret;
+
+       ret = i2c_transfer(client->adapter, msg, ARRAY_SIZE(msg));
+       if (ret != ARRAY_SIZE(msg)) {
+               dev_err(&client->dev, "Error reading from 0x%02x: %d\n", reg, ret);
+               return (ret < 0) ? ret : -EIO;
+       }
+
+       return 0;
+}
+
+static irqreturn_t nvt_ts_irq(int irq, void *dev_id)
+{
+       struct nvt_ts_data *data = dev_id;
+       struct device *dev = &data->client->dev;
+       int i, error, slot, x, y;
+       bool active;
+       u8 *touch;
+
+       error = nvt_ts_read_data(data->client, NVT_TS_TOUCH_START, data->buf,
+                                data->max_touches * NVT_TS_TOUCH_SIZE);
+       if (error)
+               return IRQ_HANDLED;
+
+       for (i = 0; i < data->max_touches; i++) {
+               touch = &data->buf[i * NVT_TS_TOUCH_SIZE];
+
+               if (touch[0] == NVT_TS_TOUCH_INVALID)
+                       continue;
+
+               slot = touch[0] >> NVT_TS_TOUCH_SLOT_SHIFT;
+               if (slot < 1 || slot > data->max_touches) {
+                       dev_warn(dev, "slot %d out of range, ignoring\n", slot);
+                       continue;
+               }
+
+               switch (touch[0] & NVT_TS_TOUCH_TYPE_MASK) {
+               case NVT_TS_TOUCH_NEW:
+               case NVT_TS_TOUCH_UPDATE:
+                       active = true;
+                       break;
+               case NVT_TS_TOUCH_RELEASE:
+                       active = false;
+                       break;
+               default:
+                       dev_warn(dev, "slot %d unknown state %d\n", slot, touch[0] & 7);
+                       continue;
+               }
+
+               slot--;
+               x = (touch[1] << 4) | (touch[3] >> 4);
+               y = (touch[2] << 4) | (touch[3] & 0x0f);
+
+               input_mt_slot(data->input, slot);
+               input_mt_report_slot_state(data->input, MT_TOOL_FINGER, active);
+               touchscreen_report_pos(data->input, &data->prop, x, y, true);
+       }
+
+       input_mt_sync_frame(data->input);
+       input_sync(data->input);
+
+       return IRQ_HANDLED;
+}
+
+static int nvt_ts_start(struct input_dev *dev)
+{
+       struct nvt_ts_data *data = input_get_drvdata(dev);
+
+       enable_irq(data->client->irq);
+       gpiod_set_value_cansleep(data->reset_gpio, 0);
+
+       return 0;
+}
+
+static void nvt_ts_stop(struct input_dev *dev)
+{
+       struct nvt_ts_data *data = input_get_drvdata(dev);
+
+       disable_irq(data->client->irq);
+       gpiod_set_value_cansleep(data->reset_gpio, 1);
+}
+
+static int nvt_ts_suspend(struct device *dev)
+{
+       struct nvt_ts_data *data = i2c_get_clientdata(to_i2c_client(dev));
+
+       mutex_lock(&data->input->mutex);
+       if (input_device_enabled(data->input))
+               nvt_ts_stop(data->input);
+       mutex_unlock(&data->input->mutex);
+
+       return 0;
+}
+
+static int nvt_ts_resume(struct device *dev)
+{
+       struct nvt_ts_data *data = i2c_get_clientdata(to_i2c_client(dev));
+
+       mutex_lock(&data->input->mutex);
+       if (input_device_enabled(data->input))
+               nvt_ts_start(data->input);
+       mutex_unlock(&data->input->mutex);
+
+       return 0;
+}
+
+static DEFINE_SIMPLE_DEV_PM_OPS(nvt_ts_pm_ops, nvt_ts_suspend, nvt_ts_resume);
+
+static int nvt_ts_probe(struct i2c_client *client)
+{
+       struct device *dev = &client->dev;
+       int error, width, height, irq_type;
+       struct nvt_ts_data *data;
+       struct input_dev *input;
+
+       if (!client->irq) {
+               dev_err(dev, "Error no irq specified\n");
+               return -EINVAL;
+       }
+
+       data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
+       if (!data)
+               return -ENOMEM;
+
+       data->client = client;
+       i2c_set_clientdata(client, data);
+
+       data->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
+       error = PTR_ERR_OR_ZERO(data->reset_gpio);
+       if (error) {
+               dev_err(dev, "failed to request reset GPIO: %d\n", error);
+               return error;
+       }
+
+       /* Wait for controller to come out of reset before params read */
+       msleep(100);
+       error = nvt_ts_read_data(data->client, NVT_TS_PARAMETERS_START,
+                                data->buf, NVT_TS_PARAMS_SIZE);
+       gpiod_set_value_cansleep(data->reset_gpio, 1); /* Put back in reset */
+       if (error)
+               return error;
+
+       width  = get_unaligned_be16(&data->buf[NVT_TS_PARAMS_WIDTH]);
+       height = get_unaligned_be16(&data->buf[NVT_TS_PARAMS_HEIGHT]);
+       data->max_touches = data->buf[NVT_TS_PARAMS_MAX_TOUCH];
+       irq_type = data->buf[NVT_TS_PARAMS_IRQ_TYPE];
+
+       if (width > NVT_TS_MAX_SIZE || height >= NVT_TS_MAX_SIZE ||
+           data->max_touches > NVT_TS_MAX_TOUCHES ||
+           irq_type >= ARRAY_SIZE(nvt_ts_irq_type) ||
+           data->buf[NVT_TS_PARAMS_WAKE_TYPE] != NVT_TS_SUPPORTED_WAKE_TYPE ||
+           data->buf[NVT_TS_PARAMS_CHIP_ID] != NVT_TS_SUPPORTED_CHIP_ID) {
+               dev_err(dev, "Unsupported touchscreen parameters: %*ph\n",
+                       NVT_TS_PARAMS_SIZE, data->buf);
+               return -EIO;
+       }
+
+       dev_dbg(dev, "Detected %dx%d touchscreen with %d max touches\n",
+               width, height, data->max_touches);
+
+       if (data->buf[NVT_TS_PARAMS_MAX_BUTTONS])
+               dev_warn(dev, "Touchscreen buttons are not supported\n");
+
+       input = devm_input_allocate_device(dev);
+       if (!input)
+               return -ENOMEM;
+
+       input->name = client->name;
+       input->id.bustype = BUS_I2C;
+       input->open = nvt_ts_start;
+       input->close = nvt_ts_stop;
+
+       input_set_abs_params(input, ABS_MT_POSITION_X, 0, width - 1, 0, 0);
+       input_set_abs_params(input, ABS_MT_POSITION_Y, 0, height - 1, 0, 0);
+       touchscreen_parse_properties(input, true, &data->prop);
+
+       error = input_mt_init_slots(input, data->max_touches,
+                                   INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
+       if (error)
+               return error;
+
+       data->input = input;
+       input_set_drvdata(input, data);
+
+       error = devm_request_threaded_irq(dev, client->irq, NULL, nvt_ts_irq,
+                                         IRQF_ONESHOT | IRQF_NO_AUTOEN |
+                                               nvt_ts_irq_type[irq_type],
+                                         client->name, data);
+       if (error) {
+               dev_err(dev, "failed to request irq: %d\n", error);
+               return error;
+       }
+
+       error = input_register_device(input);
+       if (error) {
+               dev_err(dev, "failed to request irq: %d\n", error);
+               return error;
+       }
+
+       return 0;
+}
+
+static const struct i2c_device_id nvt_ts_i2c_id[] = {
+       { "NVT-ts" },
+       { }
+};
+MODULE_DEVICE_TABLE(i2c, nvt_ts_i2c_id);
+
+static struct i2c_driver nvt_ts_driver = {
+       .driver = {
+               .name   = "novatek-nvt-ts",
+               .pm     = pm_sleep_ptr(&nvt_ts_pm_ops),
+       },
+       .probe_new = nvt_ts_probe,
+       .id_table = nvt_ts_i2c_id,
+};
+
+module_i2c_driver(nvt_ts_driver);
+
+MODULE_DESCRIPTION("Novatek NVT-ts touchscreen driver");
+MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
+MODULE_LICENSE("GPL");
index 5000f5fd9ec387b96203f5b53c0df071c63fa0b7..45c575df994e01be62e1cd5bded04b4ae3c0bf55 100644 (file)
@@ -134,7 +134,7 @@ static int rpi_ts_probe(struct platform_device *pdev)
                return -ENOENT;
        }
 
-       fw = rpi_firmware_get(fw_node);
+       fw = devm_rpi_firmware_get(&pdev->dev, fw_node);
        of_node_put(fw_node);
        if (!fw)
                return -EPROBE_DEFER;
@@ -160,7 +160,6 @@ static int rpi_ts_probe(struct platform_device *pdev)
        touchbuf = (u32)ts->fw_regs_phys;
        error = rpi_firmware_property(fw, RPI_FIRMWARE_FRAMEBUFFER_SET_TOUCHBUF,
                                      &touchbuf, sizeof(touchbuf));
-       rpi_firmware_put(fw);
        if (error || touchbuf != 0) {
                dev_warn(dev, "Failed to set touchbuf, %d\n", error);
                return error;
index 1117fba30020d0f6719062157953ab05cf9e61b7..577c75c83e25db2e99df88765219e0a230de3b6a 100644 (file)
@@ -400,7 +400,7 @@ MODULE_DEVICE_TABLE(of, sun4i_ts_of_match);
 static struct platform_driver sun4i_ts_driver = {
        .driver = {
                .name   = "sun4i-ts",
-               .of_match_table = of_match_ptr(sun4i_ts_of_match),
+               .of_match_table = sun4i_ts_of_match,
        },
        .probe  = sun4i_ts_probe,
        .remove = sun4i_ts_remove,
index 3c793fb70a0edc802227f0b2f637f28c8e3d2077..21916a30fb76cd7b69a057969f4adcdfbd25464f 100644 (file)
@@ -172,19 +172,6 @@ static irqreturn_t tsc2007_soft_irq(int irq, void *handle)
        return IRQ_HANDLED;
 }
 
-static irqreturn_t tsc2007_hard_irq(int irq, void *handle)
-{
-       struct tsc2007 *ts = handle;
-
-       if (tsc2007_is_pen_down(ts))
-               return IRQ_WAKE_THREAD;
-
-       if (ts->clear_penirq)
-               ts->clear_penirq();
-
-       return IRQ_HANDLED;
-}
-
 static void tsc2007_stop(struct tsc2007 *ts)
 {
        ts->stopped = true;
@@ -226,7 +213,7 @@ static int tsc2007_get_pendown_state_gpio(struct device *dev)
        struct i2c_client *client = to_i2c_client(dev);
        struct tsc2007 *ts = i2c_get_clientdata(client);
 
-       return gpiod_get_value(ts->gpiod);
+       return gpiod_get_value_cansleep(ts->gpiod);
 }
 
 static int tsc2007_probe_properties(struct device *dev, struct tsc2007 *ts)
@@ -376,7 +363,7 @@ static int tsc2007_probe(struct i2c_client *client)
        }
 
        err = devm_request_threaded_irq(&client->dev, ts->irq,
-                                       tsc2007_hard_irq, tsc2007_soft_irq,
+                                       NULL, tsc2007_soft_irq,
                                        IRQF_ONESHOT,
                                        client->dev.driver->name, ts);
        if (err) {
index cdf9bcd744db6af397c321d61624e35fbac0be75..b6ece47151b8f6c400045d91ef233310c9491134 100644 (file)
@@ -260,7 +260,7 @@ static int zinitix_init_regulators(struct bt541_ts_data *bt541)
         * so check if "vddo" is present and in that case use these names.
         * Else use the proper supply names on the component.
         */
-       if (of_find_property(dev->of_node, "vddo-supply", NULL)) {
+       if (of_property_present(dev->of_node, "vddo-supply")) {
                bt541->supplies[0].supply = "vdd";
                bt541->supplies[1].supply = "vddo";
        } else {
index 9476768c3b90a1a201bd82cc719a3297b410c933..b8d8d69eba29aee4502e6398fbb3e910c63a6a0d 100644 (file)
@@ -3,8 +3,9 @@
 #define _MATRIX_KEYPAD_H
 
 #include <linux/types.h>
-#include <linux/input.h>
-#include <linux/of.h>
+
+struct device;
+struct input_dev;
 
 #define MATRIX_MAX_ROWS                32
 #define MATRIX_MAX_COLS                32