ARM: shmobile: rcar-gen2: Add missing of_node_put()

Fix following coccicheck warning:
./arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c:156:1-33: Function
for_each_matching_node_and_match should have of_node_put() before break
and goto.

Early exits from for_each_matching_node_and_match() should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Link: https://lore.kernel.org/r/20211018014503.7598-1-wanjiabing@vivo.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

diff --git a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
index ee949255ced3f01ad4256b2b7bea3ba669006309..09ef73b99dd86a851a98bc7c75c433821c5b5bf1 100644 (file)
--- a/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
+++ b/arch/arm/mach-shmobile/regulator-quirk-rcar-gen2.c
@@ -154,8 +154,10 @@ static int __init rcar_gen2_regulator_quirk(void)
                return -ENODEV;
 
        for_each_matching_node_and_match(np, rcar_gen2_quirk_match, &id) {
-               if (!of_device_is_available(np))
+               if (!of_device_is_available(np)) {
+                       of_node_put(np);
                        break;
+               }
 
                ret = of_property_read_u32(np, "reg", &addr);
                if (ret)        /* Skip invalid entry and continue */
@@ -164,6 +166,7 @@ static int __init rcar_gen2_regulator_quirk(void)
                quirk = kzalloc(sizeof(*quirk), GFP_KERNEL);
                if (!quirk) {
                        ret = -ENOMEM;
+                       of_node_put(np);
                        goto err_mem;
                }