sched/autogroup: Fix sysctl move
authorPeter Zijlstra <peterz@infradead.org>
Mon, 30 May 2022 07:45:38 +0000 (09:45 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Mon, 30 May 2022 10:36:36 +0000 (12:36 +0200)
Ivan reported /proc/sys/kernel/sched_autogroup_enabled went walk-about
and using the noautogroup command line parameter would result in a
boot error message.

Turns out the sysctl move placed the init function wrong.

Fixes: c8eaf6ac76f4 ("sched: move autogroup sysctls into its own file")
Reported-by: Ivan Kozik <ivan@ludios.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Ivan Kozik <ivan@ludios.org>
Link: https://lkml.kernel.org/r/YpR2IqndgsyMzN00@worktop.programming.kicks-ass.net
kernel/sched/autogroup.c

index 16092b49ff6a9a7df2482d5b416a40ecfcf47907..4ebaf97f7bd8576b31a27f3836535e264a42b007 100644 (file)
@@ -36,6 +36,7 @@ void __init autogroup_init(struct task_struct *init_task)
        kref_init(&autogroup_default.kref);
        init_rwsem(&autogroup_default.lock);
        init_task->signal->autogroup = &autogroup_default;
+       sched_autogroup_sysctl_init();
 }
 
 void autogroup_free(struct task_group *tg)
@@ -219,7 +220,6 @@ void sched_autogroup_exit(struct signal_struct *sig)
 static int __init setup_autogroup(char *str)
 {
        sysctl_sched_autogroup_enabled = 0;
-       sched_autogroup_sysctl_init();
 
        return 1;
 }