s390: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c
index d374f9b218b4c278101ebcd451c7304c0ef390a0..0ebf08c3b35ebd658f38322834c46e0b7bf35813 100644 (file)
--- a/arch/s390/kernel/debug.c
+++ b/arch/s390/kernel/debug.c
@@ -1056,12 +1056,6 @@ int debug_register_view(debug_info_t *id, struct debug_view *view)
                mode &= ~(S_IWUSR | S_IWGRP | S_IWOTH);
        pde = debugfs_create_file(view->name, mode, id->debugfs_root_entry,
                                  id, &debug_file_ops);
-       if (!pde) {
-               pr_err("Registering view %s/%s failed due to out of "
-                      "memory\n", id->name, view->name);
-               rc = -1;
-               goto out;
-       }
        spin_lock_irqsave(&id->lock, flags);
        for (i = 0; i < DEBUG_MAX_VIEWS; i++) {
                if (!id->views[i])

diff --git a/arch/s390/kernel/kdebugfs.c b/arch/s390/kernel/kdebugfs.c
index 2c46bd6c6fd2835b3f764b3e45f25690f7946373..33130c7daf55499d77a3425683dc9edd9453a426 100644 (file)
--- a/arch/s390/kernel/kdebugfs.c
+++ b/arch/s390/kernel/kdebugfs.c
@@ -9,8 +9,6 @@ EXPORT_SYMBOL(arch_debugfs_dir);
 static int __init arch_kdebugfs_init(void)
 {
        arch_debugfs_dir = debugfs_create_dir("s390", NULL);
-       if (IS_ERR(arch_debugfs_dir))
-               arch_debugfs_dir = NULL;
        return 0;
 }
 postcore_initcall(arch_kdebugfs_init);

diff --git a/arch/s390/kernel/sysinfo.c b/arch/s390/kernel/sysinfo.c
index 12f80d1f041513d650991690ca99004ee62f9d9a..2ac3c9b56a13e8e60cacf0bcfc3c66165e7fdb7f 100644 (file)
--- a/arch/s390/kernel/sysinfo.c
+++ b/arch/s390/kernel/sysinfo.c
@@ -545,8 +545,6 @@ static __init int stsi_init_debugfs(void)
        int lvl, i;
 
        stsi_root = debugfs_create_dir("stsi", arch_debugfs_dir);
-       if (IS_ERR_OR_NULL(stsi_root))
-               return 0;
        lvl = stsi(NULL, 0, 0, 0);
        if (lvl > 0)
                stsi_0_0_0 = lvl;