netfilter: nf_log: consolidate check for NULL logger in lookup function
authorPablo Neira Ayuso <pablo@netfilter.org>
Mon, 29 Jan 2024 19:24:24 +0000 (20:24 +0100)
committerFlorian Westphal <fw@strlen.de>
Wed, 21 Feb 2024 10:57:11 +0000 (11:57 +0100)
Consolidate pointer fetch to logger and check for NULL in
__find_logger().

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
net/netfilter/nf_log.c

index e16f158388bbe568cddc1be5a0a6d16069897822..e0bfeb75766ffa2ce00cd5205701a8746d613363 100644 (file)
@@ -31,10 +31,10 @@ static struct nf_logger *__find_logger(int pf, const char *str_logger)
        int i;
 
        for (i = 0; i < NF_LOG_TYPE_MAX; i++) {
-               if (loggers[pf][i] == NULL)
+               log = nft_log_dereference(loggers[pf][i]);
+               if (!log)
                        continue;
 
-               log = nft_log_dereference(loggers[pf][i]);
                if (!strncasecmp(str_logger, log->name, strlen(log->name)))
                        return log;
        }