platform/x86: Move existing HP drivers to a new hp subdir
authorJorge Lopez <jorge.lopez2@hp.com>
Thu, 20 Oct 2022 20:10:28 +0000 (15:10 -0500)
committerHans de Goede <hdegoede@redhat.com>
Wed, 16 Nov 2022 07:48:19 +0000 (08:48 +0100)
The purpose of this patch is to provide a central location where all
HP related drivers are found. HP drivers will recide under
drivers/platform/x86/hp directory.

Introduce changes to Kconfig file to list all HP driver under "HP X86
Platform Specific Device Drivers" menu option. Additional changes
include update MAINTAINERS file to indicate hp related drivers new
path.

Signed-off-by: Jorge Lopez <jorge.lopez2@hp.com>
Link: https://lore.kernel.org/r/20221020201033.12790-2-jorge.lopez2@hp.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
MAINTAINERS
drivers/platform/x86/Kconfig
drivers/platform/x86/Makefile
drivers/platform/x86/hp/Kconfig [new file with mode: 0644]
drivers/platform/x86/hp/Makefile [new file with mode: 0644]
drivers/platform/x86/hp/hp-wmi.c [moved from drivers/platform/x86/hp-wmi.c with 100% similarity]
drivers/platform/x86/hp/hp_accel.c [moved from drivers/platform/x86/hp_accel.c with 99% similarity]
drivers/platform/x86/hp/tc1100-wmi.c [moved from drivers/platform/x86/tc1100-wmi.c with 100% similarity]

index f8fa72d1452e25c7bf160674397a12e0d98e7ab8..893c63e8beef2596019931d1ece83905f3cf32e8 100644 (file)
@@ -9366,7 +9366,7 @@ F:        drivers/net/wireless/intersil/hostap/
 HP COMPAQ TC1100 TABLET WMI EXTRAS DRIVER
 L:     platform-driver-x86@vger.kernel.org
 S:     Orphan
-F:     drivers/platform/x86/tc1100-wmi.c
+F:     drivers/platform/x86/hp/tc1100-wmi.c
 
 HPET:  High Precision Event Timers driver
 M:     Clemens Ladisch <clemens@ladisch.de>
@@ -11856,7 +11856,7 @@ M:      Eric Piel <eric.piel@tremplin-utc.net>
 S:     Maintained
 F:     Documentation/misc-devices/lis3lv02d.rst
 F:     drivers/misc/lis3lv02d/
-F:     drivers/platform/x86/hp_accel.c
+F:     drivers/platform/x86/hp/hp_accel.c
 
 LIST KUNIT TEST
 M:     David Gow <davidgow@google.com>
index f5312f51de19f9d3ff38ef15cf677d78bdee158f..5692385e2d26fed92785488ce1c6e88449c54c78 100644 (file)
@@ -424,24 +424,7 @@ config GPD_POCKET_FAN
          of the CPU temperature. Say Y or M if the kernel may be used on a
          GPD pocket.
 
-config HP_ACCEL
-       tristate "HP laptop accelerometer"
-       depends on INPUT && ACPI
-       depends on SERIO_I8042
-       select SENSORS_LIS3LV02D
-       select NEW_LEDS
-       select LEDS_CLASS
-       help
-         This driver provides support for the "Mobile Data Protection System 3D"
-         or "3D DriveGuard" feature of HP laptops. On such systems the driver
-         should load automatically (via ACPI alias).
-
-         Support for a led indicating disk protection will be provided as
-         hp::hddprotect. For more information on the feature, refer to
-         Documentation/misc-devices/lis3lv02d.rst.
-
-         To compile this driver as a module, choose M here: the module will
-         be called hp_accel.
+source "drivers/platform/x86/hp/Kconfig"
 
 config WIRELESS_HOTKEY
        tristate "Wireless hotkey button"
@@ -455,30 +438,6 @@ config WIRELESS_HOTKEY
         To compile this driver as a module, choose M here: the module will
         be called wireless-hotkey.
 
-config HP_WMI
-       tristate "HP WMI extras"
-       depends on ACPI_WMI
-       depends on INPUT
-       depends on RFKILL || RFKILL = n
-       select INPUT_SPARSEKMAP
-       select ACPI_PLATFORM_PROFILE
-       select HWMON
-       help
-        Say Y here if you want to support WMI-based hotkeys on HP laptops and
-        to read data from WMI such as docking or ambient light sensor state.
-
-        To compile this driver as a module, choose M here: the module will
-        be called hp-wmi.
-
-config TC1100_WMI
-       tristate "HP Compaq TC1100 Tablet WMI Extras"
-       depends on !X86_64
-       depends on ACPI
-       depends on ACPI_WMI
-       help
-         This is a driver for the WMI extensions (wireless and bluetooth power
-         control) of the HP Compaq TC1100 tablet.
-
 config IBM_RTL
        tristate "Device driver to enable PRTL support"
        depends on PCI
index 5a428caa654a742875e46dfb0146c1d1c74db4f9..1d3d1b02541b946d527fac89a3796fac28aad783 100644 (file)
@@ -55,9 +55,7 @@ obj-$(CONFIG_FUJITSU_TABLET)  += fujitsu-tablet.o
 obj-$(CONFIG_GPD_POCKET_FAN)   += gpd-pocket-fan.o
 
 # Hewlett Packard
-obj-$(CONFIG_HP_ACCEL)         += hp_accel.o
-obj-$(CONFIG_HP_WMI)           += hp-wmi.o
-obj-$(CONFIG_TC1100_WMI)       += tc1100-wmi.o
+obj-$(CONFIG_X86_PLATFORM_DRIVERS_HP)  += hp/
 
 # Hewlett Packard Enterprise
 obj-$(CONFIG_UV_SYSFS)       += uv_sysfs.o
diff --git a/drivers/platform/x86/hp/Kconfig b/drivers/platform/x86/hp/Kconfig
new file mode 100644 (file)
index 0000000..ae16595
--- /dev/null
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: GPL-2.0-only
+#
+# X86 Platform Specific Drivers
+#
+menuconfig X86_PLATFORM_DRIVERS_HP
+       bool "HP X86 Platform Specific Device Drivers"
+       depends on X86_PLATFORM_DEVICES
+       help
+         Say Y here to get to see options for device drivers for various
+         HP x86 platforms, including vendor-specific laptop extension drivers.
+         This option alone does not add any kernel code.
+
+         If you say N, all options in this submenu will be skipped and disabled.
+
+if X86_PLATFORM_DRIVERS_HP
+
+config HP_ACCEL
+       tristate "HP laptop accelerometer"
+       default m
+       depends on INPUT && ACPI
+       depends on SERIO_I8042
+       select SENSORS_LIS3LV02D
+       select NEW_LEDS
+       select LEDS_CLASS
+       help
+         This driver provides support for the "Mobile Data Protection System 3D"
+         or "3D DriveGuard" feature of HP laptops. On such systems the driver
+         should load automatically (via ACPI alias).
+
+         Support for a led indicating disk protection will be provided as
+         hp::hddprotect. For more information on the feature, refer to
+         Documentation/misc-devices/lis3lv02d.rst.
+
+         To compile this driver as a module, choose M here: the module will
+         be called hp_accel.
+
+config HP_WMI
+       tristate "HP WMI extras"
+       default m
+       depends on ACPI_WMI
+       depends on INPUT
+       depends on RFKILL || RFKILL = n
+       select INPUT_SPARSEKMAP
+       select ACPI_PLATFORM_PROFILE
+       select HWMON
+       help
+         Say Y here if you want to support WMI-based hotkeys on HP laptops and
+         to read data from WMI such as docking or ambient light sensor state.
+
+         To compile this driver as a module, choose M here: the module will
+         be called hp-wmi.
+
+config TC1100_WMI
+       tristate "HP Compaq TC1100 Tablet WMI Extras"
+       default m
+       depends on !X86_64
+       depends on ACPI
+       depends on ACPI_WMI
+       help
+         This is a driver for the WMI extensions (wireless and bluetooth power
+         control) of the HP Compaq TC1100 tablet.
+
+endif # X86_PLATFORM_DRIVERS_HP
diff --git a/drivers/platform/x86/hp/Makefile b/drivers/platform/x86/hp/Makefile
new file mode 100644 (file)
index 0000000..db1eed4
--- /dev/null
@@ -0,0 +1,10 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Makefile for linux/drivers/platform/x86/hp
+# HP x86 Platform-Specific Drivers
+#
+
+# Hewlett Packard
+obj-$(CONFIG_HP_ACCEL)         += hp_accel.o
+obj-$(CONFIG_HP_WMI)           += hp-wmi.o
+obj-$(CONFIG_TC1100_WMI)       += tc1100-wmi.o
similarity index 99%
rename from drivers/platform/x86/hp_accel.c
rename to drivers/platform/x86/hp/hp_accel.c
index e9f852f7c27ff4267fbe20046e3abe10a1dcb246..6477591747cfdc4662cb48a634d37847733ea238 100644 (file)
@@ -26,7 +26,7 @@
 #include <linux/acpi.h>
 #include <linux/i8042.h>
 #include <linux/serio.h>
-#include "../../misc/lis3lv02d/lis3lv02d.h"
+#include "../../../misc/lis3lv02d/lis3lv02d.h"
 
 /* Delayed LEDs infrastructure ------------------------------------ */