hwmon: (nct7904) Fix incorrect temperature limitation register setting of LTD.

According to kernel hwmon sysfs-interface documentation, temperature
critical max value, typically greater than corresponding temp_max values.
Thus, reads the LTD_HV_HL (LTD HIGH VALUE HIGH LIMITATION) and LTD_LV_HL
(LTD LOW VALUE HIGH LIMITATION) for case hwmon_temp_crit and
hwmon_temp_crit_hyst. Reads the LTD_HV_LL (HIGH VALUE LOW LIMITATION)
and LTD_LV_LL (LOW VALUE LOW LIMITATION) for case hwmon_temp_max
and hwmon_temp_max_hyst.

Signed-off-by: amy.shih <amy.shih@advantech.com.tw>
Link: https://lore.kernel.org/r/20850618155720.24857-1-Amy.Shih@advantech.com.tw
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
index 76372f20d71af850975a1015100f7cf7fc261a5d..ce688ab4fce2fceb57e42876702a6ce6131ff29a 100644 (file)
--- a/drivers/hwmon/nct7904.c
+++ b/drivers/hwmon/nct7904.c
@@ -398,22 +398,22 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
                }
                return 0;
        case hwmon_temp_max:
-               reg1 = LTD_HV_HL_REG;
+               reg1 = LTD_HV_LL_REG;
                reg2 = TEMP_CH1_W_REG;
                reg3 = DTS_T_CPU1_W_REG;
                break;
        case hwmon_temp_max_hyst:
-               reg1 = LTD_LV_HL_REG;
+               reg1 = LTD_LV_LL_REG;
                reg2 = TEMP_CH1_WH_REG;
                reg3 = DTS_T_CPU1_WH_REG;
                break;
        case hwmon_temp_crit:
-               reg1 = LTD_HV_LL_REG;
+               reg1 = LTD_HV_HL_REG;
                reg2 = TEMP_CH1_C_REG;
                reg3 = DTS_T_CPU1_C_REG;
                break;
        case hwmon_temp_crit_hyst:
-               reg1 = LTD_LV_LL_REG;
+               reg1 = LTD_LV_HL_REG;
                reg2 = TEMP_CH1_CH_REG;
                reg3 = DTS_T_CPU1_CH_REG;
                break;
@@ -507,22 +507,22 @@ static int nct7904_write_temp(struct device *dev, u32 attr, int channel,
 
        switch (attr) {
        case hwmon_temp_max:
-               reg1 = LTD_HV_HL_REG;
+               reg1 = LTD_HV_LL_REG;
                reg2 = TEMP_CH1_W_REG;
                reg3 = DTS_T_CPU1_W_REG;
                break;
        case hwmon_temp_max_hyst:
-               reg1 = LTD_LV_HL_REG;
+               reg1 = LTD_LV_LL_REG;
                reg2 = TEMP_CH1_WH_REG;
                reg3 = DTS_T_CPU1_WH_REG;
                break;
        case hwmon_temp_crit:
-               reg1 = LTD_HV_LL_REG;
+               reg1 = LTD_HV_HL_REG;
                reg2 = TEMP_CH1_C_REG;
                reg3 = DTS_T_CPU1_C_REG;
                break;
        case hwmon_temp_crit_hyst:
-               reg1 = LTD_LV_LL_REG;
+               reg1 = LTD_LV_HL_REG;
                reg2 = TEMP_CH1_CH_REG;
                reg3 = DTS_T_CPU1_CH_REG;
                break;