ALSA: ac97: Fix of-node refcount unbalance
authorTakashi Iwai <tiwai@suse.de>
Mon, 18 Feb 2019 13:38:06 +0000 (14:38 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 19 Feb 2019 21:20:14 +0000 (22:20 +0100)
ac97_of_get_child_device() take the refcount of the node explicitly
via of_node_get(), but this leads to an unbalance.  The
for_each_child_of_node() loop itself takes the refcount for each
iteration node, hence you don't need to take the extra refcount
again.

Fixes: 2225a3e6af78 ("ALSA: ac97: add codecs devicetree binding")
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ac97/bus.c

index 9f0c480489ef04384445b35f8786c020dfc9d7fa..9cbf6927abe96a735f0e188cfd735710c1d989ad 100644 (file)
@@ -84,7 +84,7 @@ ac97_of_get_child_device(struct ac97_controller *ac97_ctrl, int idx,
                if ((idx != of_property_read_u32(node, "reg", &reg)) ||
                    !of_device_is_compatible(node, compat))
                        continue;
-               return of_node_get(node);
+               return node;
        }
 
        return NULL;