RDMA/uverbs: Remove redundant assignments

The kbuild reported the following warning, so clean whole uverbs_cmd.c
file.

   drivers/infiniband/core/uverbs_cmd.c:1066:6: warning: Variable 'ret' is reassigned a value before the old one has been used. [redundantAssignment]
    ret = uverbs_request(attrs, &cmd, sizeof(cmd));
        ^
   drivers/infiniband/core/uverbs_cmd.c:1064:0: note: Variable 'ret' is reassigned a value before the old one has been used.
    int    ret = -EINVAL;
   ^

Link: https://lore.kernel.org/r/20200720175627.1273096-2-leon@kernel.org
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index 479895db72e263ba6247bd55b379ef63cc795db2..119646478fa7fea33a1a360b64c0dac32543daf9 100644 (file)
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -563,11 +563,11 @@ static int ib_uverbs_open_xrcd(struct uverbs_attr_bundle *attrs)
        struct ib_uverbs_open_xrcd      cmd;
        struct ib_uxrcd_object         *obj;
        struct ib_xrcd                 *xrcd = NULL;
-       struct fd                       f = {NULL, 0};
        struct inode                   *inode = NULL;
-       int                             ret = 0;
        int                             new_xrcd = 0;
        struct ib_device *ib_dev;
+       struct fd f = {};
+       int ret;
 
        ret = uverbs_request(attrs, &cmd, sizeof(cmd));
        if (ret)
@@ -1064,7 +1064,7 @@ static int ib_uverbs_resize_cq(struct uverbs_attr_bundle *attrs)
        struct ib_uverbs_resize_cq      cmd;
        struct ib_uverbs_resize_cq_resp resp = {};
        struct ib_cq                    *cq;
-       int                             ret = -EINVAL;
+       int ret;
 
        ret = uverbs_request(attrs, &cmd, sizeof(cmd));
        if (ret)
@@ -1509,10 +1509,10 @@ static int ib_uverbs_open_qp(struct uverbs_attr_bundle *attrs)
        struct ib_uverbs_open_qp        cmd;
        struct ib_uqp_object           *obj;
        struct ib_xrcd                 *xrcd;
-       struct ib_uobject              *uninitialized_var(xrcd_uobj);
        struct ib_qp                   *qp;
        struct ib_qp_open_attr          attr = {};
        int ret;
+       struct ib_uobject *xrcd_uobj;
        struct ib_device *ib_dev;
 
        ret = uverbs_request(attrs, &cmd, sizeof(cmd));
@@ -3291,9 +3291,9 @@ static int __uverbs_create_xsrq(struct uverbs_attr_bundle *attrs,
        struct ib_usrq_object           *obj;
        struct ib_pd                    *pd;
        struct ib_srq                   *srq;
-       struct ib_uobject               *uninitialized_var(xrcd_uobj);
        struct ib_srq_init_attr          attr;
        int ret;
+       struct ib_uobject *xrcd_uobj;
        struct ib_device *ib_dev;
 
        obj = (struct ib_usrq_object *)uobj_alloc(UVERBS_OBJECT_SRQ, attrs,