NFSD: Replace comment with lockdep assertion
authorChuck Lever <chuck.lever@oracle.com>
Fri, 26 Jan 2024 17:46:20 +0000 (12:46 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Fri, 1 Mar 2024 14:12:16 +0000 (09:12 -0500)
Convert a code comment into a real assertion.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4callback.c

index 45a31f0515959827c2f39b96eae7426b8ab36487..d73c66fa131df7144b7f815d683be1a29f4c6033 100644 (file)
@@ -1315,12 +1315,13 @@ void nfsd4_shutdown_callback(struct nfs4_client *clp)
        nfsd41_cb_inflight_wait_complete(clp);
 }
 
-/* requires cl_lock: */
 static struct nfsd4_conn * __nfsd4_find_backchannel(struct nfs4_client *clp)
 {
        struct nfsd4_session *s;
        struct nfsd4_conn *c;
 
+       lockdep_assert_held(&clp->cl_lock);
+
        list_for_each_entry(s, &clp->cl_sessions, se_perclnt) {
                list_for_each_entry(c, &s->se_conns, cn_persession) {
                        if (c->cn_flags & NFS4_CDFC4_BACK)