proc: don't allow async path resolution of /proc/thread-self components
authorJens Axboe <axboe@kernel.dk>
Sun, 14 Feb 2021 20:21:43 +0000 (13:21 -0700)
committerJens Axboe <axboe@kernel.dk>
Mon, 15 Feb 2021 18:02:16 +0000 (11:02 -0700)
If this is attempted by an io-wq kthread, then return -EOPNOTSUPP as we
don't currently support that. Once we can get task_pid_ptr() doing the
right thing, then this can go away again.

Use PF_IO_WORKER for this to speciically target the io_uring workers.
Modify the /proc/self/ check to use PF_IO_WORKER as well.

Cc: stable@vger.kernel.org
Fixes: 8d4c3e76e3be ("proc: don't allow async path resolution of /proc/self components")
Reported-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/proc/self.c
fs/proc/thread_self.c

index cc71ce3466dc0b6bf527808f1d52f0d384565522..a4012154e1096bd240c1d97255807843bc932516 100644 (file)
@@ -20,7 +20,7 @@ static const char *proc_self_get_link(struct dentry *dentry,
         * Not currently supported. Once we can inherit all of struct pid,
         * we can allow this.
         */
-       if (current->flags & PF_KTHREAD)
+       if (current->flags & PF_IO_WORKER)
                return ERR_PTR(-EOPNOTSUPP);
 
        if (!tgid)
index a553273fbd41758df711b85c9647134b9eb1c631..d56681d86d28a28517df9730dfe1e9bfed597387 100644 (file)
@@ -17,6 +17,13 @@ static const char *proc_thread_self_get_link(struct dentry *dentry,
        pid_t pid = task_pid_nr_ns(current, ns);
        char *name;
 
+       /*
+        * Not currently supported. Once we can inherit all of struct pid,
+        * we can allow this.
+        */
+       if (current->flags & PF_IO_WORKER)
+               return ERR_PTR(-EOPNOTSUPP);
+
        if (!pid)
                return ERR_PTR(-ENOENT);
        name = kmalloc(10 + 6 + 10 + 1, dentry ? GFP_KERNEL : GFP_ATOMIC);