PM: suspend: Rename pm_suspend_via_s2idle()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 18 Jun 2019 08:18:28 +0000 (10:18 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 19 Jun 2019 09:41:26 +0000 (11:41 +0200)
The name of pm_suspend_via_s2idle() is confusing, as it doesn't
reflect the purpose of the function precisely enough and it is
very similar to pm_suspend_via_firmware(), which has a different
purpose, so rename it as pm_suspend_default_s2idle() and update
its only caller, i8042_register_ports(), accordingly.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/serio/i8042.c
include/linux/suspend.h
kernel/power/suspend.c

index 6462f1798fbb5ab5976e45071b085eb007d805ad..8384abc41d7f042f7f13bd8feaeeca8607824e17 100644 (file)
@@ -1410,7 +1410,7 @@ static void __init i8042_register_ports(void)
                 * behavior on many platforms using suspend-to-RAM (ACPI S3)
                 * by default.
                 */
-               if (pm_suspend_via_s2idle() && i == I8042_KBD_PORT_NO)
+               if (pm_suspend_default_s2idle() && i == I8042_KBD_PORT_NO)
                        device_set_wakeup_enable(&serio->dev, true);
        }
 }
index 05645f726815e24fe45fc7dd3b564ff50ea274a0..d07ae7fb9315bed5468e633abc0f498c70b2fc6c 100644 (file)
@@ -282,7 +282,7 @@ static inline bool idle_should_enter_s2idle(void)
        return unlikely(s2idle_state == S2IDLE_STATE_ENTER);
 }
 
-extern bool pm_suspend_via_s2idle(void);
+extern bool pm_suspend_default_s2idle(void);
 extern void __init pm_states_init(void);
 extern void s2idle_set_ops(const struct platform_s2idle_ops *ops);
 extern void s2idle_wake(void);
@@ -314,7 +314,7 @@ static inline void pm_set_suspend_via_firmware(void) {}
 static inline void pm_set_resume_via_firmware(void) {}
 static inline bool pm_suspend_via_firmware(void) { return false; }
 static inline bool pm_resume_via_firmware(void) { return false; }
-static inline bool pm_suspend_via_s2idle(void) { return false; }
+static inline bool pm_suspend_default_s2idle(void) { return false; }
 
 static inline void suspend_set_ops(const struct platform_suspend_ops *ops) {}
 static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; }
index 9505101ed2bcde333025984f60926cd9abadbbf0..8703b0ca498629f0896be595e164d05e75b4852c 100644 (file)
@@ -62,16 +62,16 @@ enum s2idle_states __read_mostly s2idle_state;
 static DEFINE_RAW_SPINLOCK(s2idle_lock);
 
 /**
- * pm_suspend_via_s2idle - Check if suspend-to-idle is the default suspend.
+ * pm_suspend_default_s2idle - Check if suspend-to-idle is the default suspend.
  *
  * Return 'true' if suspend-to-idle has been selected as the default system
  * suspend method.
  */
-bool pm_suspend_via_s2idle(void)
+bool pm_suspend_default_s2idle(void)
 {
        return mem_sleep_current == PM_SUSPEND_TO_IDLE;
 }
-EXPORT_SYMBOL_GPL(pm_suspend_via_s2idle);
+EXPORT_SYMBOL_GPL(pm_suspend_default_s2idle);
 
 void s2idle_set_ops(const struct platform_s2idle_ops *ops)
 {