libsmb: Make SMB1-only cli_nt_hardlink calls static

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Mar 20 23:32:31 UTC 2019 on sn-devel-144

diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c
index 0ceffe8bce7b786dd3cdc985822934f9eea93c90..f2bfdcce23d7c43fd388b31da9913a7a98fb456b 100644 (file)
--- a/source3/libsmb/clifile.c
+++ b/source3/libsmb/clifile.c
@@ -1458,7 +1458,7 @@ NTSTATUS cli_ntrename(struct cli_state *cli, const char *fname_src, const char *
  NT hardlink a file.
 ****************************************************************************/
 
-struct tevent_req *cli_nt_hardlink_send(TALLOC_CTX *mem_ctx,
+static struct tevent_req *cli_nt_hardlink_send(TALLOC_CTX *mem_ctx,
                                struct tevent_context *ev,
                                struct cli_state *cli,
                                const char *fname_src,
@@ -1472,49 +1472,11 @@ struct tevent_req *cli_nt_hardlink_send(TALLOC_CTX *mem_ctx,
                                          RENAME_FLAG_HARD_LINK);
 }
 
-NTSTATUS cli_nt_hardlink_recv(struct tevent_req *req)
+static NTSTATUS cli_nt_hardlink_recv(struct tevent_req *req)
 {
        return cli_ntrename_internal_recv(req);
 }
 
-NTSTATUS cli_nt_hardlink(struct cli_state *cli, const char *fname_src, const char *fname_dst)
-{
-       TALLOC_CTX *frame = talloc_stackframe();
-       struct tevent_context *ev;
-       struct tevent_req *req;
-       NTSTATUS status = NT_STATUS_OK;
-
-       if (smbXcli_conn_has_async_calls(cli->conn)) {
-               /*
-                * Can't use sync call while an async call is in flight
-                */
-               status = NT_STATUS_INVALID_PARAMETER;
-               goto fail;
-       }
-
-       ev = samba_tevent_context_init(frame);
-       if (ev == NULL) {
-               status = NT_STATUS_NO_MEMORY;
-               goto fail;
-       }
-
-       req = cli_nt_hardlink_send(frame, ev, cli, fname_src, fname_dst);
-       if (req == NULL) {
-               status = NT_STATUS_NO_MEMORY;
-               goto fail;
-       }
-
-       if (!tevent_req_poll_ntstatus(req, ev, &status)) {
-               goto fail;
-       }
-
-       status = cli_nt_hardlink_recv(req);
-
- fail:
-       TALLOC_FREE(frame);
-       return status;
-}
-
 struct cli_smb2_hardlink_state {
        struct tevent_context *ev;
        struct cli_state *cli;

diff --git a/source3/libsmb/proto.h b/source3/libsmb/proto.h
index a42f424df1ea6c1ac5925986b2eaa2ba825cd79e..4b9cfbea96e1c55357991f8764a466ed587d12c1 100644 (file)
--- a/source3/libsmb/proto.h
+++ b/source3/libsmb/proto.h
@@ -352,14 +352,6 @@ struct tevent_req *cli_ntrename_send(TALLOC_CTX *mem_ctx,
 NTSTATUS cli_ntrename_recv(struct tevent_req *req);
 NTSTATUS cli_ntrename(struct cli_state *cli, const char *fname_src, const char *fname_dst);
 
-struct tevent_req *cli_nt_hardlink_send(TALLOC_CTX *mem_ctx,
-                                struct tevent_context *ev,
-                                struct cli_state *cli,
-                                const char *fname_src,
-                                const char *fname_dst);
-NTSTATUS cli_nt_hardlink_recv(struct tevent_req *req);
-NTSTATUS cli_nt_hardlink(struct cli_state *cli, const char *fname_src, const char *fname_dst);
-
 struct tevent_req *cli_hardlink_send(
        TALLOC_CTX *mem_ctx,
        struct tevent_context *ev,