python:ndr: verify the object type ndr_print() and ndr_unpack()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/python/samba/ndr.py b/python/samba/ndr.py
index 39e4a482efbf32f47ff27f3a536e158a909c2722..7a8f54af192477604a90388b0edce31215e53ddb 100644 (file)
--- a/python/samba/ndr.py
+++ b/python/samba/ndr.py
@@ -42,9 +42,15 @@ def ndr_unpack(cls, data, allow_remaining=False):
     :return: Unpacked object
     """
     object = cls()
-    object.__ndr_unpack__(data, allow_remaining=allow_remaining)
+    ndr_unpack = getattr(object, "__ndr_unpack__", None)
+    if ndr_unpack is None:
+        raise TypeError("%r is not a NDR object" % object)
+    ndr_unpack(data, allow_remaining=allow_remaining)
     return object
 
 
 def ndr_print(object):
-    return object.__ndr_print__()
+    ndr_print = getattr(object, "__ndr_print__", None)
+    if ndr_print is None:
+        raise TypeError("%r is not a NDR object" % object)
+    return ndr_print()