s3:winbind: Convert WINBINDD_LOOKUPNAME to the new API

diff --git a/source3/Makefile.in b/source3/Makefile.in
index 0f97d66cada8840763e558f60a614ee84216ce74..af2a9604572b4c200a3f23735e7ca232b570ae56 100644 (file)
--- a/source3/Makefile.in
+++ b/source3/Makefile.in
@@ -1155,6 +1155,7 @@ WINBINDD_OBJ1 = \
                winbindd/wb_lookupsid.o \
                winbindd/wb_lookupname.o \
                winbindd/winbindd_lookupsid.o \
+               winbindd/winbindd_lookupname.o \
                auth/token_util.o \
                ../nsswitch/libwbclient/wb_reqtrans.o \
                smbd/connection.o

diff --git a/source3/winbindd/winbindd.c b/source3/winbindd/winbindd.c
index 867e9df8d9c53c45285eb742c0f998d2619dc66b..a5374a99f48b2f8ee8c033a404593154f61fb2e6 100644 (file)
--- a/source3/winbindd/winbindd.c
+++ b/source3/winbindd/winbindd.c
@@ -469,7 +469,6 @@ static struct winbindd_dispatch_table {
 
        /* SID related functions */
 
-       { WINBINDD_LOOKUPNAME, winbindd_lookupname, "LOOKUPNAME" },
        { WINBINDD_LOOKUPRIDS, winbindd_lookuprids, "LOOKUPRIDS" },
 
        /* Lookup related functions */
@@ -526,6 +525,8 @@ static struct winbindd_async_dispatch_table async_nonpriv_table[] = {
          wb_ping_send, wb_ping_recv },
        { WINBINDD_LOOKUPSID, "LOOKUPSID",
          winbindd_lookupsid_send, winbindd_lookupsid_recv },
+       { WINBINDD_LOOKUPNAME, "LOOKUPNAME",
+         winbindd_lookupname_send, winbindd_lookupname_recv },
 
        { 0, NULL, NULL, NULL }
 };

diff --git a/source3/winbindd/winbindd_lookupname.c b/source3/winbindd/winbindd_lookupname.c
new file mode 100644 (file)
index 0000000..0918076
--- /dev/null
+++ b/source3/winbindd/winbindd_lookupname.c
@@ -0,0 +1,110 @@
+/*
+   Unix SMB/CIFS implementation.
+   async implementation of WINBINDD_GETPWNAM
+   Copyright (C) Volker Lendecke 2009
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include "includes.h"
+#include "winbindd.h"
+
+struct winbindd_lookupname_state {
+       struct tevent_context *ev;
+       struct dom_sid sid;
+       enum lsa_SidType type;
+};
+
+static void winbindd_lookupname_done(struct tevent_req *subreq);
+
+struct tevent_req *winbindd_lookupname_send(TALLOC_CTX *mem_ctx,
+                                           struct tevent_context *ev,
+                                           struct winbindd_request *request)
+{
+       struct tevent_req *req, *subreq;
+       struct winbindd_lookupname_state *state;
+       char *domname, *name, *p;
+
+       req = tevent_req_create(mem_ctx, &state,
+                               struct winbindd_lookupname_state);
+       if (req == NULL) {
+               return NULL;
+       }
+       state->ev = ev;
+
+       /* Ensure null termination */
+       request->data.name.dom_name[
+               sizeof(request->data.name.dom_name)-1]='\0';
+       request->data.name.name[sizeof(request->data.name.name)-1]='\0';
+
+       /* cope with the name being a fully qualified name */
+       p = strstr(request->data.name.name, lp_winbind_separator());
+       if (p) {
+               *p = 0;
+               domname = request->data.name.name;
+               name = p+1;
+       } else if ((p = strchr(request->data.name.name, '@')) != NULL) {
+               /* upn */
+               domname = p + 1;
+               *p = 0;
+               name = request->data.name.name;
+       } else {
+               domname = request->data.name.dom_name;
+               name = request->data.name.name;
+       }
+
+       DEBUG(3, ("lookupname %s%s%s\n", domname, lp_winbind_separator(),
+                 name));
+
+       subreq = wb_lookupname_send(state, ev, domname, name, 0);
+       if (tevent_req_nomem(subreq, req)) {
+               return tevent_req_post(req, ev);
+       }
+       tevent_req_set_callback(subreq, winbindd_lookupname_done, req);
+       return req;
+}
+
+static void winbindd_lookupname_done(struct tevent_req *subreq)
+{
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct winbindd_lookupname_state *state = tevent_req_data(
+               req, struct winbindd_lookupname_state);
+       NTSTATUS status;
+
+       status = wb_lookupname_recv(subreq, &state->sid, &state->type);
+       TALLOC_FREE(subreq);
+       if (!NT_STATUS_IS_OK(status)) {
+               tevent_req_nterror(req, status);
+               return;
+       }
+       tevent_req_done(req);
+}
+
+NTSTATUS winbindd_lookupname_recv(struct tevent_req *req,
+                                 struct winbindd_response *response)
+{
+       struct winbindd_lookupname_state *state = tevent_req_data(
+               req, struct winbindd_lookupname_state);
+       NTSTATUS status;
+
+       if (tevent_req_is_nterror(req, &status)) {
+               DEBUG(5, ("Could not convert sid %s: %s\n",
+                         sid_string_dbg(&state->sid), nt_errstr(status)));
+               return status;
+       }
+       sid_to_fstring(response->data.sid.sid, &state->sid);
+       response->data.sid.type = state->type;
+       return NT_STATUS_OK;
+}

diff --git a/source3/winbindd/winbindd_proto.h b/source3/winbindd/winbindd_proto.h
index 2b493b2a675805e1a160f7a37540239e221e2d3a..678a9231def70571c4084328db06f5676463bdda 100644 (file)
--- a/source3/winbindd/winbindd_proto.h
+++ b/source3/winbindd/winbindd_proto.h
@@ -631,5 +631,10 @@ struct tevent_req *wb_lookupname_send(TALLOC_CTX *mem_ctx,
 NTSTATUS wb_lookupname_recv(struct tevent_req *req, struct dom_sid *sid,
                            enum lsa_SidType *type);
 
+struct tevent_req *winbindd_lookupname_send(TALLOC_CTX *mem_ctx,
+                                           struct tevent_context *ev,
+                                           struct winbindd_request *request);
+NTSTATUS winbindd_lookupname_recv(struct tevent_req *req,
+                                 struct winbindd_response *response);
 
 #endif /*  _WINBINDD_PROTO_H_  */

diff --git a/source3/winbindd/winbindd_sid.c b/source3/winbindd/winbindd_sid.c
index 287dfb7f6b19c37d02a80a0127e0d3f4f5bfce1c..ee1ee2b6bbe9e967fad7693b6c8ff4c7488c7f8c 100644 (file)
--- a/source3/winbindd/winbindd_sid.c
+++ b/source3/winbindd/winbindd_sid.c
@@ -27,66 +27,6 @@
 
 /* Convert a string  */
 
-/**
- * Look up the SID for a qualified name.  
- **/
-
-static void lookupname_recv(void *private_data, bool success,
-                           const DOM_SID *sid, enum lsa_SidType type);
-
-void winbindd_lookupname(struct winbindd_cli_state *state)
-{
-       char *name_domain, *name_user;
-       char *p;
-
-       /* Ensure null termination */
-       state->request->data.name.dom_name[sizeof(state->request->data.name.dom_name)-1]='\0';
-
-       /* Ensure null termination */
-       state->request->data.name.name[sizeof(state->request->data.name.name)-1]='\0';
-
-       /* cope with the name being a fully qualified name */
-       p = strstr(state->request->data.name.name, lp_winbind_separator());
-       if (p) {
-               *p = 0;
-               name_domain = state->request->data.name.name;
-               name_user = p+1;
-       } else if ((p = strchr(state->request->data.name.name, '@')) != NULL) {
-               /* upn */
-               name_domain = p + 1;
-               *p = 0;
-               name_user = state->request->data.name.name;
-       } else {
-               name_domain = state->request->data.name.dom_name;
-               name_user = state->request->data.name.name;
-       }
-
-       DEBUG(3, ("[%5lu]: lookupname %s%s%s\n", (unsigned long)state->pid,
-                 name_domain, lp_winbind_separator(), name_user));
-
-       winbindd_lookupname_async(state->mem_ctx, name_domain, name_user,
-                                 lookupname_recv, WINBINDD_LOOKUPNAME, 
-                                 state);
-}
-
-static void lookupname_recv(void *private_data, bool success,
-                           const DOM_SID *sid, enum lsa_SidType type)
-{
-       struct winbindd_cli_state *state =
-               talloc_get_type_abort(private_data, struct winbindd_cli_state);
-
-       if (!success) {
-               DEBUG(5, ("lookupname returned an error\n"));
-               request_error(state);
-               return;
-       }
-
-       sid_to_fstring(state->response->data.sid.sid, sid);
-       state->response->data.sid.type = type;
-       request_ok(state);
-       return;
-}
-
 void winbindd_lookuprids(struct winbindd_cli_state *state)
 {
        struct winbindd_domain *domain;