Properly warn about exit codes that indicate success while tests claim

failure.
(This used to be commit 92873264d707bed88beac54a73a29d66c011f80c)

diff --git a/source4/selftest/output/plain.pm b/source4/selftest/output/plain.pm
index 25ff74792e518f01e0a010ab8b8d8fbbdb52419c..f14e26b38d435cfddd5063230be1088d016d593e 100644 (file)
--- a/source4/selftest/output/plain.pm
+++ b/source4/selftest/output/plain.pm
@@ -81,6 +81,9 @@ sub end_testsuite($$$$$)
        my $out = "";
 
        if ($unexpected) {
+               if ($result eq "success" and not defined($reason)) {
+                       $reason = "Expected negative exit code, got positive exit code";
+               } 
                $self->output_msg("ERROR: $reason\n");
                push (@{$self->{suitesfailed}}, $name);
        } else {