removed the 'valgrind fix' that (although it may well remove a

valgrind warning) causes us to return a completely wrong 8.3 filename
in directory searches!

come on guys, this close to a release you need to TEST CODE BEFORE COMMITTING
(This used to be commit 381cea68b81aeb42b088677d2a8bfd410a7da329)

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index 4498f0727bd5f202d84c2b6aee0381d0635d8839..70e41010a144df68a92781a92d2fd90f00aa000b 100644 (file)
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -683,14 +683,6 @@ static BOOL get_lanman2_dir_entry(connection_struct *conn,
                                mangle_map(mangled_name,True,True,SNUM(conn));
                                mangled_name[12] = 0;
                                len = srvstr_push(outbuf, p+2, mangled_name, 24, STR_UPPER);
-#ifdef DEVELOPER
-                               /* valgrind fixer... */
-                               {
-                                       size_t sl = strlen(p+2);
-                                       if (24-sl)
-                                               memset(&p[sl+2], '\0', 24-sl);
-                               }
-#endif
                                SSVAL(p, 0, len);
                        } else {
                                SSVAL(p,0,0);