s4-drepl: fixed the checking of replica_flags in the drepl server

we were incorrectly avoiding a getncchanges when WRIT_REP was not set

Pair-Programmed-With: Anatoliy Atanasov <anatoliy.atanasov@postpath.com>

diff --git a/source4/dsdb/repl/drepl_out_helpers.c b/source4/dsdb/repl/drepl_out_helpers.c
index d2704ff133545dbfb75e0e297170c643862057dc..1477d6fb54d94b2564ec8e2b6a12e22926d07918 100644 (file)
--- a/source4/dsdb/repl/drepl_out_helpers.c
+++ b/source4/dsdb/repl/drepl_out_helpers.c
@@ -337,11 +337,6 @@ static void dreplsrv_op_pull_source_get_changes_trigger(struct tevent_req *req)
        NTSTATUS status;
        uint32_t replica_flags;
 
-       if ((rf1->replica_flags & DRSUAPI_DRS_WRIT_REP) == 0 &&
-           state->op->extended_op == DRSUAPI_EXOP_NONE) {
-               return;
-       }
-
        r = talloc(state, struct drsuapi_DsGetNCChanges);
        if (tevent_req_nomem(r, req)) {
                return;
@@ -389,8 +384,6 @@ static void dreplsrv_op_pull_source_get_changes_trigger(struct tevent_req *req)
                        DEBUG(0,(__location__ ": Failed to construct partial attribute set : %s\n", nt_errstr(status)));
                        return;
                }
-
-               replica_flags &= ~DRSUAPI_DRS_WRIT_REP;
        }
 
        r->in.bind_handle       = &drsuapi->bind_handle;