s4-pydsdb-py_samdb_ntds_objectGUID(): Avoid potential memory leak
authorKamen Mazdrashki <kamenim@samba.org>
Mon, 8 Nov 2010 21:40:14 +0000 (23:40 +0200)
committerKamen Mazdrashki <kamenim@samba.org>
Wed, 10 Nov 2010 08:20:01 +0000 (10:20 +0200)
in case py_ldb is not a valid LDB

source4/dsdb/pydsdb.c

index e270d7458b2b4de89344b73f89d58ad4020db42d..41985ba648d7fa4263d850282378b067f9207fc0 100644 (file)
@@ -414,19 +414,18 @@ static PyObject *py_samdb_ntds_objectGUID(PyObject *self, PyObject *args)
        TALLOC_CTX *mem_ctx;
        const struct GUID *guid;
 
-       mem_ctx = talloc_new(NULL);
-       if (mem_ctx == NULL) {
-               PyErr_NoMemory();
-               return NULL;
-       }
-
        if (!PyArg_ParseTuple(args, "O", &py_ldb)) {
-               talloc_free(mem_ctx);
                return NULL;
        }
 
        PyErr_LDB_OR_RAISE(py_ldb, ldb);
 
+       mem_ctx = talloc_new(NULL);
+       if (mem_ctx == NULL) {
+               PyErr_NoMemory();
+               return NULL;
+       }
+
        guid = samdb_ntds_objectGUID(ldb);
        if (guid == NULL) {
                PyErr_SetString(PyExc_RuntimeError, "Failed to find NTDS GUID");