git.samba.org
/
bbaumbach
/
samba-autobuild
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
c7fa030
)
pfm_verif: string concatenation efficiency cleanup
author
Björn Jacke
<bj@sernet.de>
Fri, 23 Aug 2019 00:21:17 +0000
(
02:21
+0200)
committer
Bjoern Jacke
<bjacke@samba.org>
Tue, 24 Sep 2019 12:22:45 +0000
(12:22 +0000)
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
source4/scripting/devel/pfm_verify.py
patch
|
blob
|
history
diff --git
a/source4/scripting/devel/pfm_verify.py
b/source4/scripting/devel/pfm_verify.py
index 2b33441bdcdfc0dd51e186366cc6653b4024f666..5cbeb3c3067df0721316eadbca77272cab3be606 100755
(executable)
--- a/
source4/scripting/devel/pfm_verify.py
+++ b/
source4/scripting/devel/pfm_verify.py
@@
-100,9
+100,7
@@
def _drs_fetch_pfm(server, samdb, creds, lp):
pfm_it = pfm.mappings[-1]
assert pfm_it.id_prefix == 0
assert pfm_it.oid.length == 21
- s = ''
- for x in pfm_it.oid.binary_oid:
- s += chr(x)
+ s = "".join(chr(x) for x in pfm_it.oid.binary_oid)
pfm_schi = ndr_unpack(drsblobs.schemaInfoBlob, s)
assert pfm_schi.marker == 0xFF
# remove schemaInfo element