selftest: avoid comparison against undefined value

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm
index 8786b320fa872379e322f009ff7bfdae8355233e..a3e2129b185404be19d77c61216da66c29e421f0 100755 (executable)
--- a/selftest/target/Samba3.pm
+++ b/selftest/target/Samba3.pm
@@ -304,7 +304,9 @@ sub setup_nt4_member
        print "PROVISIONING MEMBER...";
 
        my $require_mutexes = "dbwrap_tdb_require_mutexes:* = yes";
-       $require_mutexes = "" if ($ENV{SELFTEST_DONT_REQUIRE_TDB_MUTEX_SUPPORT} eq "1");
+       if ($ENV{SELFTEST_DONT_REQUIRE_TDB_MUTEX_SUPPORT} // '' eq "1") {
+               $require_mutexes = "";
+       }
 
        my $member_options = "
        security = domain

diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm
index 3fd70db457005beaba55ce88c0225b7b82712e03..e181289b66b28ed8f20bb273c725a4152d621c3a 100755 (executable)
--- a/selftest/target/Samba4.pm
+++ b/selftest/target/Samba4.pm
@@ -1790,7 +1790,9 @@ sub provision_ad_dc($$$$$$)
         my $conffile="$prefix_abs/etc/smb.conf";
 
        my $require_mutexes = "dbwrap_tdb_require_mutexes:* = yes";
-       $require_mutexes = "" if ($ENV{SELFTEST_DONT_REQUIRE_TDB_MUTEX_SUPPORT} eq "1");
+       if ($ENV{SELFTEST_DONT_REQUIRE_TDB_MUTEX_SUPPORT} // '' eq "1") {
+               $require_mutexes = "";
+       }
 
        my $config_h = {};